All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Cc: Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH RFC OSSTEST v1 10/12] Qualify TftpDiVersion with the suite.
Date: Fri, 8 Jan 2016 14:29:57 +0000	[thread overview]
Message-ID: <1452263399-14094-10-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1452263368.29416.39.camel@citrix.com>

This allows the version to differ e.g. between Wheezy and Jessie.

Update production-config* to set TftpDiVersion_jessie instead of just
TftpDiVersion, also add TftpDiVersion_wheezy using the version
replaced in commit f610ea162836 "Switch to Debian 8.0 (jessie) as OS
for test hosts".

In mfi-common we need to check for TftpDiVersion_$suite (_$guestsuite)
and TftpDiVersion manually since getconfig In that context will not
see any DebianSuite override in the environment.

This ensures that when a non-default suite is configured a
corresponding useful version of DI is selected.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
 Osstest.pm                  | 2 +-
 mfi-common                  | 6 ++++++
 production-config           | 3 ++-
 production-config-cambridge | 3 ++-
 4 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/Osstest.pm b/Osstest.pm
index 9ff86ab..814be28 100644
--- a/Osstest.pm
+++ b/Osstest.pm
@@ -224,7 +224,7 @@ sub readglobalconfig () {
     $c{TftpTmpDir} ||= "$c{TftpPlayDir}tmp/";
 
     $c{TftpDiBase} ||= "$c{TftpPlayDir}debian-installer";
-    $c{TftpDiVersion} ||= 'current';
+    $c{TftpDiVersion} ||= $c{ "TftpDiVersion_$c{DebianSuite}" } // 'current';
 
     $c{TftpGrubBase} ||= "$c{TftpPlayDir}grub";
     $c{TftpGrubVersion} ||= 'current';
diff --git a/mfi-common b/mfi-common
index c1c4ec5..1daa6dd 100644
--- a/mfi-common
+++ b/mfi-common
@@ -124,6 +124,9 @@ create_build_jobs () {
     fi
 
     if [ -z "$diversion" ] ; then
+        local diversion=`getconfig TftpDiVersion_$suite`
+    fi
+    if [ -z "$diversion" ] ; then
         local diversion=`getconfig TftpDiVersion`
     fi
 
@@ -413,6 +416,9 @@ test_matrix_iterate () {
     fi
 
     if [ -z "$diversion" ] ; then
+        local diversion=`getconfig TftpDiVersion_$guestsuite`
+    fi
+    if [ -z "$diversion" ] ; then
         local diversion=`getconfig TftpDiVersion`
     fi
 
diff --git a/production-config b/production-config
index b21153b..42948c8 100644
--- a/production-config
+++ b/production-config
@@ -87,7 +87,8 @@ TftpPxeTemplatesReal pxelinux.cfg/%ipaddrhex%
 
 TftpPxeGroup osstest
 # Update with ./mg-debian-installer-update(-all)
-TftpDiVersion 2015-09-18
+TftpDiVersion_wheezy 2015-09-07
+TftpDiVersion_jessie 2015-09-18
 
 # These should normally be the same.
 # Update with ./mg-cpu-microcode-update
diff --git a/production-config-cambridge b/production-config-cambridge
index b0b45ac..78d606b 100644
--- a/production-config-cambridge
+++ b/production-config-cambridge
@@ -69,7 +69,8 @@ TftpPxeTemplates %name%/pxelinux.cfg
 TftpPxeTemplatesReal pxelinux.cfg/%ipaddrhex%
 
 TftpPxeGroup osstest
-TftpDiVersion 2015-09-18
+TftpDiVersion_wheezy 2015-09-07
+TftpDiVersion_jessie 2015-09-18
 
 # These should normally be the same.
 MicrocodeUpdateAmd64 microcode.x86.2015-06-12.cpio
-- 
2.6.1

  parent reply	other threads:[~2016-01-08 14:29 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-08 14:29 [PATCH RFC OSSTEST v1 00/12] Specify host and guest os version in runvars Ian Campbell
2016-01-08 14:29 ` [PATCH RFC OSSTEST v1 01/12] Debian: Abolish $suite and $xopts{Suite} from preseed_* interfaces Ian Campbell
2016-01-08 15:08   ` Ian Jackson
2016-01-08 14:29 ` [PATCH RFC OSSTEST v1 02/12] target_var: Support fallback to all_(guest|host)_$vn Ian Campbell
2016-01-08 15:10   ` Ian Jackson
2016-01-08 14:29 ` [PATCH RFC OSSTEST v1 03/12] mfi-common: Rename $suite_runvars as $hostos_runvars Ian Campbell
2016-01-08 15:10   ` Ian Jackson
2016-01-08 14:29 ` [PATCH RFC OSSTEST v1 04/12] mfi-common: always add host suite to hostos_runvars Ian Campbell
2016-01-12 11:27   ` Ian Jackson
2016-01-08 14:29 ` [PATCH RFC OSSTEST v1 05/12] make-*flight: Abolish $defsuite and $guestdefsuite Ian Campbell
2016-01-12 14:18   ` Ian Jackson
2016-01-15 17:15     ` Ian Campbell
2016-01-08 14:29 ` [PATCH RFC OSSTEST v1 06/12] ts-host-install: Support DiVersion coming from runvars Ian Campbell
2016-01-12 14:19   ` Ian Jackson
2016-01-08 14:29 ` [PATCH RFC OSSTEST v1 07/12] ts-debian-di-install: Allow Di Version to come " Ian Campbell
2016-01-12 14:39   ` Ian Jackson
2016-01-15 16:33     ` Ian Campbell
2016-01-08 14:29 ` [PATCH RFC OSSTEST v1 08/12] make-flight: Set diversion runvar on d-i based test jobs Ian Campbell
2016-01-12 14:42   ` Ian Jackson
2016-01-08 14:29 ` [PATCH RFC OSSTEST v1 09/12] mfi-common: Set diversion for build & test host install Ian Campbell
2016-01-12 14:41   ` Ian Jackson
2016-01-15 17:36   ` Ian Campbell
2016-01-08 14:29 ` Ian Campbell [this message]
2016-01-12 15:19   ` [PATCH RFC OSSTEST v1 10/12] Qualify TftpDiVersion with the suite Ian Jackson
2016-01-08 14:29 ` [PATCH RFC OSSTEST v1 11/12] mfi-common: usual_debianhvm_image: derive version from $guestsuite Ian Campbell
2016-01-12 15:21   ` Ian Jackson
2016-01-08 14:29 ` [PATCH RFC OSSTEST v1 12/12] make-flight: Use older Debian for host and guest OS with older Xen Ian Campbell
2016-01-12 15:22   ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452263399-14094-10-git-send-email-ian.campbell@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.