All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Cc: Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH RFC OSSTEST v1 11/12] mfi-common: usual_debianhvm_image: derive version from $guestsuite
Date: Fri, 8 Jan 2016 14:29:58 +0000	[thread overview]
Message-ID: <1452263399-14094-11-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1452263368.29416.39.camel@citrix.com>

This more likely matches the callers intention.

Move the setting into production-config* alongside the Suite and
TftpDiVersion settings. Continue to support $DEBIAN_IMAGE_VERSION as an
override. The value for Wheezy is from what was replaced
in 610ea1628363 "Switch to Debian 8.0 (jessie) as OS for test hosts".

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
 mfi-common                  | 6 +++++-
 production-config           | 4 ++++
 production-config-cambridge | 4 ++++
 3 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/mfi-common b/mfi-common
index 1daa6dd..82f0503 100644
--- a/mfi-common
+++ b/mfi-common
@@ -347,7 +347,11 @@ job_create_test () {
 
 usual_debianhvm_image () {
   local arch=$1; shift
-  echo debian-${DEBIAN_IMAGE_VERSION-8.2.0}-$arch-CD-1.iso
+  local ver=$DEBIAN_IMAGE_VERSION
+  if [ -z "$ver" ] ; then
+      ver=`getconfig DebianImageVersion_$guestsuite`
+  fi
+  echo debian-$ver-$arch-CD-1.iso
 }
 
 # Iterate over xenarch, dom0arch and kernel calling test_matrix_do_one
diff --git a/production-config b/production-config
index 42948c8..21b215d 100644
--- a/production-config
+++ b/production-config
@@ -90,6 +90,10 @@ TftpPxeGroup osstest
 TftpDiVersion_wheezy 2015-09-07
 TftpDiVersion_jessie 2015-09-18
 
+# For ISO installs
+DebianImageVersion_wheezy 7.2.0
+DebianImageVersion_jessie 8.2.0
+
 # These should normally be the same.
 # Update with ./mg-cpu-microcode-update
 MicrocodeUpdateAmd64 microcode.x86.2015-06-12.cpio
diff --git a/production-config-cambridge b/production-config-cambridge
index 78d606b..a9be7a8 100644
--- a/production-config-cambridge
+++ b/production-config-cambridge
@@ -72,6 +72,10 @@ TftpPxeGroup osstest
 TftpDiVersion_wheezy 2015-09-07
 TftpDiVersion_jessie 2015-09-18
 
+# For ISO installs
+DebianImageVersion_wheezy 7.2.0
+DebianImageVersion_jessie 8.2.0
+
 # These should normally be the same.
 MicrocodeUpdateAmd64 microcode.x86.2015-06-12.cpio
 MicrocodeUpdateI386 microcode.x86.2015-06-12.cpio
-- 
2.6.1

  parent reply	other threads:[~2016-01-08 14:29 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-08 14:29 [PATCH RFC OSSTEST v1 00/12] Specify host and guest os version in runvars Ian Campbell
2016-01-08 14:29 ` [PATCH RFC OSSTEST v1 01/12] Debian: Abolish $suite and $xopts{Suite} from preseed_* interfaces Ian Campbell
2016-01-08 15:08   ` Ian Jackson
2016-01-08 14:29 ` [PATCH RFC OSSTEST v1 02/12] target_var: Support fallback to all_(guest|host)_$vn Ian Campbell
2016-01-08 15:10   ` Ian Jackson
2016-01-08 14:29 ` [PATCH RFC OSSTEST v1 03/12] mfi-common: Rename $suite_runvars as $hostos_runvars Ian Campbell
2016-01-08 15:10   ` Ian Jackson
2016-01-08 14:29 ` [PATCH RFC OSSTEST v1 04/12] mfi-common: always add host suite to hostos_runvars Ian Campbell
2016-01-12 11:27   ` Ian Jackson
2016-01-08 14:29 ` [PATCH RFC OSSTEST v1 05/12] make-*flight: Abolish $defsuite and $guestdefsuite Ian Campbell
2016-01-12 14:18   ` Ian Jackson
2016-01-15 17:15     ` Ian Campbell
2016-01-08 14:29 ` [PATCH RFC OSSTEST v1 06/12] ts-host-install: Support DiVersion coming from runvars Ian Campbell
2016-01-12 14:19   ` Ian Jackson
2016-01-08 14:29 ` [PATCH RFC OSSTEST v1 07/12] ts-debian-di-install: Allow Di Version to come " Ian Campbell
2016-01-12 14:39   ` Ian Jackson
2016-01-15 16:33     ` Ian Campbell
2016-01-08 14:29 ` [PATCH RFC OSSTEST v1 08/12] make-flight: Set diversion runvar on d-i based test jobs Ian Campbell
2016-01-12 14:42   ` Ian Jackson
2016-01-08 14:29 ` [PATCH RFC OSSTEST v1 09/12] mfi-common: Set diversion for build & test host install Ian Campbell
2016-01-12 14:41   ` Ian Jackson
2016-01-15 17:36   ` Ian Campbell
2016-01-08 14:29 ` [PATCH RFC OSSTEST v1 10/12] Qualify TftpDiVersion with the suite Ian Campbell
2016-01-12 15:19   ` Ian Jackson
2016-01-08 14:29 ` Ian Campbell [this message]
2016-01-12 15:21   ` [PATCH RFC OSSTEST v1 11/12] mfi-common: usual_debianhvm_image: derive version from $guestsuite Ian Jackson
2016-01-08 14:29 ` [PATCH RFC OSSTEST v1 12/12] make-flight: Use older Debian for host and guest OS with older Xen Ian Campbell
2016-01-12 15:22   ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452263399-14094-11-git-send-email-ian.campbell@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.