From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mips@linux-mips.org, linux-ia64@vger.kernel.org,
linux-sh@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
virtualization@lists.linux-foundation.org,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
x86@kernel.org, Tony Lindgren <tony@atomide.com>,
xen-devel@lists.xenproject.org, Ingo Molnar <mingo@elte.hu>,
linux-xtensa@linux-xtensa.org,
user-mode-linux-devel@lists.sourceforge.net,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Andrey Konovalov <andreyknvl@google.com>,
adi-buildroot-devel@lists.sourceforge.net,
Andy Whitcroft <apw@canonical.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-metag@vger.kernel.org,
linux-arm-kernel@lists.infradead.orgAndrewCooperan
Subject: [PATCH v2 2/3] checkpatch: check for __smp outside barrier.h
Date: Sun, 10 Jan 2016 11:57:08 +0000 [thread overview]
Message-ID: <1452427000-4520-3-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1452427000-4520-1-git-send-email-mst@redhat.com>
Introduction of __smp barriers cleans up a bunch of duplicate code, but
it gives people an additional handle onto a "new" set of barriers - just
because they're prefixed with __* unfortunately doesn't stop anyone from
using it (as happened with other arch stuff before.)
Add a checkpatch test so it will trigger a warning.
Reported-by: Russell King <linux@arm.linux.org.uk>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
scripts/checkpatch.pl | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 97b8b62..a96adcb 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5141,6 +5141,16 @@ sub process {
}
}
+ my $underscore_smp_barriers = qr{__smp_($smp_barriers)}x;
+
+ if ($realfile !~ m@^include/asm-generic/@ &&
+ $realfile !~ m@/barrier\.h$@ &&
+ $line =~ m/\b($underscore_smp_barriers)\s*\(/ &&
+ $line !~ m/^.\s*\#\s*define\s+($underscore_smp_barriers)\s*\(/) {
+ WARN("MEMORY_BARRIER",
+ "__smp memory barriers shouldn't be used outside barrier.h and asm-generic\n" . $herecurr);
+ }
+
# check for waitqueue_active without a comment.
if ($line =~ /\bwaitqueue_active\s*\(/) {
if (!ctx_has_comment($first_line, $linenr)) {
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
Peter Zijlstra <peterz@infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org,
Andrew Cooper <andrew.cooper3@citrix.com>,
virtualization@lists.linux-foundation.org,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
David Miller <davem@davemloft.net>,
linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-s390@vger.kernel.org, sparclinux@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-metag@vger.kernel.org, linux-mips@linux-mips.org,
x86@kernel.org, user-mode-linux-devel@lists.sourceforge.net,
adi-buildroot-devel@lists.sourceforge.net,
linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org,
xen-devel@lists.xenproject.org, Ingo Molnar <mingo@kernel.org>,
Tony Lindgren <tony@atomide.com>,
Andrey Konovalov <andreyknvl@google.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>
Subject: [PATCH v2 2/3] checkpatch: check for __smp outside barrier.h
Date: Sun, 10 Jan 2016 13:57:08 +0200 [thread overview]
Message-ID: <1452427000-4520-3-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1452427000-4520-1-git-send-email-mst@redhat.com>
Introduction of __smp barriers cleans up a bunch of duplicate code, but
it gives people an additional handle onto a "new" set of barriers - just
because they're prefixed with __* unfortunately doesn't stop anyone from
using it (as happened with other arch stuff before.)
Add a checkpatch test so it will trigger a warning.
Reported-by: Russell King <linux@arm.linux.org.uk>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
scripts/checkpatch.pl | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 97b8b62..a96adcb 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5141,6 +5141,16 @@ sub process {
}
}
+ my $underscore_smp_barriers = qr{__smp_($smp_barriers)}x;
+
+ if ($realfile !~ m@^include/asm-generic/@ &&
+ $realfile !~ m@/barrier\.h$@ &&
+ $line =~ m/\b($underscore_smp_barriers)\s*\(/ &&
+ $line !~ m/^.\s*\#\s*define\s+($underscore_smp_barriers)\s*\(/) {
+ WARN("MEMORY_BARRIER",
+ "__smp memory barriers shouldn't be used outside barrier.h and asm-generic\n" . $herecurr);
+ }
+
# check for waitqueue_active without a comment.
if ($line =~ /\bwaitqueue_active\s*\(/) {
if (!ctx_has_comment($first_line, $linenr)) {
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mips@linux-mips.org, linux-ia64@vger.kernel.org,
linux-sh@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
virtualization@lists.linux-foundation.org,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
x86@kernel.org, Tony Lindgren <tony@atomide.com>,
xen-devel@lists.xenproject.org, Ingo Molnar <mingo@elte.hu>,
linux-xtensa@linux-xtensa.org,
user-mode-linux-devel@lists.sourceforge.net,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Andrey Konovalov <andreyknvl@google.com>,
adi-buildroot-devel@lists.sourceforge.net,
Andy Whitcroft <apw@canonical.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-metag@vger.kernel.org,
linux-arm-kernel@lists.infradead.orgAndrewCooperan
Subject: [PATCH v2 2/3] checkpatch: check for __smp outside barrier.h
Date: Sun, 10 Jan 2016 13:57:08 +0200 [thread overview]
Message-ID: <1452427000-4520-3-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1452427000-4520-1-git-send-email-mst@redhat.com>
Introduction of __smp barriers cleans up a bunch of duplicate code, but
it gives people an additional handle onto a "new" set of barriers - just
because they're prefixed with __* unfortunately doesn't stop anyone from
using it (as happened with other arch stuff before.)
Add a checkpatch test so it will trigger a warning.
Reported-by: Russell King <linux@arm.linux.org.uk>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
scripts/checkpatch.pl | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 97b8b62..a96adcb 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5141,6 +5141,16 @@ sub process {
}
}
+ my $underscore_smp_barriers = qr{__smp_($smp_barriers)}x;
+
+ if ($realfile !~ m@^include/asm-generic/@ &&
+ $realfile !~ m@/barrier\.h$@ &&
+ $line =~ m/\b($underscore_smp_barriers)\s*\(/ &&
+ $line !~ m/^.\s*\#\s*define\s+($underscore_smp_barriers)\s*\(/) {
+ WARN("MEMORY_BARRIER",
+ "__smp memory barriers shouldn't be used outside barrier.h and asm-generic\n" . $herecurr);
+ }
+
# check for waitqueue_active without a comment.
if ($line =~ /\bwaitqueue_active\s*\(/) {
if (!ctx_has_comment($first_line, $linenr)) {
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mips@linux-mips.org, linux-ia64@vger.kernel.org,
linux-sh@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
virtualization@lists.linux-foundation.org,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
x86@kernel.org, Tony Lindgren <tony@atomide.com>,
xen-devel@lists.xenproject.org, Ingo Molnar <mingo@elte.hu>,
linux-xtensa@linux-xtensa.org,
user-mode-linux-devel@lists.sourceforge.net,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Andrey Konovalov <andreyknvl@google.com>,
adi-buildroot-devel@lists.sourceforge.net,
Andy Whitcroft <apw@canonical.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-metag@vger.kernel.org,
linux-arm-kernel@lists.infradead.orgAndrew Cooper <an>
Subject: [PATCH v2 2/3] checkpatch: check for __smp outside barrier.h
Date: Sun, 10 Jan 2016 13:57:08 +0200 [thread overview]
Message-ID: <1452427000-4520-3-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1452427000-4520-1-git-send-email-mst@redhat.com>
Introduction of __smp barriers cleans up a bunch of duplicate code, but
it gives people an additional handle onto a "new" set of barriers - just
because they're prefixed with __* unfortunately doesn't stop anyone from
using it (as happened with other arch stuff before.)
Add a checkpatch test so it will trigger a warning.
Reported-by: Russell King <linux@arm.linux.org.uk>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
scripts/checkpatch.pl | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 97b8b62..a96adcb 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5141,6 +5141,16 @@ sub process {
}
}
+ my $underscore_smp_barriers = qr{__smp_($smp_barriers)}x;
+
+ if ($realfile !~ m@^include/asm-generic/@ &&
+ $realfile !~ m@/barrier\.h$@ &&
+ $line =~ m/\b($underscore_smp_barriers)\s*\(/ &&
+ $line !~ m/^.\s*\#\s*define\s+($underscore_smp_barriers)\s*\(/) {
+ WARN("MEMORY_BARRIER",
+ "__smp memory barriers shouldn't be used outside barrier.h and asm-generic\n" . $herecurr);
+ }
+
# check for waitqueue_active without a comment.
if ($line =~ /\bwaitqueue_active\s*\(/) {
if (!ctx_has_comment($first_line, $linenr)) {
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: mst@redhat.com (Michael S. Tsirkin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/3] checkpatch: check for __smp outside barrier.h
Date: Sun, 10 Jan 2016 13:57:08 +0200 [thread overview]
Message-ID: <1452427000-4520-3-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1452427000-4520-1-git-send-email-mst@redhat.com>
Introduction of __smp barriers cleans up a bunch of duplicate code, but
it gives people an additional handle onto a "new" set of barriers - just
because they're prefixed with __* unfortunately doesn't stop anyone from
using it (as happened with other arch stuff before.)
Add a checkpatch test so it will trigger a warning.
Reported-by: Russell King <linux@arm.linux.org.uk>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
scripts/checkpatch.pl | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 97b8b62..a96adcb 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5141,6 +5141,16 @@ sub process {
}
}
+ my $underscore_smp_barriers = qr{__smp_($smp_barriers)}x;
+
+ if ($realfile !~ m@^include/asm-generic/@ &&
+ $realfile !~ m@/barrier\.h$@ &&
+ $line =~ m/\b($underscore_smp_barriers)\s*\(/ &&
+ $line !~ m/^.\s*\#\s*define\s+($underscore_smp_barriers)\s*\(/) {
+ WARN("MEMORY_BARRIER",
+ "__smp memory barriers shouldn't be used outside barrier.h and asm-generic\n" . $herecurr);
+ }
+
# check for waitqueue_active without a comment.
if ($line =~ /\bwaitqueue_active\s*\(/) {
if (!ctx_has_comment($first_line, $linenr)) {
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mips@linux-mips.org, linux-ia64@vger.kernel.org,
linux-sh@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
virtualization@lists.linux-foundation.org,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
x86@kernel.org, Tony Lindgren <tony@atomide.com>,
xen-devel@lists.xenproject.org, Ingo Molnar <mingo@elte.hu>,
linux-xtensa@linux-xtensa.org,
user-mode-linux-devel@lists.sourceforge.net,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Andrey Konovalov <andreyknvl@google.com>,
adi-buildroot-devel@lists.sourceforge.net,
Andy Whitcroft <apw@canonical.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-metag@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Andrew Cooper <an>
Subject: [PATCH v2 2/3] checkpatch: check for __smp outside barrier.h
Date: Sun, 10 Jan 2016 13:57:08 +0200 [thread overview]
Message-ID: <1452427000-4520-3-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1452427000-4520-1-git-send-email-mst@redhat.com>
Introduction of __smp barriers cleans up a bunch of duplicate code, but
it gives people an additional handle onto a "new" set of barriers - just
because they're prefixed with __* unfortunately doesn't stop anyone from
using it (as happened with other arch stuff before.)
Add a checkpatch test so it will trigger a warning.
Reported-by: Russell King <linux@arm.linux.org.uk>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
scripts/checkpatch.pl | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 97b8b62..a96adcb 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5141,6 +5141,16 @@ sub process {
}
}
+ my $underscore_smp_barriers = qr{__smp_($smp_barriers)}x;
+
+ if ($realfile !~ m@^include/asm-generic/@ &&
+ $realfile !~ m@/barrier\.h$@ &&
+ $line =~ m/\b($underscore_smp_barriers)\s*\(/ &&
+ $line !~ m/^.\s*\#\s*define\s+($underscore_smp_barriers)\s*\(/) {
+ WARN("MEMORY_BARRIER",
+ "__smp memory barriers shouldn't be used outside barrier.h and asm-generic\n" . $herecurr);
+ }
+
# check for waitqueue_active without a comment.
if ($line =~ /\bwaitqueue_active\s*\(/) {
if (!ctx_has_comment($first_line, $linenr)) {
--
MST
next prev parent reply other threads:[~2016-01-10 11:57 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-10 11:56 [PATCH v2 0/3] checkpatch: handling of memory barriers Michael S. Tsirkin
2016-01-10 11:56 ` Michael S. Tsirkin
2016-01-10 11:56 ` Michael S. Tsirkin
2016-01-10 11:56 ` Michael S. Tsirkin
2016-01-10 11:56 ` [PATCH v2 1/3] checkpatch.pl: add missing " Michael S. Tsirkin
2016-01-10 11:56 ` Michael S. Tsirkin
2016-01-10 11:56 ` Michael S. Tsirkin
2016-01-10 11:56 ` Michael S. Tsirkin
2016-01-10 15:07 ` Joe Perches
2016-01-10 15:07 ` Joe Perches
2016-01-10 15:07 ` Joe Perches
2016-01-10 15:07 ` Joe Perches
2016-01-10 15:07 ` Joe Perches
2016-01-10 15:07 ` Joe Perches
2016-01-10 15:07 ` Joe Perches
2016-01-10 15:07 ` Joe Perches
2016-01-10 15:17 ` Joe Perches
2016-01-10 15:17 ` Joe Perches
[not found] ` <1452438425.7773.21.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2016-01-10 15:17 ` Joe Perches
2016-01-10 15:17 ` Joe Perches
2016-01-10 15:17 ` Joe Perches
2016-01-10 15:17 ` Joe Perches
2016-01-10 15:17 ` Joe Perches
2016-01-10 19:29 ` Michael S. Tsirkin
2016-01-10 19:29 ` Michael S. Tsirkin
2016-01-10 19:29 ` Michael S. Tsirkin
2016-01-10 19:29 ` Michael S. Tsirkin
2016-01-10 19:29 ` Michael S. Tsirkin
2016-01-10 19:29 ` Michael S. Tsirkin
2016-01-10 19:13 ` Michael S. Tsirkin
2016-01-10 19:13 ` Michael S. Tsirkin
2016-01-10 19:13 ` Michael S. Tsirkin
2016-01-10 19:13 ` Michael S. Tsirkin
2016-01-10 19:13 ` Michael S. Tsirkin
2016-01-10 19:13 ` Michael S. Tsirkin
2016-01-10 19:13 ` Michael S. Tsirkin
2016-01-10 11:56 ` Michael S. Tsirkin
2016-01-10 11:56 ` Michael S. Tsirkin
2016-01-10 11:57 ` [PATCH v2 2/3] checkpatch: check for __smp outside barrier.h Michael S. Tsirkin
2016-01-10 11:57 ` Michael S. Tsirkin [this message]
2016-01-10 11:57 ` Michael S. Tsirkin
2016-01-10 11:57 ` Michael S. Tsirkin
2016-01-10 11:57 ` Michael S. Tsirkin
2016-01-10 11:57 ` Michael S. Tsirkin
2016-01-10 11:57 ` Michael S. Tsirkin
2016-01-10 15:08 ` Joe Perches
2016-01-10 15:08 ` Joe Perches
2016-01-10 15:08 ` Joe Perches
2016-01-10 15:08 ` Joe Perches
2016-01-10 15:08 ` Joe Perches
2016-01-10 15:08 ` Joe Perches
2016-01-10 15:08 ` Joe Perches
2016-01-10 15:08 ` Joe Perches
2016-01-10 11:57 ` [PATCH v2 3/3] checkpatch: add virt barriers Michael S. Tsirkin
2016-01-10 11:57 ` Michael S. Tsirkin
2016-01-10 11:57 ` Michael S. Tsirkin
2016-01-10 11:57 ` Michael S. Tsirkin
2016-01-10 11:57 ` Michael S. Tsirkin
2016-01-10 11:57 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452427000-4520-3-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=andreyknvl@google.com \
--cc=apw@canonical.com \
--cc=arnd@arndb.de \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.orgAndrewCooperan \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-metag@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=sparclinux@vger.kernel.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.