All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Subject: [PATCH v2 5/6] drm/i915: Use simplest form for flushing the single cacheline in the HWS
Date: Sat, 16 Jan 2016 09:46:19 +0000	[thread overview]
Message-ID: <1452937580-3625-5-git-send-email-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <1452937580-3625-1-git-send-email-chris@chris-wilson.co.uk>

Rather than call a function to compute the matching cachelines and
clflush them, just call the clflush *instruction* directly. We also know
that we can use the unpatched plain clflush rather than the clflushopt
alternative.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/intel_ringbuffer.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.h b/drivers/gpu/drm/i915/intel_ringbuffer.h
index b30ad99a54bf..cdd9ac88b055 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.h
+++ b/drivers/gpu/drm/i915/intel_ringbuffer.h
@@ -389,8 +389,9 @@ intel_ring_sync_index(struct intel_engine_cs *ring,
 static inline void
 intel_flush_status_page(struct intel_engine_cs *ring, int reg)
 {
-	drm_clflush_virt_range(&ring->status_page.page_addr[reg],
-			       sizeof(uint32_t));
+	mb();
+	clflush(&ring->status_page.page_addr[reg]);
+	mb();
 }
 
 static inline u32
-- 
2.7.0.rc3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2016-01-16  9:46 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-15 14:35 "missed-interrupt" syndrome on Broadwell+ Chris Wilson
2016-01-15 14:35 ` [PATCH 1/6] drm/i915: Remove forcewake dance from seqno/irq barrier on legacy gen6+ Chris Wilson
2016-01-15 17:55   ` Mika Kuoppala
2016-01-15 14:35 ` [PATCH 2/6] drm/i915: Separate out the seqno-barrier from engine->get_seqno Chris Wilson
2016-01-15 14:35 ` [PATCH 3/6] drm/i915: Broadwell execlists needs exactly the same seqno w/a as legacy Chris Wilson
2016-01-15 14:35 ` [PATCH 4/6] drm/i915: Harden detection of missed interrupts Chris Wilson
2016-01-15 14:35 ` [PATCH 5/6] drm/i915: Use simplest form for flushing the single cacheline in the HWS Chris Wilson
2016-01-15 14:35 ` [PATCH 6/6] drm/i915: Replace manual barrier() with READ_ONCE() in HWS accessor Chris Wilson
2016-01-15 15:20 ` ✗ Fi.CI.BAT: warning for series starting with [1/6] drm/i915: Remove forcewake dance from seqno/irq barrier on legacy gen6+ Patchwork
2016-01-16  9:46 ` [PATCH v2 1/6] " Chris Wilson
2016-01-16  9:46   ` [PATCH v2 2/6] drm/i915: Separate out the seqno-barrier from engine->get_seqno Chris Wilson
2016-01-16  9:46   ` [PATCH v2 3/6] drm/i915: Use ordered seqno write interrupt generation on gen8+ execlists Chris Wilson
2016-01-18  8:58     ` [PATCH] magic-clflush-fix Chris Wilson
2016-01-18  9:02       ` Chris Wilson
2016-01-18  9:02     ` [PATCH] drm/i915: Use ordered seqno write interrupt generation on gen8+ execlists Chris Wilson
2016-01-16  9:46   ` [PATCH v2 4/6] drm/i915: Harden detection of missed interrupts Chris Wilson
2016-01-18 13:07     ` Mika Kuoppala
2016-01-18 15:35       ` Chris Wilson
2016-01-16  9:46   ` Chris Wilson [this message]
2016-01-16  9:46   ` [PATCH v2 6/6] drm/i915: Replace manual barrier() with READ_ONCE() in HWS accessor Chris Wilson
2016-01-16 10:01 ` ✗ Fi.CI.BAT: failure for series starting with [1/6] drm/i915: Remove forcewake dance from seqno/irq barrier on legacy gen6+ (rev6) Patchwork
2016-01-18  9:30 ` ✗ Fi.CI.BAT: failure for series starting with [1/6] drm/i915: Remove forcewake dance from seqno/irq barrier on legacy gen6+ (rev8) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452937580-3625-5-git-send-email-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=mika.kuoppala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.