All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, Vinod Koul <vinod.koul@intel.com>
Subject: [PATCH 3/3] tinycompress: crec: make functions static
Date: Mon, 18 Jan 2016 22:00:03 +0530	[thread overview]
Message-ID: <1453134603-25356-4-git-send-email-vinod.koul@intel.com> (raw)
In-Reply-To: <1453134603-25356-1-git-send-email-vinod.koul@intel.com>

Sparse rightly complains some functions should be static so make them static

crec.c:113:26: warning: symbol 'blank_wave_header' was not declared. Should it be static?
crec.c:239:6: warning: symbol 'capture_samples' was not declared. Should it be static?

Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
 src/utils/crec.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/utils/crec.c b/src/utils/crec.c
index 6e8166d8f77b..8d5b7b0b2c30 100644
--- a/src/utils/crec.c
+++ b/src/utils/crec.c
@@ -110,7 +110,7 @@ struct wave_header {
 	} __attribute__((__packed__)) data;
 } __attribute__((__packed__));
 
-const struct wave_header blank_wave_header = {
+static const struct wave_header blank_wave_header = {
 	.riff = {
 		.chunk = {
 			.desc = "RIFF",
@@ -236,7 +236,7 @@ static int finish_record(void)
 	return 0;
 }
 
-void capture_samples(char *name, unsigned int card, unsigned int device,
+static void capture_samples(char *name, unsigned int card, unsigned int device,
 		     unsigned long buffer_size, unsigned int frag,
 		     unsigned int length, unsigned int rate,
 		     unsigned int channels, unsigned int format)
-- 
1.9.1

      parent reply	other threads:[~2016-01-18 16:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-18 16:30 [PATCH 0/3] tinycompress: fix spare warnings Vinod Koul
2016-01-18 16:30 ` [PATCH 1/3] tinycompress: cplay: make functions static Vinod Koul
2016-01-18 16:30 ` [PATCH 2/3] tinycompress: crec: fix function declaration Vinod Koul
2016-01-18 16:30 ` Vinod Koul [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453134603-25356-4-git-send-email-vinod.koul@intel.com \
    --to=vinod.koul@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.