All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@samsung.com>
To: linux-samsung-soc@vger.kernel.org
Cc: Sangbeom Kim <sbkim73@samsung.com>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	Andi Shyti <andi.shyti@samsung.com>,
	Andi Shyti <andi@etezian.org>,
	Yadwinder Singh Brar <yadi.brar01@gmail.com>,
	Jaehoon Chung <jh80.chung@samsung.com>
Subject: [PATCH v3 1/4] clk: s2mps11: merge two for loops in one
Date: Wed, 20 Jan 2016 19:14:21 +0900	[thread overview]
Message-ID: <1453284864-8082-2-git-send-email-andi.shyti@samsung.com> (raw)
In-Reply-To: <1453284864-8082-1-git-send-email-andi.shyti@samsung.com>

the driver already loops once, there is no reason to loop again
for a different purpose. Merge the second loop into the first.

Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
---
 drivers/clk/clk-s2mps11.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/clk/clk-s2mps11.c b/drivers/clk/clk-s2mps11.c
index d266299..e7b97f4 100644
--- a/drivers/clk/clk-s2mps11.c
+++ b/drivers/clk/clk-s2mps11.c
@@ -244,12 +244,6 @@ static int s2mps11_clk_probe(struct platform_device *pdev)
 			ret = -ENOMEM;
 			goto err_reg;
 		}
-	}
-
-	for (i = 0; i < S2MPS11_CLKS_NUM; i++) {
-		/* Skip clocks not present on S2MPS14 */
-		if (!clks_init[i].name)
-			continue;
 		clk_table[i] = s2mps11_clks[i].clk;
 	}
 
-- 
2.7.0.rc3

  reply	other threads:[~2016-01-20 10:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-20 10:14 [PATCH v3 0/4] s2mps11 clock driver refactoring Andi Shyti
2016-01-20 10:14 ` Andi Shyti [this message]
2016-01-21  0:20   ` [PATCH v3 1/4] clk: s2mps11: merge two for loops in one Krzysztof Kozlowski
2016-01-30  0:34   ` Stephen Boyd
2016-01-20 10:14 ` [PATCH v3 2/4] clk: s2mps11: allocate only one structure for clock init Andi Shyti
2016-01-21  0:23   ` Krzysztof Kozlowski
2016-01-30  0:34   ` Stephen Boyd
2016-01-20 10:14 ` [PATCH v3 3/4] clk: s2mps11: remove redundant static variables declaration Andi Shyti
2016-01-21  0:29   ` Krzysztof Kozlowski
2016-01-30  0:34   ` Stephen Boyd
2016-01-20 10:14 ` [PATCH v3 4/4] clk: s2mps11: remove redundant code Andi Shyti
2016-01-21  0:29   ` Krzysztof Kozlowski
2016-01-30  0:34   ` Stephen Boyd
2016-01-21  0:18 ` [PATCH v3 0/4] s2mps11 clock driver refactoring Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453284864-8082-2-git-send-email-andi.shyti@samsung.com \
    --to=andi.shyti@samsung.com \
    --cc=andi@etezian.org \
    --cc=jh80.chung@samsung.com \
    --cc=k.kozlowski@samsung.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sbkim73@samsung.com \
    --cc=sboyd@codeaurora.org \
    --cc=yadi.brar01@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.