All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthias Brugger <matthias.bgg@gmail.com>
To: linux-mediatek@lists.infradead.org, s.hauer@pengutronix.de
Cc: treding@nvidia.com, k.kozlowski@samsung.com,
	henryc.chen@mediatek.com, flora.fu@mediatek.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Matthias Brugger <matthias.bgg@gmail.com>
Subject: [PATCH] soc: mediatek: PMIC wrap: Delete unused regmap support
Date: Thu, 21 Jan 2016 11:41:59 +0100	[thread overview]
Message-ID: <1453372919-15602-1-git-send-email-matthias.bgg@gmail.com> (raw)

PMIC wrapper does not use regmap support, although some regmap
code slipped into the driver. This patch deletes this code parts.

Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
---
 drivers/soc/mediatek/mtk-pmic-wrap.c | 25 -------------------------
 1 file changed, 25 deletions(-)

diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
index 105597a..83b22bf 100644
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -18,7 +18,6 @@
 #include <linux/module.h>
 #include <linux/of_device.h>
 #include <linux/platform_device.h>
-#include <linux/regmap.h>
 #include <linux/reset.h>
 
 #define PWRAP_MT8135_BRIDGE_IORD_ARB_EN		0x4
@@ -366,7 +365,6 @@ static struct pmic_wrapper_type pwrap_mt8173 = {
 struct pmic_wrapper {
 	struct device *dev;
 	void __iomem *base;
-	struct regmap *regmap;
 	int *regs;
 	enum pwrap_type type;
 	u32 arb_en_all;
@@ -475,16 +473,6 @@ static int pwrap_read(struct pmic_wrapper *wrp, u32 adr, u32 *rdata)
 	return 0;
 }
 
-static int pwrap_regmap_read(void *context, u32 adr, u32 *rdata)
-{
-	return pwrap_read(context, adr, rdata);
-}
-
-static int pwrap_regmap_write(void *context, u32 adr, u32 wdata)
-{
-	return pwrap_write(context, adr, wdata);
-}
-
 static int pwrap_reset_spislave(struct pmic_wrapper *wrp)
 {
 	int ret, i;
@@ -780,15 +768,6 @@ static irqreturn_t pwrap_interrupt(int irqno, void *dev_id)
 	return IRQ_HANDLED;
 }
 
-static const struct regmap_config pwrap_regmap_config = {
-	.reg_bits = 16,
-	.val_bits = 16,
-	.reg_stride = 2,
-	.reg_read = pwrap_regmap_read,
-	.reg_write = pwrap_regmap_write,
-	.max_register = 0xffff,
-};
-
 static struct of_device_id of_pwrap_match_tbl[] = {
 	{
 		.compatible = "mediatek,mt8135-pwrap",
@@ -904,10 +883,6 @@ static int pwrap_probe(struct platform_device *pdev)
 	if (ret)
 		goto err_out2;
 
-	wrp->regmap = devm_regmap_init(wrp->dev, NULL, wrp, &pwrap_regmap_config);
-	if (IS_ERR(wrp->regmap))
-		return PTR_ERR(wrp->regmap);
-
 	ret = of_platform_populate(np, NULL, NULL, wrp->dev);
 	if (ret) {
 		dev_dbg(wrp->dev, "failed to create child devices at %s\n",
-- 
2.6.2

WARNING: multiple messages have this Message-ID (diff)
From: matthias.bgg@gmail.com (Matthias Brugger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] soc: mediatek: PMIC wrap: Delete unused regmap support
Date: Thu, 21 Jan 2016 11:41:59 +0100	[thread overview]
Message-ID: <1453372919-15602-1-git-send-email-matthias.bgg@gmail.com> (raw)

PMIC wrapper does not use regmap support, although some regmap
code slipped into the driver. This patch deletes this code parts.

Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
---
 drivers/soc/mediatek/mtk-pmic-wrap.c | 25 -------------------------
 1 file changed, 25 deletions(-)

diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
index 105597a..83b22bf 100644
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -18,7 +18,6 @@
 #include <linux/module.h>
 #include <linux/of_device.h>
 #include <linux/platform_device.h>
-#include <linux/regmap.h>
 #include <linux/reset.h>
 
 #define PWRAP_MT8135_BRIDGE_IORD_ARB_EN		0x4
@@ -366,7 +365,6 @@ static struct pmic_wrapper_type pwrap_mt8173 = {
 struct pmic_wrapper {
 	struct device *dev;
 	void __iomem *base;
-	struct regmap *regmap;
 	int *regs;
 	enum pwrap_type type;
 	u32 arb_en_all;
@@ -475,16 +473,6 @@ static int pwrap_read(struct pmic_wrapper *wrp, u32 adr, u32 *rdata)
 	return 0;
 }
 
-static int pwrap_regmap_read(void *context, u32 adr, u32 *rdata)
-{
-	return pwrap_read(context, adr, rdata);
-}
-
-static int pwrap_regmap_write(void *context, u32 adr, u32 wdata)
-{
-	return pwrap_write(context, adr, wdata);
-}
-
 static int pwrap_reset_spislave(struct pmic_wrapper *wrp)
 {
 	int ret, i;
@@ -780,15 +768,6 @@ static irqreturn_t pwrap_interrupt(int irqno, void *dev_id)
 	return IRQ_HANDLED;
 }
 
-static const struct regmap_config pwrap_regmap_config = {
-	.reg_bits = 16,
-	.val_bits = 16,
-	.reg_stride = 2,
-	.reg_read = pwrap_regmap_read,
-	.reg_write = pwrap_regmap_write,
-	.max_register = 0xffff,
-};
-
 static struct of_device_id of_pwrap_match_tbl[] = {
 	{
 		.compatible = "mediatek,mt8135-pwrap",
@@ -904,10 +883,6 @@ static int pwrap_probe(struct platform_device *pdev)
 	if (ret)
 		goto err_out2;
 
-	wrp->regmap = devm_regmap_init(wrp->dev, NULL, wrp, &pwrap_regmap_config);
-	if (IS_ERR(wrp->regmap))
-		return PTR_ERR(wrp->regmap);
-
 	ret = of_platform_populate(np, NULL, NULL, wrp->dev);
 	if (ret) {
 		dev_dbg(wrp->dev, "failed to create child devices at %s\n",
-- 
2.6.2

             reply	other threads:[~2016-01-21 10:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-21 10:41 Matthias Brugger [this message]
2016-01-21 10:41 ` [PATCH] soc: mediatek: PMIC wrap: Delete unused regmap support Matthias Brugger
2016-01-21 10:49 ` Matthias Brugger
2016-01-21 10:49   ` Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453372919-15602-1-git-send-email-matthias.bgg@gmail.com \
    --to=matthias.bgg@gmail.com \
    --cc=flora.fu@mediatek.com \
    --cc=henryc.chen@mediatek.com \
    --cc=k.kozlowski@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.