All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rafael Antognolli <rafael.antognolli@intel.com>
To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>
Subject: [PATCH v10 4/4] drm/radeon: Fix WARN_ON if DRM_DP_AUX_CHARDEV is enabled
Date: Thu, 21 Jan 2016 15:10:21 -0800	[thread overview]
Message-ID: <1453417821-2811-5-git-send-email-rafael.antognolli@intel.com> (raw)
In-Reply-To: <1453417821-2811-1-git-send-email-rafael.antognolli@intel.com>

From: Lukas Wunner <lukas@wunner.de>

Rafael Antognolli's new DRM_DP_AUX_CHARDEV feature causes a WARN_ON
if drm_dp_aux->dev == drm_connector->kdev and drm_dp_aux_unregister()
is called after drm_connector_unregister(). radeon is the only driver
affected by this besides i915. (amdgpu calls drm_dp_aux_unregister()
before drm_connector_unregister().)

Cc: Rafael Antognolli <rafael.antognolli@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Lukas Wunner <lukas@wunner.de>
---
 drivers/gpu/drm/radeon/radeon_display.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
index b3bb923..a885dae 100644
--- a/drivers/gpu/drm/radeon/radeon_display.c
+++ b/drivers/gpu/drm/radeon/radeon_display.c
@@ -1684,6 +1684,9 @@ void radeon_modeset_fini(struct radeon_device *rdev)
 	radeon_fbdev_fini(rdev);
 	kfree(rdev->mode_info.bios_hardcoded_edid);
 
+	/* free i2c buses */
+	radeon_i2c_fini(rdev);
+
 	if (rdev->mode_info.mode_config_initialized) {
 		radeon_afmt_fini(rdev);
 		drm_kms_helper_poll_fini(rdev->ddev);
@@ -1691,8 +1694,6 @@ void radeon_modeset_fini(struct radeon_device *rdev)
 		drm_mode_config_cleanup(rdev->ddev);
 		rdev->mode_info.mode_config_initialized = false;
 	}
-	/* free i2c buses */
-	radeon_i2c_fini(rdev);
 }
 
 static bool is_hdtv_mode(const struct drm_display_mode *mode)
-- 
2.4.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2016-01-21 23:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-21 23:10 [PATCH v10 0/4] Add drm_dp_aux chardev support Rafael Antognolli
2016-01-21 23:10 ` [PATCH v10 1/4] drm/kms_helper: Add a common place to call init and exit functions Rafael Antognolli
2016-02-12 11:51   ` Ville Syrjälä
2016-01-21 23:10 ` [PATCH v10 2/4] drm/dp: Add a drm_aux-dev module for reading/writing dpcd registers Rafael Antognolli
2016-02-12 11:53   ` Ville Syrjälä
2016-02-12 13:23     ` [Intel-gfx] " Daniel Vetter
2016-01-21 23:10 ` [PATCH v10 3/4] drm/i915: Set aux.dev to the drm_connector device, instead of drm_device Rafael Antognolli
2016-02-12 20:28   ` Imre Deak
2016-02-14 18:21     ` Daniel Vetter
2016-01-21 23:10 ` Rafael Antognolli [this message]
2016-02-12 20:56   ` [PATCH v10 4/4] drm/radeon: Fix WARN_ON if DRM_DP_AUX_CHARDEV is enabled Alex Deucher
2016-01-22  9:15 ` ✗ Fi.CI.BAT: warning for Add drm_dp_aux chardev support. (rev5) Patchwork
2016-02-12 12:01   ` Ville Syrjälä
2016-02-12 21:21     ` Rafael Antognolli
2016-02-12 21:47       ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453417821-2811-5-git-send-email-rafael.antognolli@intel.com \
    --to=rafael.antognolli@intel.com \
    --cc=alexander.deucher@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.