All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Zhang Rui <rui.zhang@intel.com>, Eduardo Valentin <edubezval@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
	spear-devel@list.st.com, Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] thermal: allow spear-thermal driver to be a module
Date: Mon, 25 Jan 2016 17:44:11 +0100	[thread overview]
Message-ID: <1453740264-1972562-3-git-send-email-arnd@arndb.de> (raw)
In-Reply-To: <1453740264-1972562-1-git-send-email-arnd@arndb.de>

When the thermal subsystem is a loadable module, the spear driver
fails to build:

drivers/thermal/built-in.o: In function `spear_thermal_exit':
spear_thermal.c:(.text+0xf8): undefined reference to `thermal_zone_device_unregister'
drivers/thermal/built-in.o: In function `spear_thermal_probe':
spear_thermal.c:(.text+0x230): undefined reference to `thermal_zone_device_register'

This changes the symbol to a tristate, so Kconfig can track the
dependency correctly.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/thermal/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 8cc4ac64a91c..0852fd028dc9 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -195,7 +195,7 @@ config IMX_THERMAL
 	  passive trip is crossed.
 
 config SPEAR_THERMAL
-	bool "SPEAr thermal sensor driver"
+	tristate "SPEAr thermal sensor driver"
 	depends on PLAT_SPEAR || COMPILE_TEST
 	depends on OF
 	help
-- 
2.7.0

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] thermal: allow spear-thermal driver to be a module
Date: Mon, 25 Jan 2016 17:44:11 +0100	[thread overview]
Message-ID: <1453740264-1972562-3-git-send-email-arnd@arndb.de> (raw)
In-Reply-To: <1453740264-1972562-1-git-send-email-arnd@arndb.de>

When the thermal subsystem is a loadable module, the spear driver
fails to build:

drivers/thermal/built-in.o: In function `spear_thermal_exit':
spear_thermal.c:(.text+0xf8): undefined reference to `thermal_zone_device_unregister'
drivers/thermal/built-in.o: In function `spear_thermal_probe':
spear_thermal.c:(.text+0x230): undefined reference to `thermal_zone_device_register'

This changes the symbol to a tristate, so Kconfig can track the
dependency correctly.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/thermal/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 8cc4ac64a91c..0852fd028dc9 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -195,7 +195,7 @@ config IMX_THERMAL
 	  passive trip is crossed.
 
 config SPEAR_THERMAL
-	bool "SPEAr thermal sensor driver"
+	tristate "SPEAr thermal sensor driver"
 	depends on PLAT_SPEAR || COMPILE_TEST
 	depends on OF
 	help
-- 
2.7.0

  parent reply	other threads:[~2016-01-25 16:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-25 16:44 [PATCH 0/3] randconfig warning fixes for thermal Arnd Bergmann
2016-01-25 16:44 ` Arnd Bergmann
2016-01-25 16:44 ` [PATCH 1/3] thermal: spear: use __maybe_unused for PM functions Arnd Bergmann
2016-01-25 16:44   ` Arnd Bergmann
2016-01-25 16:44 ` Arnd Bergmann [this message]
2016-01-25 16:44   ` [PATCH 2/3] thermal: allow spear-thermal driver to be a module Arnd Bergmann
2016-01-25 16:44 ` [PATCH 3/3] thermal: allow u8500-thermal " Arnd Bergmann
2016-01-25 16:44   ` Arnd Bergmann
2016-01-27  7:33   ` Lee Jones
2016-01-27  7:33     ` Lee Jones
2016-02-09 22:10     ` Eduardo Valentin
2016-02-09 22:10       ` Eduardo Valentin
2016-02-05 14:44   ` Linus Walleij
2016-02-05 14:44     ` Linus Walleij
2016-02-05 14:44     ` Linus Walleij
2016-02-09 22:18 ` [PATCH 0/3] randconfig warning fixes for thermal Eduardo Valentin
2016-02-09 22:18   ` Eduardo Valentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453740264-1972562-3-git-send-email-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=edubezval@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=spear-devel@list.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.