All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: [PATCH 2/3] drm/i915: Stop depending upon CONFIG_AGP/_INTEL
Date: Tue, 26 Jan 2016 19:49:55 +0100	[thread overview]
Message-ID: <1453834196-5741-2-git-send-email-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <1453834196-5741-1-git-send-email-daniel.vetter@ffwll.ch>

We need this to be able to paper over some CI fail: DMA API debuggin
complaints that we leak the gmch scratch page, but fundamentally
that's the only way to do it if there's both the intel-agp and i915
driver using it: intel-agp shadow-attaches, i915 binds for real to the
gpu. But when i915 unloads we need to keep the dma-mapping for
intel-agp around, and the dma debugging code doesn't approve of that.

With this patch we can disable CONFIG_AGP_INTEL and avoid this
troubel.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93769
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 drivers/gpu/drm/i915/Kconfig | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
index fcd77b27514d..9aa7d2d98add 100644
--- a/drivers/gpu/drm/i915/Kconfig
+++ b/drivers/gpu/drm/i915/Kconfig
@@ -2,9 +2,7 @@ config DRM_I915
 	tristate "Intel 8xx/9xx/G3x/G4x/HD Graphics"
 	depends on DRM
 	depends on X86 && PCI
-	depends on (AGP || AGP=n)
 	select INTEL_GTT
-	select AGP_INTEL if AGP
 	select INTERVAL_TREE
 	# we need shmfs for the swappable backing store, and in particular
 	# the shmem_readpage() which depends upon tmpfs
-- 
2.5.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-01-26 18:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-26 18:49 [PATCH 1/3] agp/intel-gtt: Don't leak the scratch page Daniel Vetter
2016-01-26 18:49 ` Daniel Vetter [this message]
2016-01-26 20:56   ` [PATCH 2/3] drm/i915: Stop depending upon CONFIG_AGP/_INTEL Chris Wilson
2016-01-27 11:37   ` Ville Syrjälä
2016-01-26 18:49 ` [PATCH 3/3] agp/intel-gtt: Only register fake agp driver for gen1 Daniel Vetter
2016-01-26 20:58   ` Chris Wilson
2016-01-26 21:00 ` [PATCH 1/3] agp/intel-gtt: Don't leak the scratch page Chris Wilson
2016-01-27 17:52 ` ✗ Fi.CI.BAT: failure for series starting with [1/3] " Patchwork
2016-01-28 14:56 ` ✓ Fi.CI.BAT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453834196-5741-2-git-send-email-daniel.vetter@ffwll.ch \
    --to=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.