All of lore.kernel.org
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Kukjin Kim <kgene@kernel.org>,
	rtc-linux@googlegroups.com, Andi Shyti <andi.shyti@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Laxman Dewangan <ldewangan@nvidia.com>,
	linux-samsung-soc@vger.kernel.org,
	Javier Martinez Canillas <javier@osg.samsung.com>
Subject: [PATCH v4 03/10] rtc: max77686: Use usleep_range() instead of msleep()
Date: Wed, 27 Jan 2016 00:36:39 -0300	[thread overview]
Message-ID: <1453865806-4661-4-git-send-email-javier@osg.samsung.com> (raw)
In-Reply-To: <1453865806-4661-1-git-send-email-javier@osg.samsung.com>

Documentation/timers/timers-howto.txt suggest to use usleep_range()
instead of msleep() for small msec (1ms - 20ms) since msleep() will
often sleep for 20ms for any value in that range.

This is fine in this case since 16ms is the _minimum_ delay required
by max77686 for an RTC update but by using usleep_range() instead of
msleep(), the driver can support other RTC IP blocks with a shorter
minimum delay (i.e: in the range of usecs instead of msecs).

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Andi Shyti <andi.shyti@samsung.com>

---

Changes in v4:
- Add Andi Shyti's Reviewed-by to patch #3.

Changes in v3:
- Add Krzysztof Kozlowski's Tested-by tag to patch #3.
- Add Laxman Dewangan's Acked-by tag to patch #3.

Changes in v2:
- Add Krzysztof Kozlowski's Reviewed-by tag to patch #3.
- Fix typo error in changelog. Suggested by Krzysztof Kozlowski.

 drivers/rtc/rtc-max77686.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
index d84a50c9f7f7..025a17a95da3 100644
--- a/drivers/rtc/rtc-max77686.c
+++ b/drivers/rtc/rtc-max77686.c
@@ -41,7 +41,7 @@
 #define ALARM_ENABLE_SHIFT		7
 #define ALARM_ENABLE_MASK		(1 << ALARM_ENABLE_SHIFT)
 
-#define MAX77686_RTC_UPDATE_DELAY	16
+#define MAX77686_RTC_UPDATE_DELAY	16000
 
 enum {
 	RTC_SEC = 0,
@@ -130,7 +130,8 @@ static int max77686_rtc_update(struct max77686_rtc_info *info,
 				__func__, ret, data);
 	else {
 		/* Minimum 16ms delay required before RTC update. */
-		msleep(MAX77686_RTC_UPDATE_DELAY);
+		usleep_range(MAX77686_RTC_UPDATE_DELAY,
+			     MAX77686_RTC_UPDATE_DELAY * 2);
 	}
 
 	return ret;
-- 
2.5.0

WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Kukjin Kim <kgene@kernel.org>,
	rtc-linux@googlegroups.com, Andi Shyti <andi.shyti@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Laxman Dewangan <ldewangan@nvidia.com>,
	linux-samsung-soc@vger.kernel.org,
	Javier Martinez Canillas <javier@osg.samsung.com>
Subject: [rtc-linux] [PATCH v4 03/10] rtc: max77686: Use usleep_range() instead of msleep()
Date: Wed, 27 Jan 2016 00:36:39 -0300	[thread overview]
Message-ID: <1453865806-4661-4-git-send-email-javier@osg.samsung.com> (raw)
In-Reply-To: <1453865806-4661-1-git-send-email-javier@osg.samsung.com>

Documentation/timers/timers-howto.txt suggest to use usleep_range()
instead of msleep() for small msec (1ms - 20ms) since msleep() will
often sleep for 20ms for any value in that range.

This is fine in this case since 16ms is the _minimum_ delay required
by max77686 for an RTC update but by using usleep_range() instead of
msleep(), the driver can support other RTC IP blocks with a shorter
minimum delay (i.e: in the range of usecs instead of msecs).

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Andi Shyti <andi.shyti@samsung.com>

---

Changes in v4:
- Add Andi Shyti's Reviewed-by to patch #3.

Changes in v3:
- Add Krzysztof Kozlowski's Tested-by tag to patch #3.
- Add Laxman Dewangan's Acked-by tag to patch #3.

Changes in v2:
- Add Krzysztof Kozlowski's Reviewed-by tag to patch #3.
- Fix typo error in changelog. Suggested by Krzysztof Kozlowski.

 drivers/rtc/rtc-max77686.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
index d84a50c9f7f7..025a17a95da3 100644
--- a/drivers/rtc/rtc-max77686.c
+++ b/drivers/rtc/rtc-max77686.c
@@ -41,7 +41,7 @@
 #define ALARM_ENABLE_SHIFT		7
 #define ALARM_ENABLE_MASK		(1 << ALARM_ENABLE_SHIFT)
 
-#define MAX77686_RTC_UPDATE_DELAY	16
+#define MAX77686_RTC_UPDATE_DELAY	16000
 
 enum {
 	RTC_SEC = 0,
@@ -130,7 +130,8 @@ static int max77686_rtc_update(struct max77686_rtc_info *info,
 				__func__, ret, data);
 	else {
 		/* Minimum 16ms delay required before RTC update. */
-		msleep(MAX77686_RTC_UPDATE_DELAY);
+		usleep_range(MAX77686_RTC_UPDATE_DELAY,
+			     MAX77686_RTC_UPDATE_DELAY * 2);
 	}
 
 	return ret;
-- 
2.5.0

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

  parent reply	other threads:[~2016-01-27  3:37 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-27  3:36 [PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support Javier Martinez Canillas
2016-01-27  3:36 ` Javier Martinez Canillas
2016-01-27  3:36 ` [rtc-linux] " Javier Martinez Canillas
2016-01-27  3:36 ` [PATCH v4 01/10] rtc: max77686: Fix max77686_rtc_read_alarm() return value Javier Martinez Canillas
2016-01-27  3:36   ` [rtc-linux] " Javier Martinez Canillas
2016-01-27  3:36 ` [PATCH v4 02/10] rtc: max77686: Use ARRAY_SIZE() instead of current array length Javier Martinez Canillas
2016-01-27  3:36   ` [rtc-linux] " Javier Martinez Canillas
2016-01-27  5:57   ` Laxman Dewangan
2016-01-27  5:57     ` Laxman Dewangan
2016-01-27  5:57     ` [rtc-linux] " Laxman Dewangan
2016-01-27  3:36 ` Javier Martinez Canillas [this message]
2016-01-27  3:36   ` [rtc-linux] [PATCH v4 03/10] rtc: max77686: Use usleep_range() instead of msleep() Javier Martinez Canillas
2016-01-27  3:36 ` [PATCH v4 04/10] rtc: max77686: Use a driver data struct instead hard-coded values Javier Martinez Canillas
2016-01-27  3:36   ` [rtc-linux] " Javier Martinez Canillas
2016-01-27  3:36 ` [PATCH v4 05/10] rtc: max77686: Add an indirection level to access RTC registers Javier Martinez Canillas
2016-01-27  3:36   ` [rtc-linux] " Javier Martinez Canillas
2016-01-27  3:36 ` [PATCH v4 06/10] rtc: max77686: Add max77802 support Javier Martinez Canillas
2016-01-27  3:36   ` [rtc-linux] " Javier Martinez Canillas
2016-01-27  4:23   ` Krzysztof Kozlowski
2016-01-27  4:23     ` [rtc-linux] " Krzysztof Kozlowski
2016-01-27  4:37     ` Javier Martinez Canillas
2016-01-27  4:37       ` Javier Martinez Canillas
2016-01-27  4:37       ` [rtc-linux] " Javier Martinez Canillas
2016-01-27  3:36 ` [PATCH v4 07/10] rtc: max77686: Fix unsupported year message Javier Martinez Canillas
2016-01-27  3:36   ` [rtc-linux] " Javier Martinez Canillas
2016-01-27  4:24   ` Krzysztof Kozlowski
2016-01-27  4:24     ` [rtc-linux] " Krzysztof Kozlowski
2016-01-27  3:36 ` [PATCH v4 08/10] rtc: Remove Maxim 77802 driver Javier Martinez Canillas
2016-01-27  3:36   ` [rtc-linux] " Javier Martinez Canillas
2016-01-27  3:36 ` [PATCH v4 09/10] ARM: exynos_defconfig: Remove MAX77802 RTC Kconfig symbol Javier Martinez Canillas
2016-01-27  3:36   ` [rtc-linux] " Javier Martinez Canillas
2016-01-27  3:36 ` [PATCH v4 10/10] ARM: multi_v7_defconfig: " Javier Martinez Canillas
2016-01-27  3:36   ` Javier Martinez Canillas
2016-01-27  3:36   ` [rtc-linux] " Javier Martinez Canillas
2016-01-28  1:14 ` [PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support Andi Shyti
2016-01-28  1:14   ` Andi Shyti
2016-01-28  1:14   ` [rtc-linux] " Andi Shyti
2016-01-31 12:05 ` Alexandre Belloni
2016-01-31 12:05   ` Alexandre Belloni
2016-01-31 12:11   ` [rtc-linux] " Krzysztof Kozlowski
2016-01-31 12:11     ` Krzysztof Kozlowski
2016-01-31 12:11     ` Krzysztof Kozlowski
2016-02-04 22:56     ` Alexandre Belloni
2016-02-04 22:56       ` Alexandre Belloni
2016-02-04 22:56       ` Alexandre Belloni
2016-02-05  0:18       ` Krzysztof Kozlowski
2016-02-05  0:18         ` Krzysztof Kozlowski
2016-02-05  0:18         ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453865806-4661-4-git-send-email-javier@osg.samsung.com \
    --to=javier@osg.samsung.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=andi.shyti@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=ldewangan@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.