All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms+renesas@verge.net.au>
To: linux-renesas-soc@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
	Magnus Damm <magnus.damm@gmail.com>,
	Simon Horman <horms+renesas@verge.net.au>,
	Magnus Damm <damm@opensource.se>
Subject: [PATCH/RFC] ARM: shmobile: r8a7794: Add thermal device to DT
Date: Thu, 28 Jan 2016 13:32:55 +0900	[thread overview]
Message-ID: <1453955575-32008-1-git-send-email-horms+renesas@verge.net.au> (raw)

*** Currently does not work
*** Not for upstream merge
*** For informational purposes only

Instantiate the thermal sensor in the r8a7794 device tree.

Based on very similar work for the r8a7790 by Magnus Damm.

Cc: Magnus Damm <damm@opensource.se>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

---

Hi Morimoto-san,

as discussed briefly last week I am having some trouble enabling thermal
for the r8a7794/alt. With this patch applied on top of
renesas-devel-20160127-v4.5-rc1 I see:

# dmesg | grep thermal
[    1.089897] rcar_thermal e61f0000.thermal: thermal sensor was broken
[    1.101225] rcar_thermal: probe of e61f0000.thermal failed with error -22

I also see this with "[PATCH] thermal: core: don't call unsupported trip on
thermal_tripped_notify()" applied.

Is this a kernel issue that you are aware of?
Is there a possibility that there is a problem with my hardware?

Any insight would be greatly appreciated.

AFIK this is not urgent.

---
 arch/arm/boot/dts/r8a7794.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7794.dtsi b/arch/arm/boot/dts/r8a7794.dtsi
index 5d5d8cb41191..3b84bf3c1124 100644
--- a/arch/arm/boot/dts/r8a7794.dtsi
+++ b/arch/arm/boot/dts/r8a7794.dtsi
@@ -187,6 +187,14 @@
 		status = "disabled";
 	};
 
+	thermal@e61f0000 {
+		compatible = "renesas,thermal-r8a7794", "renesas,rcar-thermal";
+		reg = <0 0xe61f0000 0 0x14>, <0 0xe61f0100 0 0x38>;
+		interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&mstp5_clks R8A7794_CLK_THERMAL>;
+		power-domains = <&cpg_clocks>;
+	};
+
 	timer {
 		compatible = "arm,armv7-timer";
 		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
@@ -1045,6 +1053,14 @@
 			clock-indices = <R8A7794_CLK_IRQC>;
 			clock-output-names = "irqc";
 		};
+		mstp5_clks: mstp5_clks@e6150144 {
+			compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp-clocks";
+			reg = <0 0xe6150144 0 4>, <0 0xe615003c 0 4>;
+			clocks = <&extal_clk>;
+			#clock-cells = <1>;
+			clock-indices = <R8A7794_CLK_THERMAL>;
+			clock-output-names = "thermal";
+		};
 		mstp7_clks: mstp7_clks@e615014c {
 			compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp-clocks";
 			reg = <0 0xe615014c 0 4>, <0 0xe61501c4 0 4>;
-- 
2.1.4

WARNING: multiple messages have this Message-ID (diff)
From: horms+renesas@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH/RFC] ARM: shmobile: r8a7794: Add thermal device to DT
Date: Thu, 28 Jan 2016 13:32:55 +0900	[thread overview]
Message-ID: <1453955575-32008-1-git-send-email-horms+renesas@verge.net.au> (raw)

*** Currently does not work
*** Not for upstream merge
*** For informational purposes only

Instantiate the thermal sensor in the r8a7794 device tree.

Based on very similar work for the r8a7790 by Magnus Damm.

Cc: Magnus Damm <damm@opensource.se>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

---

Hi Morimoto-san,

as discussed briefly last week I am having some trouble enabling thermal
for the r8a7794/alt. With this patch applied on top of
renesas-devel-20160127-v4.5-rc1 I see:

# dmesg | grep thermal
[    1.089897] rcar_thermal e61f0000.thermal: thermal sensor was broken
[    1.101225] rcar_thermal: probe of e61f0000.thermal failed with error -22

I also see this with "[PATCH] thermal: core: don't call unsupported trip on
thermal_tripped_notify()" applied.

Is this a kernel issue that you are aware of?
Is there a possibility that there is a problem with my hardware?

Any insight would be greatly appreciated.

AFIK this is not urgent.

---
 arch/arm/boot/dts/r8a7794.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7794.dtsi b/arch/arm/boot/dts/r8a7794.dtsi
index 5d5d8cb41191..3b84bf3c1124 100644
--- a/arch/arm/boot/dts/r8a7794.dtsi
+++ b/arch/arm/boot/dts/r8a7794.dtsi
@@ -187,6 +187,14 @@
 		status = "disabled";
 	};
 
+	thermal at e61f0000 {
+		compatible = "renesas,thermal-r8a7794", "renesas,rcar-thermal";
+		reg = <0 0xe61f0000 0 0x14>, <0 0xe61f0100 0 0x38>;
+		interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&mstp5_clks R8A7794_CLK_THERMAL>;
+		power-domains = <&cpg_clocks>;
+	};
+
 	timer {
 		compatible = "arm,armv7-timer";
 		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
@@ -1045,6 +1053,14 @@
 			clock-indices = <R8A7794_CLK_IRQC>;
 			clock-output-names = "irqc";
 		};
+		mstp5_clks: mstp5_clks at e6150144 {
+			compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp-clocks";
+			reg = <0 0xe6150144 0 4>, <0 0xe615003c 0 4>;
+			clocks = <&extal_clk>;
+			#clock-cells = <1>;
+			clock-indices = <R8A7794_CLK_THERMAL>;
+			clock-output-names = "thermal";
+		};
 		mstp7_clks: mstp7_clks at e615014c {
 			compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp-clocks";
 			reg = <0 0xe615014c 0 4>, <0 0xe61501c4 0 4>;
-- 
2.1.4

             reply	other threads:[~2016-01-28  4:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-28  4:32 Simon Horman [this message]
2016-01-28  4:32 ` [PATCH/RFC] ARM: shmobile: r8a7794: Add thermal device to DT Simon Horman
2016-01-28  5:35 ` Kuninori Morimoto
2016-01-28  9:30   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453955575-32008-1-git-send-email-horms+renesas@verge.net.au \
    --to=horms+renesas@verge.net.au \
    --cc=damm@opensource.se \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.