From: Daniel Wagner <daniel.wagner@bmw-carit.de> To: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Cc: Maik Broemme <mbroemme@plusserver.de>, Daniel Wagner <daniel.wagner@bmw-carit.de> Subject: [PATCH] video: Use bool instead int pointer for get_opt_bool() argument Date: Fri, 29 Jan 2016 14:23:25 +0100 [thread overview] Message-ID: <1454073805-14443-1-git-send-email-daniel.wagner@bmw-carit.de> (raw) In-Reply-To: <1453992270-4688-1-git-send-email-daniel.wagner@bmw-carit.de> As the function name already indicates that get_opt_bool() parses for a bool. It is not a surprise that compiler is complaining about it when -Werror=incompatible-pointer-types is used: drivers/video/fbdev/intelfb/intelfbdrv.c: In function ‘intelfb_setup’: drivers/video/fbdev/intelfb/intelfbdrv.c:353:39: error: passing argument 3 of ‘get_opt_bool’ from incompatible pointer type [-Werror=incompatible-pointer-types] if (get_opt_bool(this_opt, "accel", &accel)) Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de> Reported-by: Fengguang Wu <fengguang.wu@intel.com> --- Hi, In the 'simple wait queue support' series is a patch which turns on -Werror=incompatible-pointer-types which will result in a compile error for intelfb. https://lkml.org/lkml/2016/1/28/462 Even if that patch wont make it, this one makes sense (at least for me :)) I'll prepend this patch to the next version of the series in order to see if I got rid of all incompatible pointer types errors caught by the kbuild test robot. cheers, daniel drivers/video/fbdev/intelfb/intelfbdrv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/intelfb/intelfbdrv.c b/drivers/video/fbdev/intelfb/intelfbdrv.c index bbec737..bf20744 100644 --- a/drivers/video/fbdev/intelfb/intelfbdrv.c +++ b/drivers/video/fbdev/intelfb/intelfbdrv.c @@ -302,7 +302,7 @@ static __inline__ int get_opt_int(const char *this_opt, const char *name, } static __inline__ int get_opt_bool(const char *this_opt, const char *name, - int *ret) + bool *ret) { if (!ret) return 0; -- 2.5.0
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Wagner <daniel.wagner@bmw-carit.de> To: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Cc: Maik Broemme <mbroemme@plusserver.de>, Daniel Wagner <daniel.wagner@bmw-carit.de> Subject: [PATCH] video: Use bool instead int pointer for get_opt_bool() argument Date: Fri, 29 Jan 2016 13:23:25 +0000 [thread overview] Message-ID: <1454073805-14443-1-git-send-email-daniel.wagner@bmw-carit.de> (raw) In-Reply-To: <1453992270-4688-1-git-send-email-daniel.wagner@bmw-carit.de> As the function name already indicates that get_opt_bool() parses for a bool. It is not a surprise that compiler is complaining about it when -Werror=incompatible-pointer-types is used: drivers/video/fbdev/intelfb/intelfbdrv.c: In function ‘intelfb_setup’: drivers/video/fbdev/intelfb/intelfbdrv.c:353:39: error: passing argument 3 of ‘get_opt_bool’ from incompatible pointer type [-Werror=incompatible-pointer-types] if (get_opt_bool(this_opt, "accel", &accel)) Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de> Reported-by: Fengguang Wu <fengguang.wu@intel.com> --- Hi, In the 'simple wait queue support' series is a patch which turns on -Werror=incompatible-pointer-types which will result in a compile error for intelfb. https://lkml.org/lkml/2016/1/28/462 Even if that patch wont make it, this one makes sense (at least for me :)) I'll prepend this patch to the next version of the series in order to see if I got rid of all incompatible pointer types errors caught by the kbuild test robot. cheers, daniel drivers/video/fbdev/intelfb/intelfbdrv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/intelfb/intelfbdrv.c b/drivers/video/fbdev/intelfb/intelfbdrv.c index bbec737..bf20744 100644 --- a/drivers/video/fbdev/intelfb/intelfbdrv.c +++ b/drivers/video/fbdev/intelfb/intelfbdrv.c @@ -302,7 +302,7 @@ static __inline__ int get_opt_int(const char *this_opt, const char *name, } static __inline__ int get_opt_bool(const char *this_opt, const char *name, - int *ret) + bool *ret) { if (!ret) return 0; -- 2.5.0
next prev parent reply other threads:[~2016-01-29 13:23 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-01-28 14:44 [PATCH tip v6 0/5] Simple wait queue support Daniel Wagner 2016-01-28 14:44 ` [PATCH tip v6 1/5] wait.[ch]: Introduce the simple waitqueue (swait) implementation Daniel Wagner 2016-01-28 14:44 ` [PATCH tip v6 2/5] kbuild: Add option to turn incompatible pointer check into error Daniel Wagner 2016-01-29 12:17 ` Daniel Wagner 2016-01-29 12:17 ` Daniel Wagner 2016-01-29 18:55 ` Paul Gortmaker 2016-01-29 18:55 ` Paul Gortmaker 2016-02-01 6:49 ` Daniel Wagner 2016-02-01 6:49 ` Daniel Wagner 2016-02-05 8:16 ` Daniel Wagner 2016-02-05 8:16 ` Daniel Wagner 2016-02-07 4:39 ` Paul Gortmaker 2016-02-07 4:39 ` Paul Gortmaker 2016-02-17 13:04 ` Daniel Wagner 2016-02-17 13:04 ` Daniel Wagner 2016-01-28 14:44 ` [PATCH tip v6 3/5] KVM: use simple waitqueue for vcpu->wq Daniel Wagner 2016-01-29 12:18 ` Daniel Wagner 2016-01-29 12:18 ` Daniel Wagner 2016-01-28 14:44 ` [PATCH tip v6 4/5] rcu: Do not call rcu_nocb_gp_cleanup() while holding rnp->lock Daniel Wagner 2016-01-28 14:44 ` [PATCH tip v6 5/5] rcu: use simple wait queues where possible in rcutree Daniel Wagner 2016-01-29 13:23 ` Daniel Wagner [this message] 2016-01-29 13:23 ` [PATCH] video: Use bool instead int pointer for get_opt_bool() argument Daniel Wagner 2016-01-29 13:28 ` [PATCH] MIPS: Differentiate between 32 and 64 bit ELF header Daniel Wagner 2016-02-01 0:52 ` Maciej W. Rozycki 2016-02-01 0:52 ` Maciej W. Rozycki 2016-02-01 16:07 ` Daniel Wagner 2016-02-01 16:07 ` Daniel Wagner 2016-02-06 17:16 ` Maciej W. Rozycki 2016-02-06 17:16 ` Maciej W. Rozycki 2016-02-08 15:44 ` [PATCH v3 0/3] " Daniel Wagner 2016-02-08 15:44 ` [PATCH v3 1/3] mips: Use arch specific auxvec.h instead of generic-asm version Daniel Wagner 2016-02-08 17:19 ` Maciej W. Rozycki 2016-02-08 17:19 ` Maciej W. Rozycki 2016-02-09 7:01 ` Daniel Wagner 2016-02-09 7:01 ` Daniel Wagner 2016-02-09 11:46 ` Maciej W. Rozycki 2016-02-09 11:46 ` Maciej W. Rozycki 2016-02-09 12:37 ` Daniel Wagner 2016-02-09 12:37 ` Daniel Wagner 2016-02-09 14:51 ` Maciej W. Rozycki 2016-02-09 14:51 ` Maciej W. Rozycki 2016-02-10 8:51 ` Daniel Wagner 2016-02-10 8:51 ` Daniel Wagner 2016-02-08 15:44 ` [PATCH v3 2/3] crash_dump: Add vmcore_elf32_check_arch Daniel Wagner 2016-02-08 17:05 ` Maciej W. Rozycki 2016-02-08 17:05 ` Maciej W. Rozycki 2016-02-08 15:44 ` [PATCH v3 3/3] mips: Differentiate between 32 and 64 bit ELF header Daniel Wagner 2016-02-08 16:22 ` kbuild test robot 2016-02-08 16:22 ` kbuild test robot 2016-02-09 8:03 ` Daniel Wagner 2016-02-09 8:03 ` Daniel Wagner 2016-02-09 12:32 ` Maciej W. Rozycki 2016-02-09 12:32 ` Maciej W. Rozycki 2016-02-09 12:38 ` Daniel Wagner 2016-02-09 12:38 ` Daniel Wagner 2016-02-09 19:44 ` Maciej W. Rozycki 2016-02-09 19:44 ` Maciej W. Rozycki 2016-02-10 6:28 ` Daniel Wagner 2016-02-10 6:28 ` Daniel Wagner 2016-02-10 9:21 ` [PATCH v4 0/2] " Daniel Wagner 2016-02-10 9:21 ` [PATCH v4 1/2] crash_dump: Add vmcore_elf32_check_arch Daniel Wagner 2016-02-10 9:21 ` [PATCH v4 2/2] mips: Differentiate between 32 and 64 bit ELF header Daniel Wagner 2016-02-11 10:49 ` Ralf Baechle 2016-02-11 12:04 ` Maciej W. Rozycki 2016-02-11 12:04 ` Maciej W. Rozycki 2016-02-11 12:14 ` Daniel Wagner 2016-02-11 12:14 ` Daniel Wagner 2016-02-11 14:58 ` Maciej W. Rozycki 2016-02-11 14:58 ` Maciej W. Rozycki 2016-02-11 15:30 ` Ralf Baechle 2016-02-08 16:58 ` [PATCH v3 3/3] " Maciej W. Rozycki 2016-02-08 16:58 ` Maciej W. Rozycki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1454073805-14443-1-git-send-email-daniel.wagner@bmw-carit.de \ --to=daniel.wagner@bmw-carit.de \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mbroemme@plusserver.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.