All of lore.kernel.org
 help / color / mirror / Atom feed
From: ayaka <ayaka@soulik.info>
To: linux-media@vger.kernel.org
Cc: kyungmin.park@samsung.com, k.debski@samsung.com,
	jtp.park@samsung.com, mchehab@osg.samsung.com,
	linux-arm-kernel@lists.infradead.org, ayaka <ayaka@soulik.info>
Subject: [PATCH 2/4] [media] s5p-mfc: remove unnecessary check in try_fmt
Date: Sun, 31 Jan 2016 02:53:35 +0800	[thread overview]
Message-ID: <1454180017-29071-3-git-send-email-ayaka@soulik.info> (raw)
In-Reply-To: <1454180017-29071-1-git-send-email-ayaka@soulik.info>

We don't need to request the sizeimage or num_planes
in try_fmt.

Signed-off-by: ayaka <ayaka@soulik.info>
---
 drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
index 7c9e5f5..64b92eb 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
@@ -1043,10 +1043,6 @@ static int vidioc_try_fmt(struct file *file, void *priv, struct v4l2_format *f)
 			mfc_err("failed to try output format\n");
 			return -EINVAL;
 		}
-		if (pix_fmt_mp->plane_fmt[0].sizeimage == 0) {
-			mfc_err("must be set encoding output size\n");
-			return -EINVAL;
-		}
 		if ((dev->variant->version_bit & fmt->versions) == 0) {
 			mfc_err("Unsupported format by this MFC version.\n");
 			return -EINVAL;
@@ -1060,11 +1056,6 @@ static int vidioc_try_fmt(struct file *file, void *priv, struct v4l2_format *f)
 			mfc_err("failed to try output format\n");
 			return -EINVAL;
 		}
-
-		if (fmt->num_planes != pix_fmt_mp->num_planes) {
-			mfc_err("failed to try output format\n");
-			return -EINVAL;
-		}
 		if ((dev->variant->version_bit & fmt->versions) == 0) {
 			mfc_err("Unsupported format by this MFC version.\n");
 			return -EINVAL;
-- 
2.5.0


WARNING: multiple messages have this Message-ID (diff)
From: ayaka@soulik.info (ayaka)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] [media] s5p-mfc: remove unnecessary check in try_fmt
Date: Sun, 31 Jan 2016 02:53:35 +0800	[thread overview]
Message-ID: <1454180017-29071-3-git-send-email-ayaka@soulik.info> (raw)
In-Reply-To: <1454180017-29071-1-git-send-email-ayaka@soulik.info>

We don't need to request the sizeimage or num_planes
in try_fmt.

Signed-off-by: ayaka <ayaka@soulik.info>
---
 drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
index 7c9e5f5..64b92eb 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
@@ -1043,10 +1043,6 @@ static int vidioc_try_fmt(struct file *file, void *priv, struct v4l2_format *f)
 			mfc_err("failed to try output format\n");
 			return -EINVAL;
 		}
-		if (pix_fmt_mp->plane_fmt[0].sizeimage == 0) {
-			mfc_err("must be set encoding output size\n");
-			return -EINVAL;
-		}
 		if ((dev->variant->version_bit & fmt->versions) == 0) {
 			mfc_err("Unsupported format by this MFC version.\n");
 			return -EINVAL;
@@ -1060,11 +1056,6 @@ static int vidioc_try_fmt(struct file *file, void *priv, struct v4l2_format *f)
 			mfc_err("failed to try output format\n");
 			return -EINVAL;
 		}
-
-		if (fmt->num_planes != pix_fmt_mp->num_planes) {
-			mfc_err("failed to try output format\n");
-			return -EINVAL;
-		}
 		if ((dev->variant->version_bit & fmt->versions) == 0) {
 			mfc_err("Unsupported format by this MFC version.\n");
 			return -EINVAL;
-- 
2.5.0

  parent reply	other threads:[~2016-01-30 19:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-30 18:53 [PATCH 0/4] [media] s5p-mfc: remove a few little bugs in driver ayaka
2016-01-30 18:53 ` ayaka
2016-01-30 18:53 ` [PATCH 1/4] [media] s5p-mfc: Add handling of buffer freeing reqbufs request ayaka
2016-01-30 18:53   ` ayaka
2016-01-30 19:27   ` kbuild test robot
2016-01-30 19:27     ` kbuild test robot
2016-01-30 18:53 ` ayaka [this message]
2016-01-30 18:53   ` [PATCH 2/4] [media] s5p-mfc: remove unnecessary check in try_fmt ayaka
2016-01-30 18:53 ` [PATCH 3/4] [media] s5p-mfc: don't close instance after free OUTPUT buffers ayaka
2016-01-30 18:53   ` ayaka
2016-02-04 14:23   ` Kamil Debski
2016-02-04 14:23     ` Kamil Debski
2016-02-13 18:03     ` ayaka
2016-01-30 18:53 ` [PATCH 4/4] [media] s5p-mfc: fix a typo in s5p_mfc_dec ayaka
2016-01-30 18:53   ` ayaka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454180017-29071-3-git-send-email-ayaka@soulik.info \
    --to=ayaka@soulik.info \
    --cc=jtp.park@samsung.com \
    --cc=k.debski@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.