All of lore.kernel.org
 help / color / mirror / Atom feed
From: Caesar Wang <wxt@rock-chips.com>
To: mturquette@baylibre.com, sboyd@codeaurora.org
Cc: linux-clk@vger.kernel.org, heiko@sntech.de,
	devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org,
	keescook@google.com, linux-kernel@vger.kernel.org,
	jeffy.chen@rock-chips.com, leozwang@google.com,
	zhengxing <zhengxing@rock-chips.com>,
	Caesar Wang <wxt@rock-chips.com>
Subject: [PATCH v5 2/8] clk: rockchip: rk3036: fix and add node id for emac clock
Date: Tue,  2 Feb 2016 11:48:19 +0800	[thread overview]
Message-ID: <1454384899-7270-1-git-send-email-wxt@rock-chips.com> (raw)
In-Reply-To: <1454384032-6794-1-git-send-email-wxt@rock-chips.com>

From: zhengxing <zhengxing@rock-chips.com>

In the emac driver, we need to refer HCLK_MAC since there are
only 3PLLs (APLL/GPLL/DPLL) on the rk3036, most clock are under the
GPLL, and it is unable to provide the accurate rate for mac_ref which
need to 50MHz probability, we should let it under the DPLL and are
able to set the freq which integer multiples of 50MHz, so we add these
emac node for reference.

Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
Signed-off-by: Caesar Wang <wxt@rock-chips.com>

---

Changes in v5: None
Changes in v4:
- fix the commit, pick up from the
  https://patchwork.kernel.org/patch/7976631/.
- The emac parent shouldn't depend on the APLL. instead of DPLL.

 drivers/clk/rockchip/clk-rk3036.c      | 9 ++++++---
 include/dt-bindings/clock/rk3036-cru.h | 2 ++
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/rockchip/clk-rk3036.c b/drivers/clk/rockchip/clk-rk3036.c
index be71a41..701f702 100644
--- a/drivers/clk/rockchip/clk-rk3036.c
+++ b/drivers/clk/rockchip/clk-rk3036.c
@@ -343,8 +343,11 @@ static struct rockchip_clk_branch rk3036_clk_branches[] __initdata = {
 			RK2928_CLKSEL_CON(16), 0, 2, MFLAGS, 2, 5, DFLAGS,
 			RK2928_CLKGATE_CON(10), 5, GFLAGS),
 
-	COMPOSITE_NOGATE(0, "mac_pll_src", mux_pll_src_3plls_p, 0,
-			RK2928_CLKSEL_CON(21), 0, 2, MFLAGS, 9, 5, DFLAGS),
+	MUX(SCLK_MACPLL, "mac_pll_pre", mux_pll_src_3plls_p, 0,
+			RK2928_CLKSEL_CON(21), 0, 2, MFLAGS),
+	DIV(0, "mac_pll_src", "mac_pll_pre", 0,
+			RK2928_CLKSEL_CON(21), 9, 5, DFLAGS),
+
 	MUX(SCLK_MACREF, "mac_clk_ref", mux_mac_p, CLK_SET_RATE_PARENT,
 			RK2928_CLKSEL_CON(21), 3, 1, MFLAGS),
 
@@ -404,7 +407,7 @@ static struct rockchip_clk_branch rk3036_clk_branches[] __initdata = {
 	GATE(HCLK_OTG1, "hclk_otg1", "hclk_peri", CLK_IGNORE_UNUSED, RK2928_CLKGATE_CON(7), 3, GFLAGS),
 	GATE(HCLK_I2S, "hclk_i2s", "hclk_peri", 0, RK2928_CLKGATE_CON(7), 2, GFLAGS),
 	GATE(0, "hclk_sfc", "hclk_peri", CLK_IGNORE_UNUSED, RK2928_CLKGATE_CON(3), 14, GFLAGS),
-	GATE(0, "hclk_mac", "hclk_peri", CLK_IGNORE_UNUSED, RK2928_CLKGATE_CON(3), 15, GFLAGS),
+	GATE(HCLK_MAC, "hclk_mac", "hclk_peri", 0, RK2928_CLKGATE_CON(3), 5, GFLAGS),
 
 	/* pclk_peri gates */
 	GATE(0, "pclk_peri_matrix", "pclk_peri", CLK_IGNORE_UNUSED, RK2928_CLKGATE_CON(4), 1, GFLAGS),
diff --git a/include/dt-bindings/clock/rk3036-cru.h b/include/dt-bindings/clock/rk3036-cru.h
index ebc7a7b..de44109 100644
--- a/include/dt-bindings/clock/rk3036-cru.h
+++ b/include/dt-bindings/clock/rk3036-cru.h
@@ -54,6 +54,7 @@
 #define SCLK_PVTM_VIDEO		125
 #define SCLK_MAC		151
 #define SCLK_MACREF		152
+#define SCLK_MACPLL		153
 #define SCLK_SFC		160
 
 /* aclk gates */
@@ -92,6 +93,7 @@
 #define HCLK_SDMMC		456
 #define HCLK_SDIO		457
 #define HCLK_EMMC		459
+#define HCLK_MAC		460
 #define HCLK_I2S		462
 #define HCLK_LCDC		465
 #define HCLK_ROM		467
-- 
1.9.1

  parent reply	other threads:[~2016-02-02  3:49 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-02  3:33 [PATCH v5 0/8] Add the family patches to support for kylin board Caesar Wang
2016-02-02  3:33 ` Caesar Wang
2016-02-02  3:33 ` Caesar Wang
2016-02-02  3:40 ` [PATCH v5 1/8] ARM: dts: rockchip: add hdmi/vop device node for rk3036 Caesar Wang
2016-02-02  3:40   ` Caesar Wang
2016-02-02  3:40   ` Caesar Wang
2016-02-02  3:40   ` [PATCH v5 3/8] ARM: dts: rockchip: add support emac for RK3036 Caesar Wang
2016-02-02  3:40     ` Caesar Wang
2016-02-02  3:40   ` [PATCH v5 4/8] ARM: dts: rockchip: add mclk for rt5616 on kylin board Caesar Wang
2016-02-02  3:40     ` Caesar Wang
2016-02-02 21:23     ` Heiko Stübner
2016-02-02 21:23       ` Heiko Stübner
2016-02-02  3:40   ` [PATCH v5 8/8] ARM: dts: rockchip: support the spi for rk3036 Caesar Wang
2016-02-02  3:40     ` Caesar Wang
2016-02-02 21:29     ` Heiko Stübner
2016-02-02 21:29       ` Heiko Stübner
2016-02-02 21:29       ` Heiko Stübner
2016-02-21  0:03   ` [PATCH v5 1/8] ARM: dts: rockchip: add hdmi/vop device node " Heiko Stuebner
2016-02-21  0:03     ` Heiko Stuebner
2016-02-21  0:03     ` Heiko Stuebner
2016-02-21  2:18     ` Caesar Wang
2016-02-21  2:18       ` Caesar Wang
2016-02-21  2:18       ` Caesar Wang
2016-02-02  3:44 ` [PATCH v5 5/8] ASoC: rt5616: add mclk property for rt5616 document Caesar Wang
2016-02-02  3:44   ` [PATCH v5 6/8] ASoC: rt5616: trivial: fix the typo Caesar Wang
2016-02-02  3:44   ` [PATCH v5 7/8] ASoC: rt5616: add the mclk for the codec driver Caesar Wang
2016-02-02 19:36   ` [PATCH v5 5/8] ASoC: rt5616: add mclk property for rt5616 document Mark Brown
2016-02-02 19:36     ` Mark Brown
2016-02-03  0:52     ` Caesar Wang
2016-02-02  3:48 ` Caesar Wang [this message]
2016-02-21  2:26   ` [PATCH v5 2/8] clk: rockchip: rk3036: fix and add node id for emac clock Heiko Stuebner
2016-02-21  2:26     ` Heiko Stuebner
2016-02-21  2:45     ` Caesar Wang
2016-02-21  2:45       ` Caesar Wang
2016-02-23  0:02       ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454384899-7270-1-git-send-email-wxt@rock-chips.com \
    --to=wxt@rock-chips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=jeffy.chen@rock-chips.com \
    --cc=keescook@google.com \
    --cc=leozwang@google.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@codeaurora.org \
    --cc=zhengxing@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.