All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, David Airlie <airlied@linux.ie>,
	Eric Anholt <eric@anholt.net>
Subject: [PATCH 1/5] drm/vc4: Validate that WAIT_BO padding is cleared.
Date: Thu,  4 Feb 2016 11:23:07 -0800	[thread overview]
Message-ID: <1454613791-29049-2-git-send-email-eric@anholt.net> (raw)
In-Reply-To: <1454613791-29049-1-git-send-email-eric@anholt.net>

This is ABI future-proofing if we ever want to extend the pad to mean
something.

Signed-off-by: Eric Anholt <eric@anholt.net>
---
 drivers/gpu/drm/vc4/vc4_gem.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/vc4/vc4_gem.c b/drivers/gpu/drm/vc4/vc4_gem.c
index 48ce30a..cc89ffc 100644
--- a/drivers/gpu/drm/vc4/vc4_gem.c
+++ b/drivers/gpu/drm/vc4/vc4_gem.c
@@ -746,6 +746,9 @@ vc4_wait_bo_ioctl(struct drm_device *dev, void *data,
 	struct drm_gem_object *gem_obj;
 	struct vc4_bo *bo;
 
+	if (args->pad != 0)
+		return -EINVAL;
+
 	gem_obj = drm_gem_object_lookup(dev, file_priv, args->handle);
 	if (!gem_obj) {
 		DRM_ERROR("Failed to look up GEM BO %d\n", args->handle);
-- 
2.7.0

WARNING: multiple messages have this Message-ID (diff)
From: Eric Anholt <eric@anholt.net>
To: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 1/5] drm/vc4: Validate that WAIT_BO padding is cleared.
Date: Thu,  4 Feb 2016 11:23:07 -0800	[thread overview]
Message-ID: <1454613791-29049-2-git-send-email-eric@anholt.net> (raw)
In-Reply-To: <1454613791-29049-1-git-send-email-eric@anholt.net>

This is ABI future-proofing if we ever want to extend the pad to mean
something.

Signed-off-by: Eric Anholt <eric@anholt.net>
---
 drivers/gpu/drm/vc4/vc4_gem.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/vc4/vc4_gem.c b/drivers/gpu/drm/vc4/vc4_gem.c
index 48ce30a..cc89ffc 100644
--- a/drivers/gpu/drm/vc4/vc4_gem.c
+++ b/drivers/gpu/drm/vc4/vc4_gem.c
@@ -746,6 +746,9 @@ vc4_wait_bo_ioctl(struct drm_device *dev, void *data,
 	struct drm_gem_object *gem_obj;
 	struct vc4_bo *bo;
 
+	if (args->pad != 0)
+		return -EINVAL;
+
 	gem_obj = drm_gem_object_lookup(dev, file_priv, args->handle);
 	if (!gem_obj) {
 		DRM_ERROR("Failed to look up GEM BO %d\n", args->handle);
-- 
2.7.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-02-04 19:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-04 19:23 [PATCH 0/5] vc4 fixes for 4.5 Eric Anholt
2016-02-04 19:23 ` Eric Anholt
2016-02-04 19:23 ` Eric Anholt [this message]
2016-02-04 19:23   ` [PATCH 1/5] drm/vc4: Validate that WAIT_BO padding is cleared Eric Anholt
2016-02-04 19:23 ` [PATCH 2/5] drm/vc4: Fix the clear color for the first tile rendered Eric Anholt
2016-02-04 19:23   ` Eric Anholt
2016-02-04 19:23 ` [PATCH 3/5] drm/vc4: Return an ERR_PTR from BO creation instead of NULL Eric Anholt
2016-02-04 19:23   ` Eric Anholt
2016-02-04 19:23 ` [PATCH 4/5] drm/vc4: Fix -ERESTARTSYS error return from BO waits Eric Anholt
2016-02-04 19:23   ` Eric Anholt
2016-02-04 19:23 ` [PATCH 5/5] drm/vc4: Drop error message on seqno wait timeouts Eric Anholt
2016-02-04 19:23   ` Eric Anholt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454613791-29049-2-git-send-email-eric@anholt.net \
    --to=eric@anholt.net \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.