[PATCH] vfs: fix missing unlock on error in simple_xattr_list()

From: weiyj_lk@163.com
To: Alexander Viro <viro@zeniv.linux.org.uk>,
	Andreas Gruenbacher <agruenba@redhat.com>
Cc: Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
	linux-fsdevel@vger.kernel.org
Subject: [PATCH] vfs: fix missing unlock on error in simple_xattr_list()
Date: Fri,  5 Feb 2016 21:50:02 +0800	[thread overview]
Message-ID: <1454680202-17959-1-git-send-email-weiyj_lk@163.com> (raw)

From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Add the missing unlock before return from function simple_xattr_list()
in the error handling case.

Fixes: 786534b92f3c (tmpfs: listxattr should include POSIX ACL xattrs)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 fs/xattr.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/xattr.c b/fs/xattr.c
index 07d0e47..d4f8487 100644
--- a/fs/xattr.c
+++ b/fs/xattr.c
@@ -964,8 +964,10 @@ ssize_t simple_xattr_list(struct inode *inode, struct simple_xattrs *xattrs,
 			continue;
 
 		err = xattr_list_one(&buffer, &remaining_size, xattr->name);
-		if (err)
+		if (err) {
+			spin_unlock(&xattrs->lock);
 			return err;
+		}
 	}
 	spin_unlock(&xattrs->lock);
 

