From: Stephane Gasparini <stephane.gasparini@intel.com>
To: linux-block@vger.kernel.org, linux-pm@vger.kernel.org,
lenb@kernel.org, srinivas.pandruvada@linux.intel.com
Cc: Stephane Gasparini <stephane.gasparini@linux.intel.com>,
len.brown@linux.intel.com, philippe.longepe@linux.intel.com
Subject: [PATCH 1/1] kernel/fs: fix I/O wait not accounted for RW O_DSYNC
Date: Tue, 9 Feb 2016 17:07:38 +0100 [thread overview]
Message-ID: <1455034058-84181-2-git-send-email-stephane.gasparini@intel.com> (raw)
In-Reply-To: <1455034058-84181-1-git-send-email-stephane.gasparini@intel.com>
From: Stephane Gasparini <stephane.gasparini@linux.intel.com>
When a process is doing Random Write with O_DSYNC flag
the I/O wait are not accounted in the kernel (get_cpu_iowait_time_us).
This is preventing the governor or the cpufreq driver to account for
I/O wait and thus use the right pstate
Signed-off-by: Stephane Gasparini <stephane.gasparini@linux.intel.com>
Signed-off-by: Philippe Longepe <philippe.longepe@linux.intel.com>
---
block/bio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/bio.c b/block/bio.c
index dbabd48b1934..f53a691b6533 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -874,7 +874,7 @@ int submit_bio_wait(int rw, struct bio *bio)
bio->bi_private = &ret;
bio->bi_end_io = submit_bio_wait_endio;
submit_bio(rw, bio);
- wait_for_completion(&ret.event);
+ wait_for_completion_io(&ret.event);
return ret.error;
}
--
Stephane Gasparini<stephane.gasparini@linux.intel.com>
---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris,
92196 Meudon Cedex, France
Registration Number: 302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
next prev parent reply other threads:[~2016-02-09 16:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 16:07 [PATCH 0/1] account I/O Wait during synchronous write Stephane Gasparini
2016-02-09 16:07 ` Stephane Gasparini [this message]
2016-02-09 16:27 ` [PATCH 1/1] kernel/fs: fix I/O wait not accounted for RW O_DSYNC Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455034058-84181-2-git-send-email-stephane.gasparini@intel.com \
--to=stephane.gasparini@intel.com \
--cc=len.brown@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=philippe.longepe@linux.intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=stephane.gasparini@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.