All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, David Airlie <airlied@linux.ie>,
	Eric Anholt <eric@anholt.net>
Subject: [PATCH 1/6] drm/vc4: Fix a framebuffer reference leak on async flip interrupt.
Date: Tue, 16 Feb 2016 13:20:14 -0800	[thread overview]
Message-ID: <1455657619-12030-2-git-send-email-eric@anholt.net> (raw)
In-Reply-To: <1455657619-12030-1-git-send-email-eric@anholt.net>

We'd need X to queue up an async pageflip while another is
outstanding, and then take a SIGIO.  I think X actually avoids sending
out the next pageflip while one's already queued, but I'm not sure.

Signed-off-by: Eric Anholt <eric@anholt.net>
---
 drivers/gpu/drm/vc4/vc4_crtc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c
index 68227cc..bb74cb9 100644
--- a/drivers/gpu/drm/vc4/vc4_crtc.c
+++ b/drivers/gpu/drm/vc4/vc4_crtc.c
@@ -527,6 +527,7 @@ static int vc4_async_page_flip(struct drm_crtc *crtc,
 	/* Make sure all other async modesetes have landed. */
 	ret = down_interruptible(&vc4->async_modeset);
 	if (ret) {
+		drm_framebuffer_unreference(fb);
 		kfree(flip_state);
 		return ret;
 	}
-- 
2.7.0

WARNING: multiple messages have this Message-ID (diff)
From: Eric Anholt <eric@anholt.net>
To: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 1/6] drm/vc4: Fix a framebuffer reference leak on async flip interrupt.
Date: Tue, 16 Feb 2016 13:20:14 -0800	[thread overview]
Message-ID: <1455657619-12030-2-git-send-email-eric@anholt.net> (raw)
In-Reply-To: <1455657619-12030-1-git-send-email-eric@anholt.net>

We'd need X to queue up an async pageflip while another is
outstanding, and then take a SIGIO.  I think X actually avoids sending
out the next pageflip while one's already queued, but I'm not sure.

Signed-off-by: Eric Anholt <eric@anholt.net>
---
 drivers/gpu/drm/vc4/vc4_crtc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c
index 68227cc..bb74cb9 100644
--- a/drivers/gpu/drm/vc4/vc4_crtc.c
+++ b/drivers/gpu/drm/vc4/vc4_crtc.c
@@ -527,6 +527,7 @@ static int vc4_async_page_flip(struct drm_crtc *crtc,
 	/* Make sure all other async modesetes have landed. */
 	ret = down_interruptible(&vc4->async_modeset);
 	if (ret) {
+		drm_framebuffer_unreference(fb);
 		kfree(flip_state);
 		return ret;
 	}
-- 
2.7.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-02-16 21:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-16 21:20 drm/vc4: Modesetting fixes Eric Anholt
2016-02-16 21:20 ` Eric Anholt
2016-02-16 21:20 ` Eric Anholt [this message]
2016-02-16 21:20   ` [PATCH 1/6] drm/vc4: Fix a framebuffer reference leak on async flip interrupt Eric Anholt
2016-02-16 21:20 ` [PATCH 2/6] drm/vc4: Bring HDMI up from power off if necessary Eric Anholt
2016-02-16 21:20   ` Eric Anholt
2016-02-16 21:20 ` [PATCH 3/6] drm/vc4: Add another reg to HDMI debug dumping Eric Anholt
2016-02-16 21:20   ` Eric Anholt
2016-02-16 21:20 ` [PATCH 4/6] drm/vc4: Fix the name of the VSYNCD_EVEN register Eric Anholt
2016-02-16 21:20   ` Eric Anholt
2016-02-16 21:20 ` [PATCH 5/6] drm/vc4: Fix setting of vertical timings in the CRTC Eric Anholt
2016-02-16 21:20   ` Eric Anholt
2016-02-16 21:20 ` [PATCH 6/6] drm/vc4: Initialize scaler DISPBKGND on modeset Eric Anholt
2016-02-16 21:20   ` Eric Anholt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455657619-12030-2-git-send-email-eric@anholt.net \
    --to=eric@anholt.net \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.