All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <JBeulich@suse.com>
Subject: [PATCH] xen/x86: Annotate deliberate fallthrough cases from XSA-154
Date: Thu, 18 Feb 2016 12:26:43 +0000	[thread overview]
Message-ID: <1455798403-21953-1-git-send-email-andrew.cooper3@citrix.com> (raw)

Coverity objects otherwise.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
---
 xen/arch/x86/mm.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
index a05edc3..0bff7dd 100644
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -924,10 +924,15 @@ get_page_from_l1e(
             {
             case 0:
                 break;
+
             case 1:
                 if ( is_hardware_domain(l1e_owner) )
+                {
+                    /* Fallthrough. */
             case -1:
                     return 0;
+                }
+                /* Fallthrough. */
             default:
                 ASSERT_UNREACHABLE();
             }
-- 
2.1.4

             reply	other threads:[~2016-02-18 12:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-18 12:26 Andrew Cooper [this message]
2016-02-18 13:38 ` [PATCH] xen/x86: Annotate deliberate fallthrough cases from XSA-154 Jan Beulich
2016-02-18 14:05   ` Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455798403-21953-1-git-send-email-andrew.cooper3@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.