From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: alex@csgraf.de
Subject: [Qemu-devel] [PATCH] hpet: remove unnecessary code from post_load callback
Date: Mon, 22 Feb 2016 11:34:37 +0100 [thread overview]
Message-ID: <1456137277-12666-1-git-send-email-pbonzini@redhat.com> (raw)
The flags are already specified on the command line, so it is not
necessary to get them back from the migration stream. They should
be already equal on the source and destination machine, unless the
destination machine is configured incorrectly.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/timer/hpet.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c
index 0ad5420..4aa7293 100644
--- a/hw/timer/hpet.c
+++ b/hw/timer/hpet.c
@@ -266,11 +266,6 @@ static int hpet_post_load(void *opaque, int version_id)
s->capability |= (s->num_timers - 1) << HPET_ID_NUM_TIM_SHIFT;
hpet_cfg.hpet[s->hpet_id].event_timer_block_id = (uint32_t)s->capability;
- /* Derive HPET_MSI_SUPPORT from the capability of the first timer. */
- s->flags &= ~(1 << HPET_MSI_SUPPORT);
- if (s->timer[0].config & HPET_TN_FSB_CAP) {
- s->flags |= 1 << HPET_MSI_SUPPORT;
- }
return 0;
}
--
2.5.0
reply other threads:[~2016-02-22 10:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456137277-12666-1-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex@csgraf.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.