All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: arm@kernel.org
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
	Russell King <linux@arm.linux.org.uk>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] ARM: uniphier: add missing of_node_put()
Date: Fri, 26 Feb 2016 16:16:07 +0900	[thread overview]
Message-ID: <1456470968-7900-2-git-send-email-yamada.masahiro@socionext.com> (raw)
In-Reply-To: <1456470968-7900-1-git-send-email-yamada.masahiro@socionext.com>

This node pointer is allocated by of_find_compatible_node() in this
function.  It should be put before exitting this function.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 arch/arm/mach-uniphier/platsmp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-uniphier/platsmp.c b/arch/arm/mach-uniphier/platsmp.c
index e1cfc1d..8d988f5 100644
--- a/arch/arm/mach-uniphier/platsmp.c
+++ b/arch/arm/mach-uniphier/platsmp.c
@@ -100,6 +100,7 @@ static int __init uniphier_smp_prepare_trampoline(unsigned int max_cpus)
 
 	np = of_find_compatible_node(NULL, NULL,
 				"socionext,uniphier-system-bus-controller");
+	of_node_put(np);
 	ret = of_address_to_resource(np, 1, &res);
 	if (ret) {
 		pr_err("failed to get resource of system-bus-controller\n");
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: yamada.masahiro@socionext.com (Masahiro Yamada)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: uniphier: add missing of_node_put()
Date: Fri, 26 Feb 2016 16:16:07 +0900	[thread overview]
Message-ID: <1456470968-7900-2-git-send-email-yamada.masahiro@socionext.com> (raw)
In-Reply-To: <1456470968-7900-1-git-send-email-yamada.masahiro@socionext.com>

This node pointer is allocated by of_find_compatible_node() in this
function.  It should be put before exitting this function.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 arch/arm/mach-uniphier/platsmp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-uniphier/platsmp.c b/arch/arm/mach-uniphier/platsmp.c
index e1cfc1d..8d988f5 100644
--- a/arch/arm/mach-uniphier/platsmp.c
+++ b/arch/arm/mach-uniphier/platsmp.c
@@ -100,6 +100,7 @@ static int __init uniphier_smp_prepare_trampoline(unsigned int max_cpus)
 
 	np = of_find_compatible_node(NULL, NULL,
 				"socionext,uniphier-system-bus-controller");
+	of_node_put(np);
 	ret = of_address_to_resource(np, 1, &res);
 	if (ret) {
 		pr_err("failed to get resource of system-bus-controller\n");
-- 
1.9.1

  reply	other threads:[~2016-02-26  7:16 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-26  7:16 [PATCH 0/2] ARM: uniphier: UniPhier updates for Linux 4.6-rc1 (2nd round) Masahiro Yamada
2016-02-26  7:16 ` Masahiro Yamada
2016-02-26  7:16 ` Masahiro Yamada [this message]
2016-02-26  7:16   ` [PATCH 1/2] ARM: uniphier: add missing of_node_put() Masahiro Yamada
2016-02-26  7:16 ` [PATCH 2/2] ARM: uniphier: rework SMP code to support new System Bus binding Masahiro Yamada
2016-02-26  7:16   ` Masahiro Yamada
2016-03-07  9:30 ` [PATCH 0/2] ARM: uniphier: UniPhier updates for Linux 4.6-rc1 (2nd round) Masahiro Yamada
2016-03-07  9:30   ` Masahiro Yamada
2016-03-12 23:42   ` Masahiro Yamada
2016-03-12 23:42     ` Masahiro Yamada
2016-03-15  2:01     ` Masahiro Yamada
2016-03-15  2:01       ` Masahiro Yamada
2016-03-18 16:49       ` Arnd Bergmann
2016-03-18 16:49         ` Arnd Bergmann
2016-03-18 23:49         ` Masahiro Yamada
2016-03-18 23:49           ` Masahiro Yamada
2016-03-21  3:59           ` Masahiro Yamada
2016-03-21  3:59             ` Masahiro Yamada
2016-03-21  9:49             ` Arnd Bergmann
2016-03-21  9:49               ` Arnd Bergmann
2016-03-21 12:39               ` Masahiro Yamada
2016-03-21 12:39                 ` Masahiro Yamada
2016-03-21 19:33                 ` Arnd Bergmann
2016-03-21 19:33                   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456470968-7900-2-git-send-email-yamada.masahiro@socionext.com \
    --to=yamada.masahiro@socionext.com \
    --cc=arm@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.