All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Gruenbacher <agruenba@redhat.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
	linux-nfs@vger.kernel.org, "Theodore Ts'o" <tytso@mit.edu>,
	linux-cifs@vger.kernel.org, linux-api@vger.kernel.org,
	Trond Myklebust <trond.myklebust@primarydata.com>,
	linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
	Christoph Hellwig <hch@infradead.org>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	linux-fsdevel@vger.kernel.org,
	Jeff Layton <jlayton@poochiereds.net>,
	linux-ext4@vger.kernel.org,
	Anna Schumaker <anna.schumaker@netapp.com>
Subject: [PATCH v18 10/22] posix_acl: Unexport acl_by_type and make it static
Date: Mon, 29 Feb 2016 09:17:15 +0100	[thread overview]
Message-ID: <1456733847-17982-11-git-send-email-agruenba@redhat.com> (raw)
In-Reply-To: <1456733847-17982-1-git-send-email-agruenba@redhat.com>

acl_by_type(inode, type) returns a pointer to either inode->i_acl or
inode->i_default_acl depending on type.  This is useful in
fs/posix_acl.c, but should never have been visible outside that file.

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
---
 fs/posix_acl.c            | 3 +--
 include/linux/posix_acl.h | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/posix_acl.c b/fs/posix_acl.c
index 711dd51..55f2445 100644
--- a/fs/posix_acl.c
+++ b/fs/posix_acl.c
@@ -21,7 +21,7 @@
 #include <linux/export.h>
 #include <linux/user_namespace.h>
 
-struct posix_acl **acl_by_type(struct inode *inode, int type)
+static struct posix_acl **acl_by_type(struct inode *inode, int type)
 {
 	switch (type) {
 	case ACL_TYPE_ACCESS:
@@ -32,7 +32,6 @@ struct posix_acl **acl_by_type(struct inode *inode, int type)
 		BUG();
 	}
 }
-EXPORT_SYMBOL(acl_by_type);
 
 struct posix_acl *get_cached_acl(struct inode *inode, int type)
 {
diff --git a/include/linux/posix_acl.h b/include/linux/posix_acl.h
index 3e96a6a..5b5a80c 100644
--- a/include/linux/posix_acl.h
+++ b/include/linux/posix_acl.h
@@ -99,7 +99,6 @@ extern int posix_acl_create(struct inode *, umode_t *, struct posix_acl **,
 extern int simple_set_acl(struct inode *, struct posix_acl *, int);
 extern int simple_acl_create(struct inode *, struct inode *);
 
-struct posix_acl **acl_by_type(struct inode *inode, int type);
 struct posix_acl *get_cached_acl(struct inode *inode, int type);
 struct posix_acl *get_cached_acl_rcu(struct inode *inode, int type);
 void set_cached_acl(struct inode *inode, int type, struct posix_acl *acl);
-- 
2.4.3

WARNING: multiple messages have this Message-ID (diff)
From: Andreas Gruenbacher <agruenba@redhat.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org,
	Theodore Ts'o <tytso@mit.edu>,
	Christoph Hellwig <hch@infradead.org>,
	linux-api@vger.kernel.org,
	Trond Myklebust <trond.myklebust@primarydata.com>,
	linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
	"J. Bruce Fields" <bfields@fieldses.org>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	linux-fsdevel@vger.kernel.org,
	Jeff Layton <jlayton@poochiereds.net>,
	linux-ext4@vger.kernel.org,
	Anna Schumaker <anna.schumaker@netapp.com>
Subject: [PATCH v18 10/22] posix_acl: Unexport acl_by_type and make it static
Date: Mon, 29 Feb 2016 09:17:15 +0100	[thread overview]
Message-ID: <1456733847-17982-11-git-send-email-agruenba@redhat.com> (raw)
In-Reply-To: <1456733847-17982-1-git-send-email-agruenba@redhat.com>

acl_by_type(inode, type) returns a pointer to either inode->i_acl or
inode->i_default_acl depending on type.  This is useful in
fs/posix_acl.c, but should never have been visible outside that file.

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
---
 fs/posix_acl.c            | 3 +--
 include/linux/posix_acl.h | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/posix_acl.c b/fs/posix_acl.c
index 711dd51..55f2445 100644
--- a/fs/posix_acl.c
+++ b/fs/posix_acl.c
@@ -21,7 +21,7 @@
 #include <linux/export.h>
 #include <linux/user_namespace.h>
 
-struct posix_acl **acl_by_type(struct inode *inode, int type)
+static struct posix_acl **acl_by_type(struct inode *inode, int type)
 {
 	switch (type) {
 	case ACL_TYPE_ACCESS:
@@ -32,7 +32,6 @@ struct posix_acl **acl_by_type(struct inode *inode, int type)
 		BUG();
 	}
 }
-EXPORT_SYMBOL(acl_by_type);
 
 struct posix_acl *get_cached_acl(struct inode *inode, int type)
 {
diff --git a/include/linux/posix_acl.h b/include/linux/posix_acl.h
index 3e96a6a..5b5a80c 100644
--- a/include/linux/posix_acl.h
+++ b/include/linux/posix_acl.h
@@ -99,7 +99,6 @@ extern int posix_acl_create(struct inode *, umode_t *, struct posix_acl **,
 extern int simple_set_acl(struct inode *, struct posix_acl *, int);
 extern int simple_acl_create(struct inode *, struct inode *);
 
-struct posix_acl **acl_by_type(struct inode *inode, int type);
 struct posix_acl *get_cached_acl(struct inode *inode, int type);
 struct posix_acl *get_cached_acl_rcu(struct inode *inode, int type);
 void set_cached_acl(struct inode *inode, int type, struct posix_acl *acl);
-- 
2.4.3

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2016-02-29  8:17 UTC|newest]

Thread overview: 141+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-29  8:17 [PATCH v18 00/22] Richacls (Core and Ext4) Andreas Gruenbacher
2016-02-29  8:17 ` Andreas Gruenbacher
2016-02-29  8:17 ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 01/22] vfs: Add IS_ACL() and IS_RICHACL() tests Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 02/22] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 04/22] vfs: Make the inode passed to inode_change_ok non-const Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 05/22] vfs: Add permission flags for setting file attributes Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 06/22] richacl: In-memory representation and helper functions Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 07/22] richacl: Permission mapping functions Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 08/22] richacl: Compute maximum file masks from an acl Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 09/22] richacl: Permission check algorithm Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
2016-03-11 14:09   ` Christoph Hellwig
2016-03-11 14:09     ` Christoph Hellwig
2016-02-29  8:17 ` Andreas Gruenbacher [this message]
2016-02-29  8:17   ` [PATCH v18 10/22] posix_acl: Unexport acl_by_type and make it static Andreas Gruenbacher
2016-03-11 14:03   ` Christoph Hellwig
2016-03-11 14:03     ` Christoph Hellwig
2016-02-29  8:17 ` [PATCH v18 12/22] vfs: Add get_richacl and set_richacl inode operations Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 14/22] richacl: Update the file masks in chmod() Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 15/22] richacl: Check if an acl is equivalent to a file mode Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 16/22] richacl: Create-time inheritance Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 17/22] richacl: Automatic Inheritance Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 18/22] richacl: xattr mapping functions Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
     [not found]   ` <1456733847-17982-19-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-03-11 14:17     ` Christoph Hellwig
2016-03-11 14:17       ` Christoph Hellwig
2016-03-11 14:17       ` Christoph Hellwig
     [not found]       ` <20160311141701.GE14808-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-03-11 17:03         ` Andreas Gruenbacher
2016-03-11 17:03           ` Andreas Gruenbacher
2016-03-11 17:03           ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 20/22] vfs: Add richacl permission checking Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
2016-02-29  8:17 ` [PATCH v18 21/22] ext4: Add richacl support Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
     [not found]   ` <1456733847-17982-22-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-03-11 14:27     ` Christoph Hellwig
2016-03-11 14:27       ` Christoph Hellwig
2016-03-11 14:27       ` Christoph Hellwig
2016-03-13 23:49       ` Andreas Gruenbacher
2016-03-13 23:49         ` Andreas Gruenbacher
     [not found]       ` <20160311142719.GG14808-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-03-13 23:08         ` Andreas Gruenbacher
2016-03-13 23:08           ` Andreas Gruenbacher
2016-03-13 23:08           ` Andreas Gruenbacher
2016-03-15  7:17           ` Christoph Hellwig
2016-03-15  7:17             ` Christoph Hellwig
     [not found]             ` <20160315071707.GF19747-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-03-16 22:38               ` Andreas Gruenbacher
2016-03-16 22:38                 ` Andreas Gruenbacher
2016-03-16 22:38                 ` Andreas Gruenbacher
2016-03-14 13:02         ` Andreas Gruenbacher
2016-03-14 13:02           ` Andreas Gruenbacher
2016-03-14 13:02           ` Andreas Gruenbacher
2016-03-15  7:18           ` Christoph Hellwig
2016-03-15  7:18             ` Christoph Hellwig
2016-02-29  8:17 ` [PATCH v18 22/22] ext4: Add richacl feature flag Andreas Gruenbacher
2016-02-29  8:17   ` Andreas Gruenbacher
     [not found] ` <1456733847-17982-1-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-02-29  8:17   ` [PATCH v18 03/22] vfs: Add MAY_DELETE_SELF and MAY_DELETE_CHILD permission flags Andreas Gruenbacher
2016-02-29  8:17     ` Andreas Gruenbacher
2016-02-29  8:17     ` Andreas Gruenbacher
2016-02-29  8:17   ` [PATCH v18 11/22] vfs: Cache base_acl objects in inodes Andreas Gruenbacher
2016-02-29  8:17     ` Andreas Gruenbacher
2016-02-29  8:17     ` Andreas Gruenbacher
     [not found]     ` <1456733847-17982-12-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-03-11 14:07       ` Christoph Hellwig
2016-03-11 14:07         ` Christoph Hellwig
2016-03-11 14:07         ` Christoph Hellwig
2016-03-11 16:24         ` Andreas Gruenbacher
2016-03-11 16:24           ` Andreas Gruenbacher
2016-03-15  7:12           ` Christoph Hellwig
2016-03-15  7:12             ` Christoph Hellwig
2016-03-16 22:31             ` Andreas Gruenbacher
2016-03-16 22:31               ` Andreas Gruenbacher
2016-02-29  8:17   ` [PATCH v18 13/22] vfs: Cache richacl in struct inode Andreas Gruenbacher
2016-02-29  8:17     ` Andreas Gruenbacher
2016-02-29  8:17     ` Andreas Gruenbacher
2016-02-29  8:17   ` [PATCH v18 19/22] richacl: Add richacl xattr handler Andreas Gruenbacher
2016-02-29  8:17     ` Andreas Gruenbacher
2016-02-29  8:17     ` Andreas Gruenbacher
     [not found]     ` <1456733847-17982-20-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-03-11 14:17       ` Christoph Hellwig
2016-03-11 14:17         ` Christoph Hellwig
2016-03-11 14:17         ` Christoph Hellwig
     [not found]         ` <20160311141735.GF14808-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-03-11 14:19           ` J. Bruce Fields
2016-03-11 14:19             ` J. Bruce Fields
2016-03-11 14:19             ` J. Bruce Fields
2016-03-15  7:10             ` Christoph Hellwig
2016-03-15  7:10               ` Christoph Hellwig
2016-03-15 21:05               ` J. Bruce Fields
2016-03-15 21:05                 ` J. Bruce Fields
     [not found]                 ` <20160315210526.GC3658-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2016-03-21 16:09                   ` Christoph Hellwig
2016-03-21 16:09                     ` Christoph Hellwig
2016-03-21 16:09                     ` Christoph Hellwig
2016-03-11 14:01   ` [PATCH v18 00/22] Richacls (Core and Ext4) Christoph Hellwig
2016-03-11 14:01     ` Christoph Hellwig
2016-03-11 14:01     ` Christoph Hellwig
2016-03-11 14:07     ` J. Bruce Fields
2016-03-11 14:07       ` J. Bruce Fields
     [not found]       ` <20160311140757.GB13178-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2016-03-12 21:12         ` Simo
2016-03-12 21:12           ` Simo
2016-03-12 21:12           ` Simo
2016-03-15  7:09       ` Christoph Hellwig
2016-03-15  7:09         ` Christoph Hellwig
2016-03-11 16:11     ` Andreas Gruenbacher
2016-03-11 16:11       ` Andreas Gruenbacher
2016-03-11 20:05       ` Steve French
2016-03-11 20:05         ` Steve French
2016-03-11 23:02         ` Jeremy Allison
2016-03-11 23:02           ` Jeremy Allison
2016-03-13 23:02           ` Andreas Gruenbacher
2016-03-13 23:02             ` Andreas Gruenbacher
2016-03-13 23:02             ` Andreas Gruenbacher
     [not found]             ` <CAHc6FU5Bq9afVdNogc9DQYyyXwLfUopXW5ZnSuct3N+NvKW4Rg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-14  3:54               ` Jeremy Allison
2016-03-14  3:54                 ` Jeremy Allison
2016-03-14  3:54                 ` Jeremy Allison
2016-03-15  7:14         ` Christoph Hellwig
2016-03-15  7:14           ` Christoph Hellwig
     [not found]           ` <20160315071439.GE19747-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-03-16  3:40             ` Steve French
2016-03-16  3:40               ` Steve French
2016-03-16  3:40               ` Steve French
2016-03-15  7:11       ` Christoph Hellwig
2016-03-15  7:11         ` Christoph Hellwig
     [not found]         ` <20160315071103.GC19747-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-03-15 15:45           ` Jeremy Allison
2016-03-15 15:45             ` Jeremy Allison
2016-03-15 15:45             ` Jeremy Allison
2016-03-15 20:17             ` Volker Lendecke
2016-03-15 20:17               ` Volker Lendecke
2016-03-15 20:17               ` Volker Lendecke
2016-03-16  3:28               ` Steve French
2016-03-16  3:28                 ` Steve French
     [not found]               ` <20160315201700.GA22945-3ekOc4rQMZmzQB+pC5nmwQ@public.gmane.org>
2016-03-21 18:20                 ` Michael Adam
2016-03-21 18:20                   ` Michael Adam
2016-03-21 18:20                   ` Michael Adam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456733847-17982-11-git-send-email-agruenba@redhat.com \
    --to=agruenba@redhat.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=anna.schumaker@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=hch@infradead.org \
    --cc=jlayton@poochiereds.net \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.