All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: pbonzini@redhat.com, imammedo@redhat.com
Cc: gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com,
	mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com,
	dan.j.williams@intel.com, kvm@vger.kernel.org,
	qemu-devel@nongnu.org,
	Xiao Guangrong <guangrong.xiao@linux.intel.com>
Subject: [PATCH 5/9] acpi: add build_append_named_dword, returning an offset in buffer
Date: Tue,  1 Mar 2016 18:56:07 +0800	[thread overview]
Message-ID: <1456829771-71553-6-git-send-email-guangrong.xiao@linux.intel.com> (raw)
In-Reply-To: <1456829771-71553-1-git-send-email-guangrong.xiao@linux.intel.com>

From: "Michael S. Tsirkin" <mst@redhat.com>

This is a very limited form of support for runtime patching -
similar in functionality to what we can do with ACPI_EXTRACT
macros in python, but implemented in C.

This is to allow ACPI code direct access to data tables -
which is exactly what DataTableRegion is there for, except
no known windows release so far implements DataTableRegion.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
---
 hw/acpi/aml-build.c         | 28 ++++++++++++++++++++++++++++
 include/hw/acpi/aml-build.h |  3 +++
 2 files changed, 31 insertions(+)

diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
index f26fa26..ab89ca6 100644
--- a/hw/acpi/aml-build.c
+++ b/hw/acpi/aml-build.c
@@ -258,6 +258,34 @@ static void build_append_int(GArray *table, uint64_t value)
     }
 }
 
+/*
+ * Build NAME(XXXX, 0x00000000) where 0x00000000 is encoded as a dword,
+ * and return the offset to 0x00000000 for runtime patching.
+ *
+ * Warning: runtime patching is best avoided. Only use this as
+ * a replacement for DataTableRegion (for guests that don't
+ * support it).
+ */
+int
+build_append_named_dword(GArray *array, const char *name_format, ...)
+{
+    int offset;
+    va_list ap;
+
+    build_append_byte(array, 0x08); /* NameOp */
+    va_start(ap, name_format);
+    build_append_namestringv(array, name_format, ap);
+    va_end(ap);
+
+    build_append_byte(array, 0x0C); /* DWordPrefix */
+
+    offset = array->len;
+    build_append_int_noprefix(array, 0x00000000, 4);
+    assert(array->len == offset + 4);
+
+    return offset;
+}
+
 static GPtrArray *alloc_list;
 
 static Aml *aml_alloc(void)
diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
index 07b2d48..7404e2a 100644
--- a/include/hw/acpi/aml-build.h
+++ b/include/hw/acpi/aml-build.h
@@ -370,4 +370,7 @@ void
 build_rsdt(GArray *table_data, GArray *linker, GArray *table_offsets,
            const char *oem_id, const char *oem_table_id);
 
+int
+build_append_named_dword(GArray *array, const char *name_format, ...);
+
 #endif
-- 
1.8.3.1


WARNING: multiple messages have this Message-ID (diff)
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: pbonzini@redhat.com, imammedo@redhat.com
Cc: Xiao Guangrong <guangrong.xiao@linux.intel.com>,
	ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com,
	gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org,
	stefanha@redhat.com, dan.j.williams@intel.com, rth@twiddle.net
Subject: [Qemu-devel] [PATCH 5/9] acpi: add build_append_named_dword, returning an offset in buffer
Date: Tue,  1 Mar 2016 18:56:07 +0800	[thread overview]
Message-ID: <1456829771-71553-6-git-send-email-guangrong.xiao@linux.intel.com> (raw)
In-Reply-To: <1456829771-71553-1-git-send-email-guangrong.xiao@linux.intel.com>

From: "Michael S. Tsirkin" <mst@redhat.com>

This is a very limited form of support for runtime patching -
similar in functionality to what we can do with ACPI_EXTRACT
macros in python, but implemented in C.

This is to allow ACPI code direct access to data tables -
which is exactly what DataTableRegion is there for, except
no known windows release so far implements DataTableRegion.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
---
 hw/acpi/aml-build.c         | 28 ++++++++++++++++++++++++++++
 include/hw/acpi/aml-build.h |  3 +++
 2 files changed, 31 insertions(+)

diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
index f26fa26..ab89ca6 100644
--- a/hw/acpi/aml-build.c
+++ b/hw/acpi/aml-build.c
@@ -258,6 +258,34 @@ static void build_append_int(GArray *table, uint64_t value)
     }
 }
 
+/*
+ * Build NAME(XXXX, 0x00000000) where 0x00000000 is encoded as a dword,
+ * and return the offset to 0x00000000 for runtime patching.
+ *
+ * Warning: runtime patching is best avoided. Only use this as
+ * a replacement for DataTableRegion (for guests that don't
+ * support it).
+ */
+int
+build_append_named_dword(GArray *array, const char *name_format, ...)
+{
+    int offset;
+    va_list ap;
+
+    build_append_byte(array, 0x08); /* NameOp */
+    va_start(ap, name_format);
+    build_append_namestringv(array, name_format, ap);
+    va_end(ap);
+
+    build_append_byte(array, 0x0C); /* DWordPrefix */
+
+    offset = array->len;
+    build_append_int_noprefix(array, 0x00000000, 4);
+    assert(array->len == offset + 4);
+
+    return offset;
+}
+
 static GPtrArray *alloc_list;
 
 static Aml *aml_alloc(void)
diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
index 07b2d48..7404e2a 100644
--- a/include/hw/acpi/aml-build.h
+++ b/include/hw/acpi/aml-build.h
@@ -370,4 +370,7 @@ void
 build_rsdt(GArray *table_data, GArray *linker, GArray *table_offsets,
            const char *oem_id, const char *oem_table_id);
 
+int
+build_append_named_dword(GArray *array, const char *name_format, ...);
+
 #endif
-- 
1.8.3.1

  parent reply	other threads:[~2016-03-01 10:56 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-01 10:56 [PATCH v4 0/9] NVDIMM ACPI: introduce the framework of QEMU emulated Xiao Guangrong
2016-03-01 10:56 ` [Qemu-devel] " Xiao Guangrong
2016-03-01 10:56 ` [PATCH 1/9] acpi: add aml_create_field() Xiao Guangrong
2016-03-01 10:56   ` [Qemu-devel] " Xiao Guangrong
2016-03-01 10:56 ` [PATCH 2/9] acpi: add aml_concatenate() Xiao Guangrong
2016-03-01 10:56   ` [Qemu-devel] " Xiao Guangrong
2016-03-01 10:56 ` [PATCH 3/9] acpi: allow using object as offset for OperationRegion Xiao Guangrong
2016-03-01 10:56   ` [Qemu-devel] " Xiao Guangrong
2016-03-01 10:56 ` [PATCH 4/9] nvdimm acpi: initialize the resource used by NVDIMM ACPI Xiao Guangrong
2016-03-01 10:56   ` [Qemu-devel] " Xiao Guangrong
2016-03-01 10:56 ` Xiao Guangrong [this message]
2016-03-01 10:56   ` [Qemu-devel] [PATCH 5/9] acpi: add build_append_named_dword, returning an offset in buffer Xiao Guangrong
2016-03-01 10:56 ` [PATCH 6/9] nvdimm acpi: introduce patched dsm memory Xiao Guangrong
2016-03-01 10:56   ` [Qemu-devel] " Xiao Guangrong
2016-03-01 10:56 ` [PATCH 7/9] nvdimm acpi: let qemu handle _DSM method Xiao Guangrong
2016-03-01 10:56   ` [Qemu-devel] " Xiao Guangrong
2016-03-01 10:56 ` [PATCH 8/9] nvdimm acpi: emulate dsm method Xiao Guangrong
2016-03-01 10:56   ` [Qemu-devel] " Xiao Guangrong
2016-03-01 17:09   ` Michael S. Tsirkin
2016-03-01 17:09     ` [Qemu-devel] " Michael S. Tsirkin
2016-03-02  3:30     ` Xiao Guangrong
2016-03-02  3:30       ` [Qemu-devel] " Xiao Guangrong
2016-03-02  6:36       ` Michael S. Tsirkin
2016-03-02  6:36         ` [Qemu-devel] " Michael S. Tsirkin
2016-03-02  7:15         ` Xiao Guangrong
2016-03-02  7:15           ` [Qemu-devel] " Xiao Guangrong
2016-03-02  7:20           ` Michael S. Tsirkin
2016-03-02  7:20             ` [Qemu-devel] " Michael S. Tsirkin
2016-03-02  7:29             ` Xiao Guangrong
2016-03-02  7:29               ` [Qemu-devel] " Xiao Guangrong
2016-03-02  8:44               ` Michael S. Tsirkin
2016-03-02  8:44                 ` [Qemu-devel] " Michael S. Tsirkin
2016-03-02  9:05                 ` Xiao Guangrong
2016-03-02  9:05                   ` [Qemu-devel] " Xiao Guangrong
2016-03-02  7:21           ` Xiao Guangrong
2016-03-02  7:21             ` [Qemu-devel] " Xiao Guangrong
2016-03-01 17:12   ` Michael S. Tsirkin
2016-03-01 17:12     ` [Qemu-devel] " Michael S. Tsirkin
2016-03-02  4:00     ` Xiao Guangrong
2016-03-02  4:00       ` [Qemu-devel] " Xiao Guangrong
2016-03-02  6:38       ` Michael S. Tsirkin
2016-03-02  6:38         ` [Qemu-devel] " Michael S. Tsirkin
2016-03-01 10:56 ` [PATCH 9/9] nvdimm acpi: add _CRS Xiao Guangrong
2016-03-01 10:56   ` [Qemu-devel] " Xiao Guangrong
2016-03-01 16:36 ` [PATCH v4 0/9] NVDIMM ACPI: introduce the framework of QEMU emulated Michael S. Tsirkin
2016-03-01 16:36   ` [Qemu-devel] " Michael S. Tsirkin
2016-03-02  4:06   ` Xiao Guangrong
2016-03-02  4:06     ` [Qemu-devel] " Xiao Guangrong
2016-03-01 18:38 ` Michael S. Tsirkin
2016-03-01 18:38   ` [Qemu-devel] " Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456829771-71553-6-git-send-email-guangrong.xiao@linux.intel.com \
    --to=guangrong.xiao@linux.intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=ehabkost@redhat.com \
    --cc=gleb@kernel.org \
    --cc=imammedo@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.