All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@fr.ibm.com>
To: Corey Minyard <cminyard@mvista.com>
Cc: "Marcel Apfelbaum" <marcel@redhat.com>,
	"Cédric Le Goater" <clg@fr.ibm.com>,
	qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH v2 05/10] ipmi: add a realize function to the device class
Date: Wed,  2 Mar 2016 11:14:53 +0100	[thread overview]
Message-ID: <1456913698-11452-6-git-send-email-clg@fr.ibm.com> (raw)
In-Reply-To: <1456913698-11452-1-git-send-email-clg@fr.ibm.com>

This will be useful to define and use properties when the object is
instantiated.

Signed-off-by: Cédric Le Goater <clg@fr.ibm.com>
Acked-by: Corey Minyard <cminyard@mvista.com>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
---

Changes since v1:

 - removed empty properties.

 hw/ipmi/ipmi_bmc_sim.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
index 2626aff06c60..096f71010659 100644
--- a/hw/ipmi/ipmi_bmc_sim.c
+++ b/hw/ipmi/ipmi_bmc_sim.c
@@ -1706,9 +1706,9 @@ static const VMStateDescription vmstate_ipmi_sim = {
     }
 };
 
-static void ipmi_sim_init(Object *obj)
+static void ipmi_sim_realize(DeviceState *dev, Error **errp)
 {
-    IPMIBmc *b = IPMI_BMC(obj);
+    IPMIBmc *b = IPMI_BMC(dev);
     unsigned int i;
     unsigned int recid;
     IPMIBmcSim *ibs = IPMI_BMC_SIMULATOR(b);
@@ -1767,8 +1767,10 @@ static void ipmi_sim_init(Object *obj)
 
 static void ipmi_sim_class_init(ObjectClass *oc, void *data)
 {
+    DeviceClass *dc = DEVICE_CLASS(oc);
     IPMIBmcClass *bk = IPMI_BMC_CLASS(oc);
 
+    dc->realize = ipmi_sim_realize;
     bk->handle_command = ipmi_sim_handle_command;
 }
 
@@ -1776,7 +1778,6 @@ static const TypeInfo ipmi_sim_type = {
     .name          = TYPE_IPMI_BMC_SIMULATOR,
     .parent        = TYPE_IPMI_BMC,
     .instance_size = sizeof(IPMIBmcSim),
-    .instance_init = ipmi_sim_init,
     .class_init    = ipmi_sim_class_init,
 };
 
-- 
2.1.4

  parent reply	other threads:[~2016-03-02 10:15 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-02 10:14 [Qemu-devel] [PATCH v2 00/10] ipmi: a couple of enhancements to the BMC simulator (round 2) Cédric Le Goater
2016-03-02 10:14 ` [Qemu-devel] [PATCH v2 01/10] ipmi: remove IPMI_CHECK_CMD_LEN() macro Cédric Le Goater
2016-03-05 11:41   ` Corey Minyard
2016-03-07 10:40     ` Cédric Le Goater
2016-03-08 17:06       ` Cédric Le Goater
2016-03-09  4:07         ` Corey Minyard
2016-03-09  8:52           ` Cédric Le Goater
2016-03-02 10:14 ` [Qemu-devel] [PATCH v2 02/10] ipmi: replace IPMI_ADD_RSP_DATA() macro with inline helpers Cédric Le Goater
2016-03-02 10:25   ` Michael S. Tsirkin
2016-03-02 17:53     ` Cédric Le Goater
2016-03-02 18:02       ` Michael S. Tsirkin
2016-03-02 18:08         ` Cédric Le Goater
2016-03-05 11:41   ` Corey Minyard
2016-03-02 10:14 ` [Qemu-devel] [PATCH v2 03/10] ipmi: remove IPMI_CHECK_RESERVATION() macro Cédric Le Goater
2016-03-02 15:40   ` Corey Minyard
2016-03-02 10:14 ` [Qemu-devel] [PATCH v2 04/10] ipmi: add rsp_buffer_set_error() helper Cédric Le Goater
2016-03-05 11:42   ` Corey Minyard
2016-03-02 10:14 ` Cédric Le Goater [this message]
2016-03-02 10:14 ` [Qemu-devel] [PATCH v2 06/10] ipmi: use a function to initialize the SDR table Cédric Le Goater
2016-03-02 10:14 ` [Qemu-devel] [PATCH v2 07/10] ipmi: remove the need of an ending record in " Cédric Le Goater
2016-03-02 10:14 ` [Qemu-devel] [PATCH v2 08/10] ipmi: add some local variables in ipmi_sdr_init Cédric Le Goater
2016-03-02 10:14 ` [Qemu-devel] [PATCH v2 09/10] ipmi: use a file to load SDRs Cédric Le Goater
2016-03-02 10:14 ` [Qemu-devel] [PATCH v2 10/10] ipmi: provide support for FRUs Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456913698-11452-6-git-send-email-clg@fr.ibm.com \
    --to=clg@fr.ibm.com \
    --cc=cminyard@mvista.com \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.