From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Javier Martinez Canillas <javier@osg.samsung.com>,
Kukjin Kim <kgene@kernel.org>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
linux-samsung-soc@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: [PATCH 2/2] [media] exynos4-is: FIMC port parse should fail if there's no endpoint
Date: Fri, 4 Mar 2016 17:20:13 -0300 [thread overview]
Message-ID: <1457122813-12791-3-git-send-email-javier@osg.samsung.com> (raw)
In-Reply-To: <1457122813-12791-1-git-send-email-javier@osg.samsung.com>
The fimc_md_parse_port_node() function return 0 if an endpoint node is
not found but according to Documentation/devicetree/bindings/graph.txt,
a port must always have at least one enpoint.
So return an -EINVAL errno code to the caller instead, so it knows that
the port node parse failed due an invalid Device Tree description.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/media/platform/exynos4-is/media-dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c
index feb521f28e14..06f3d75c9a0e 100644
--- a/drivers/media/platform/exynos4-is/media-dev.c
+++ b/drivers/media/platform/exynos4-is/media-dev.c
@@ -394,7 +394,7 @@ static int fimc_md_parse_port_node(struct fimc_md *fmd,
/* Assume here a port node can have only one endpoint node. */
ep = of_get_next_child(port, NULL);
if (!ep)
- return 0;
+ return -EINVAL;
ret = v4l2_of_parse_endpoint(ep, &endpoint);
if (ret) {
--
2.5.0
WARNING: multiple messages have this Message-ID (diff)
From: javier@osg.samsung.com (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] [media] exynos4-is: FIMC port parse should fail if there's no endpoint
Date: Fri, 4 Mar 2016 17:20:13 -0300 [thread overview]
Message-ID: <1457122813-12791-3-git-send-email-javier@osg.samsung.com> (raw)
In-Reply-To: <1457122813-12791-1-git-send-email-javier@osg.samsung.com>
The fimc_md_parse_port_node() function return 0 if an endpoint node is
not found but according to Documentation/devicetree/bindings/graph.txt,
a port must always have at least one enpoint.
So return an -EINVAL errno code to the caller instead, so it knows that
the port node parse failed due an invalid Device Tree description.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/media/platform/exynos4-is/media-dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c
index feb521f28e14..06f3d75c9a0e 100644
--- a/drivers/media/platform/exynos4-is/media-dev.c
+++ b/drivers/media/platform/exynos4-is/media-dev.c
@@ -394,7 +394,7 @@ static int fimc_md_parse_port_node(struct fimc_md *fmd,
/* Assume here a port node can have only one endpoint node. */
ep = of_get_next_child(port, NULL);
if (!ep)
- return 0;
+ return -EINVAL;
ret = v4l2_of_parse_endpoint(ep, &endpoint);
if (ret) {
--
2.5.0
next prev parent reply other threads:[~2016-03-04 20:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 20:20 [PATCH 0/2] [media] exynos4-is: Trivial fixes for DT port/endpoint parse logic Javier Martinez Canillas
2016-03-04 20:20 ` Javier Martinez Canillas
2016-03-04 20:20 ` [PATCH 1/2] [media] exynos4-is: Put node before s5pcsis_parse_dt() return error Javier Martinez Canillas
2016-03-04 20:20 ` Javier Martinez Canillas
2016-03-04 20:20 ` Javier Martinez Canillas [this message]
2016-03-04 20:20 ` [PATCH 2/2] [media] exynos4-is: FIMC port parse should fail if there's no endpoint Javier Martinez Canillas
2016-03-11 13:03 ` Sylwester Nawrocki
2016-03-11 13:03 ` Sylwester Nawrocki
2016-03-11 14:55 ` Javier Martinez Canillas
2016-03-11 14:55 ` Javier Martinez Canillas
2016-03-11 14:55 ` Javier Martinez Canillas
2016-03-22 20:19 ` Javier Martinez Canillas
2016-03-22 20:19 ` Javier Martinez Canillas
2016-03-05 4:35 ` [PATCH 0/2] [media] exynos4-is: Trivial fixes for DT port/endpoint parse logic Krzysztof Kozlowski
2016-03-05 4:35 ` Krzysztof Kozlowski
2016-03-07 9:24 ` Sylwester Nawrocki
2016-03-07 9:24 ` Sylwester Nawrocki
2016-03-07 9:24 ` Sylwester Nawrocki
2016-03-07 14:30 ` Javier Martinez Canillas
2016-03-07 14:30 ` Javier Martinez Canillas
2016-03-11 13:09 ` Sylwester Nawrocki
2016-03-11 13:09 ` Sylwester Nawrocki
2016-03-11 14:39 ` Javier Martinez Canillas
2016-03-11 14:39 ` Javier Martinez Canillas
2016-03-11 14:39 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457122813-12791-3-git-send-email-javier@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.