All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <eguan@redhat.com>
To: fstests@vger.kernel.org
Cc: xfs@oss.sgi.com, Eryu Guan <eguan@redhat.com>
Subject: [PATCH v3] xfs/073: ignore mkfs output
Date: Thu, 17 Mar 2016 12:27:45 +0800	[thread overview]
Message-ID: <1458188865-14819-1-git-send-email-eguan@redhat.com> (raw)

When testing xfs/073 with MKFS_OPTIONS="-m crc=1,finobt=1" set, it fails
due to extra warning about disabling finobt feature:

 +warning: finobt not supported without CRC support, disabled.

Because xfs/073 disables crc unconditionally and finobt can not be
enabled either.

Fix it by dumping mkfs output to $seqres.full and updating 073.out
accordingly.

Signed-off-by: Eryu Guan <eguan@redhat.com>
---

v3:
- just ignore mkfs output
v2:
- disable finobt explicitly, instead of filtering the warning

 tests/xfs/073     | 2 +-
 tests/xfs/073.out | 6 ------
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/tests/xfs/073 b/tests/xfs/073
index e1335df..9e29223 100755
--- a/tests/xfs/073
+++ b/tests/xfs/073
@@ -138,7 +138,7 @@ _require_loop
 
 rm -f $seqres.full
 
-_scratch_mkfs_xfs -m crc=0 -dsize=41m,agcount=2 | _filter_mkfs 2>/dev/null
+_scratch_mkfs_xfs -m crc=0 -dsize=41m,agcount=2 >>$seqres.full 2>&1
 _scratch_mount 2>/dev/null || _fail "initial scratch mount failed"
 
 echo
diff --git a/tests/xfs/073.out b/tests/xfs/073.out
index 3f27467..5f36ebe 100644
--- a/tests/xfs/073.out
+++ b/tests/xfs/073.out
@@ -1,10 +1,4 @@
 QA output created by 073
-meta-data=DDEV isize=XXX agcount=N, agsize=XXX blks
-data     = bsize=XXX blocks=XXX, imaxpct=PCT
-         = sunit=XXX swidth=XXX, unwritten=X
-naming   =VERN bsize=XXX
-log      =LDEV bsize=XXX blocks=XXX
-realtime =RDEV extsz=XXX blocks=XXX, rtextents=XXX
 
 === populating scratch device
 1000+0 records in
-- 
2.5.0


WARNING: multiple messages have this Message-ID (diff)
From: Eryu Guan <eguan@redhat.com>
To: fstests@vger.kernel.org
Cc: Eryu Guan <eguan@redhat.com>, xfs@oss.sgi.com
Subject: [PATCH v3] xfs/073: ignore mkfs output
Date: Thu, 17 Mar 2016 12:27:45 +0800	[thread overview]
Message-ID: <1458188865-14819-1-git-send-email-eguan@redhat.com> (raw)

When testing xfs/073 with MKFS_OPTIONS="-m crc=1,finobt=1" set, it fails
due to extra warning about disabling finobt feature:

 +warning: finobt not supported without CRC support, disabled.

Because xfs/073 disables crc unconditionally and finobt can not be
enabled either.

Fix it by dumping mkfs output to $seqres.full and updating 073.out
accordingly.

Signed-off-by: Eryu Guan <eguan@redhat.com>
---

v3:
- just ignore mkfs output
v2:
- disable finobt explicitly, instead of filtering the warning

 tests/xfs/073     | 2 +-
 tests/xfs/073.out | 6 ------
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/tests/xfs/073 b/tests/xfs/073
index e1335df..9e29223 100755
--- a/tests/xfs/073
+++ b/tests/xfs/073
@@ -138,7 +138,7 @@ _require_loop
 
 rm -f $seqres.full
 
-_scratch_mkfs_xfs -m crc=0 -dsize=41m,agcount=2 | _filter_mkfs 2>/dev/null
+_scratch_mkfs_xfs -m crc=0 -dsize=41m,agcount=2 >>$seqres.full 2>&1
 _scratch_mount 2>/dev/null || _fail "initial scratch mount failed"
 
 echo
diff --git a/tests/xfs/073.out b/tests/xfs/073.out
index 3f27467..5f36ebe 100644
--- a/tests/xfs/073.out
+++ b/tests/xfs/073.out
@@ -1,10 +1,4 @@
 QA output created by 073
-meta-data=DDEV isize=XXX agcount=N, agsize=XXX blks
-data     = bsize=XXX blocks=XXX, imaxpct=PCT
-         = sunit=XXX swidth=XXX, unwritten=X
-naming   =VERN bsize=XXX
-log      =LDEV bsize=XXX blocks=XXX
-realtime =RDEV extsz=XXX blocks=XXX, rtextents=XXX
 
 === populating scratch device
 1000+0 records in
-- 
2.5.0

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

             reply	other threads:[~2016-03-17  4:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-17  4:27 Eryu Guan [this message]
2016-03-17  4:27 ` [PATCH v3] xfs/073: ignore mkfs output Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458188865-14819-1-git-send-email-eguan@redhat.com \
    --to=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.