From: Xiao Guangrong <guangrong.xiao@linux.intel.com> To: pbonzini@redhat.com, imammedo@redhat.com Cc: gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org, Xiao Guangrong <guangrong.xiao@linux.intel.com> Subject: [PATCH 02/15] pc-dimm: introduce realize callback Date: Thu, 17 Mar 2016 16:32:48 +0800 [thread overview] Message-ID: <1458203581-59143-3-git-send-email-guangrong.xiao@linux.intel.com> (raw) In-Reply-To: <1458203581-59143-1-git-send-email-guangrong.xiao@linux.intel.com> nvdimm needs to check if the backend memory is large enough to contain label data and init its memory region when the device is realized, so introduce realize callback which is called after common dimm has been realize Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com> --- hw/mem/pc-dimm.c | 5 +++++ include/hw/mem/pc-dimm.h | 3 +++ 2 files changed, 8 insertions(+) diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c index 0ba17f0..47ae823 100644 --- a/hw/mem/pc-dimm.c +++ b/hw/mem/pc-dimm.c @@ -399,6 +399,7 @@ static void pc_dimm_init(Object *obj) static void pc_dimm_realize(DeviceState *dev, Error **errp) { PCDIMMDevice *dimm = PC_DIMM(dev); + PCDIMMDeviceClass *ddc = PC_DIMM_GET_CLASS(dimm); if (!dimm->hostmem) { error_setg(errp, "'" PC_DIMM_MEMDEV_PROP "' property is not set"); @@ -411,6 +412,10 @@ static void pc_dimm_realize(DeviceState *dev, Error **errp) dimm->node, nb_numa_nodes ? nb_numa_nodes : 1); return; } + + if (ddc->realize) { + ddc->realize(dimm, errp); + } } static MemoryRegion *pc_dimm_get_memory_region(PCDIMMDevice *dimm) diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h index 827f1bc..e7b7e5a 100644 --- a/include/hw/mem/pc-dimm.h +++ b/include/hw/mem/pc-dimm.h @@ -60,6 +60,8 @@ typedef struct PCDIMMDevice { /** * PCDIMMDeviceClass: + * @realize: called after common dimm is realized so that the dimm based + * devices get the chance to do specified operations. * @get_memory_region: returns #MemoryRegion associated with @dimm which * is directly mapped into the physical address space of guest */ @@ -68,6 +70,7 @@ typedef struct PCDIMMDeviceClass { DeviceClass parent_class; /* public */ + void (*realize)(PCDIMMDevice *dimm, Error **errp); MemoryRegion *(*get_memory_region)(PCDIMMDevice *dimm); } PCDIMMDeviceClass; -- 1.8.3.1
WARNING: multiple messages have this Message-ID (diff)
From: Xiao Guangrong <guangrong.xiao@linux.intel.com> To: pbonzini@redhat.com, imammedo@redhat.com Cc: Xiao Guangrong <guangrong.xiao@linux.intel.com>, ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, dan.j.williams@intel.com, rth@twiddle.net Subject: [Qemu-devel] [PATCH 02/15] pc-dimm: introduce realize callback Date: Thu, 17 Mar 2016 16:32:48 +0800 [thread overview] Message-ID: <1458203581-59143-3-git-send-email-guangrong.xiao@linux.intel.com> (raw) In-Reply-To: <1458203581-59143-1-git-send-email-guangrong.xiao@linux.intel.com> nvdimm needs to check if the backend memory is large enough to contain label data and init its memory region when the device is realized, so introduce realize callback which is called after common dimm has been realize Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com> --- hw/mem/pc-dimm.c | 5 +++++ include/hw/mem/pc-dimm.h | 3 +++ 2 files changed, 8 insertions(+) diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c index 0ba17f0..47ae823 100644 --- a/hw/mem/pc-dimm.c +++ b/hw/mem/pc-dimm.c @@ -399,6 +399,7 @@ static void pc_dimm_init(Object *obj) static void pc_dimm_realize(DeviceState *dev, Error **errp) { PCDIMMDevice *dimm = PC_DIMM(dev); + PCDIMMDeviceClass *ddc = PC_DIMM_GET_CLASS(dimm); if (!dimm->hostmem) { error_setg(errp, "'" PC_DIMM_MEMDEV_PROP "' property is not set"); @@ -411,6 +412,10 @@ static void pc_dimm_realize(DeviceState *dev, Error **errp) dimm->node, nb_numa_nodes ? nb_numa_nodes : 1); return; } + + if (ddc->realize) { + ddc->realize(dimm, errp); + } } static MemoryRegion *pc_dimm_get_memory_region(PCDIMMDevice *dimm) diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h index 827f1bc..e7b7e5a 100644 --- a/include/hw/mem/pc-dimm.h +++ b/include/hw/mem/pc-dimm.h @@ -60,6 +60,8 @@ typedef struct PCDIMMDevice { /** * PCDIMMDeviceClass: + * @realize: called after common dimm is realized so that the dimm based + * devices get the chance to do specified operations. * @get_memory_region: returns #MemoryRegion associated with @dimm which * is directly mapped into the physical address space of guest */ @@ -68,6 +70,7 @@ typedef struct PCDIMMDeviceClass { DeviceClass parent_class; /* public */ + void (*realize)(PCDIMMDevice *dimm, Error **errp); MemoryRegion *(*get_memory_region)(PCDIMMDevice *dimm); } PCDIMMDeviceClass; -- 1.8.3.1
next prev parent reply other threads:[~2016-03-17 8:32 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-03-17 8:32 [PATCH 00/15] NVDIMM: introduce nvdimm label support Xiao Guangrong 2016-03-17 8:32 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 8:32 ` [PATCH 01/15] pc-dimm: get memory region from ->get_memory_region() Xiao Guangrong 2016-03-17 8:32 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 8:32 ` Xiao Guangrong [this message] 2016-03-17 8:32 ` [Qemu-devel] [PATCH 02/15] pc-dimm: introduce realize callback Xiao Guangrong 2016-03-17 8:32 ` [PATCH 03/15] pc-dimm: keep the state of the whole backend memory Xiao Guangrong 2016-03-17 8:32 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 8:32 ` [PATCH 04/15] nvdimm: support nvdimm label Xiao Guangrong 2016-03-17 8:32 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 10:28 ` Stefan Hajnoczi 2016-03-17 10:28 ` [Qemu-devel] " Stefan Hajnoczi 2016-03-23 3:40 ` Xiao Guangrong 2016-03-23 3:40 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 8:32 ` [PATCH 05/15] acpi: add aml_object_type Xiao Guangrong 2016-03-17 8:32 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 8:32 ` [PATCH 06/15] acpi: add aml_call5 Xiao Guangrong 2016-03-17 8:32 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 8:32 ` [PATCH 07/15] nvdimm acpi: set HDLE properly Xiao Guangrong 2016-03-17 8:32 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 8:32 ` [PATCH 08/15] nvdimm acpi: save arg3 of _DSM method Xiao Guangrong 2016-03-17 8:32 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 8:32 ` [PATCH 09/15] nvdimm acpi: check UUID Xiao Guangrong 2016-03-17 8:32 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 8:32 ` [PATCH 10/15] nvdimm acpi: abstract the operations for root device and nvdimm devices Xiao Guangrong 2016-03-17 8:32 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 10:35 ` Stefan Hajnoczi 2016-03-17 10:35 ` [Qemu-devel] " Stefan Hajnoczi 2016-03-23 3:43 ` Xiao Guangrong 2016-03-23 3:43 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 8:32 ` [PATCH 11/15] nvdimm acpi: check revision Xiao Guangrong 2016-03-17 8:32 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 8:32 ` [PATCH 12/15] nvdimm acpi: support Get Namespace Label Size function Xiao Guangrong 2016-03-17 8:32 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 10:58 ` Stefan Hajnoczi 2016-03-17 10:58 ` [Qemu-devel] " Stefan Hajnoczi 2016-03-23 3:46 ` Xiao Guangrong 2016-03-23 3:46 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 8:32 ` [PATCH 13/15] nvdimm acpi: support Get Namespace Label Data function Xiao Guangrong 2016-03-17 8:32 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 8:33 ` [PATCH 14/15] nvdimm acpi: support Set " Xiao Guangrong 2016-03-17 8:33 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 8:33 ` [PATCH 15/15] docs: add NVDIMM ACPI documentation Xiao Guangrong 2016-03-17 8:33 ` [Qemu-devel] " Xiao Guangrong 2016-03-17 10:04 ` [PATCH 00/15] NVDIMM: introduce nvdimm label support Stefan Hajnoczi 2016-03-17 10:04 ` [Qemu-devel] " Stefan Hajnoczi 2016-03-22 15:37 ` Dan Williams 2016-03-22 15:37 ` [Qemu-devel] " Dan Williams 2016-03-22 20:30 ` Stefan Hajnoczi 2016-03-22 20:30 ` [Qemu-devel] " Stefan Hajnoczi 2016-03-23 2:46 ` Xiao Guangrong 2016-03-23 2:46 ` [Qemu-devel] " Xiao Guangrong 2016-03-23 16:48 ` Stefan Hajnoczi 2016-03-23 16:48 ` [Qemu-devel] " Stefan Hajnoczi 2016-03-22 11:17 ` Michael S. Tsirkin 2016-03-22 11:17 ` [Qemu-devel] " Michael S. Tsirkin 2016-03-23 3:47 ` Xiao Guangrong 2016-03-23 3:47 ` [Qemu-devel] " Xiao Guangrong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1458203581-59143-3-git-send-email-guangrong.xiao@linux.intel.com \ --to=guangrong.xiao@linux.intel.com \ --cc=dan.j.williams@intel.com \ --cc=ehabkost@redhat.com \ --cc=gleb@kernel.org \ --cc=imammedo@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=mst@redhat.com \ --cc=mtosatti@redhat.com \ --cc=pbonzini@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=rth@twiddle.net \ --cc=stefanha@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.