From: Bandan Das <bsd@redhat.com>
To: tj@kernel.org
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
mst@redhat.com, jiangshanlai@gmail.com, RAPOPORT@il.ibm.com
Subject: [RFC PATCH 3/4] cgroup: use spin_lock_irq for cgroup match and attach fns
Date: Fri, 18 Mar 2016 18:14:50 -0400 [thread overview]
Message-ID: <1458339291-4093-4-git-send-email-bsd@redhat.com> (raw)
In-Reply-To: <1458339291-4093-1-git-send-email-bsd@redhat.com>
Since these functions will be called from the worker
thread context, using spin_lock_bh triggers WARN_ONs.
Signed-off-by: Bandan Das <bsd@redhat.com>
---
kernel/cgroup.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 3ffdbb4..24b34e8 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -2764,10 +2764,10 @@ bool cgroup_match_groups(struct task_struct *tsk1, struct task_struct *tsk2)
if (!root->subsys_mask)
continue;
- spin_lock_bh(&css_set_lock);
+ spin_lock_irq(&css_set_lock);
cg_tsk1 = task_cgroup_from_root(tsk1, root);
cg_tsk2 = task_cgroup_from_root(tsk2, root);
- spin_unlock_bh(&css_set_lock);
+ spin_unlock_irq(&css_set_lock);
if (cg_tsk1 != cg_tsk2) {
result = false;
@@ -2797,9 +2797,9 @@ int cgroup_attach_task_all(struct task_struct *from, struct task_struct *tsk)
if (root == &cgrp_dfl_root)
continue;
- spin_lock_bh(&css_set_lock);
+ spin_lock_irq(&css_set_lock);
from_cgrp = task_cgroup_from_root(from, root);
- spin_unlock_bh(&css_set_lock);
+ spin_unlock_irq(&css_set_lock);
retval = cgroup_attach_task(from_cgrp, tsk, false);
if (retval)
--
2.5.0
next prev parent reply other threads:[~2016-03-18 22:16 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 22:14 [RFC PATCH 0/4] cgroup aware workqueues Bandan Das
2016-03-18 22:14 ` [RFC PATCH 1/4] cgroup: Introduce a function to compare two tasks Bandan Das
2016-03-18 22:14 ` [RFC PATCH 2/4] workqueue: introduce support for attaching to cgroups Bandan Das
2016-03-18 22:14 ` Bandan Das [this message]
2016-03-18 22:14 ` [RFC PATCH 4/4] vhost: use workqueues for the works Bandan Das
2016-03-20 18:10 ` [RFC PATCH 0/4] cgroup aware workqueues Tejun Heo
2016-03-21 17:35 ` Bandan Das
2016-03-21 7:58 ` Michael Rapoport
2016-03-21 7:58 ` Michael Rapoport
2016-03-21 7:58 ` Michael Rapoport
2016-03-21 17:43 ` Bandan Das
2016-03-22 7:12 ` vhost threading model (was: Re: [RFC PATCH 0/4] cgroup aware workqueues) Michael Rapoport
2016-03-22 19:00 ` vhost threading model Bandan Das
2016-03-23 11:13 ` Michael Rapoport
2016-03-23 11:13 ` Michael Rapoport
2016-03-22 7:12 ` vhost threading model (was: Re: [RFC PATCH 0/4] cgroup aware workqueues) Michael Rapoport
2016-03-22 7:12 ` Michael Rapoport
2016-03-21 8:29 ` [RFC PATCH 0/4] cgroup aware workqueues Christian Borntraeger
2016-03-21 17:49 ` Bandan Das
[not found] ` <201603210758.u2L7wiY9003907@d06av07.portsmouth.uk.ibm.com>
2016-03-30 17:04 ` Tejun Heo
2016-03-31 6:17 ` Michael Rapoport
2016-03-31 6:17 ` Michael Rapoport
2016-03-31 6:17 ` Michael Rapoport
2016-03-31 17:14 ` Tejun Heo
2016-03-31 18:45 ` Bandan Das
2016-04-03 10:43 ` Michael Rapoport
2016-04-03 10:43 ` Michael Rapoport
2016-04-03 10:43 ` Michael Rapoport
[not found] ` <201604031043.u33AhpSF023771@d06av06.portsmouth.uk.ibm.com>
2016-04-04 17:00 ` Bandan Das
2016-04-03 10:43 ` Michael Rapoport
2016-04-03 10:43 ` Michael Rapoport
2016-05-27 9:22 ` Michael Rapoport
2016-05-27 9:22 ` Michael Rapoport
2016-05-27 14:17 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458339291-4093-4-git-send-email-bsd@redhat.com \
--to=bsd@redhat.com \
--cc=RAPOPORT@il.ibm.com \
--cc=jiangshanlai@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.