All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe Ricard <christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org
Cc: jean-luc.blanc-qxv4g6HH51o@public.gmane.org,
	ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org,
	tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	christophe-h.ricard-qxv4g6HH51o@public.gmane.org,
	benoit.houyere-qxv4g6HH51o@public.gmane.org
Subject: [PATCH 2/3] tpm/st33zp24/spi: Drop two useless checks in ACPI probe path
Date: Wed, 23 Mar 2016 08:55:33 +0100	[thread overview]
Message-ID: <1458719734-13752-3-git-send-email-christophe-h.ricard@st.com> (raw)
In-Reply-To: <1458719734-13752-1-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>

When st33zp24_spi_acpi_request_resources() gets called we
already know that the entries in ->acpi_match_table have matched ACPI ID
of the device.
In addition spi_device pointer cannot be NULL in any case (otherwise I2C
core would not call ->probe() for the driver in the first place).

Drop the two useless checks from the driver.

Signed-off-by: Christophe Ricard <christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
---
 drivers/char/tpm/st33zp24/spi.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/drivers/char/tpm/st33zp24/spi.c b/drivers/char/tpm/st33zp24/spi.c
index 6be51ac..608dbc6 100644
--- a/drivers/char/tpm/st33zp24/spi.c
+++ b/drivers/char/tpm/st33zp24/spi.c
@@ -232,19 +232,8 @@ static const struct st33zp24_phy_ops spi_phy_ops = {
 static int st33zp24_spi_acpi_request_resources(struct spi_device *spi_dev)
 {
 	struct st33zp24_spi_phy *phy = spi_get_drvdata(spi_dev);
-	const struct acpi_device_id *id;
 	struct gpio_desc *gpiod_lpcpd;
-	struct device *dev;
-
-	if (!spi_dev)
-		return -EINVAL;
-
-	dev = &spi_dev->dev;
-
-	/* Match the struct device against a given list of ACPI IDs */
-	id = acpi_match_device(dev->driver->acpi_match_table, dev);
-	if (!id)
-		return -ENODEV;
+	struct device *dev = &spi_dev->dev;
 
 	/* Get LPCPD GPIO from ACPI */
 	gpiod_lpcpd = devm_gpiod_get_index(dev, "TPM IO LPCPD", 1,
-- 
2.5.0


------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140

  parent reply	other threads:[~2016-03-23  7:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-23  7:55 [PATCH 0/3] Few st33zp24 fixes Christophe Ricard
     [not found] ` <1458719734-13752-1-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-03-23  7:55   ` [PATCH 1/3] tpm/st33zp24/i2c: Drop two useless checks in ACPI probe path Christophe Ricard
     [not found]     ` <1458719734-13752-2-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-03-24 13:23       ` Jarkko Sakkinen
2016-03-23  7:55   ` Christophe Ricard [this message]
     [not found]     ` <1458719734-13752-3-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-03-24 13:24       ` [PATCH 2/3] tpm/st33zp24/spi: " Jarkko Sakkinen
2016-03-23  7:55   ` [PATCH 3/3] tpm/st33zp24: Remove unneeded tpm_reg in get_burstcount Christophe Ricard
     [not found]     ` <1458719734-13752-4-git-send-email-christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
2016-03-24 13:24       ` Jarkko Sakkinen
2016-03-23  8:17   ` [PATCH 0/3] Few st33zp24 fixes Jarkko Sakkinen
     [not found]     ` <20160323081755.GA6434-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-03-23  8:21       ` Christophe Ricard
     [not found]         ` <56F251F2.6050709-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-03-23 11:21           ` Jarkko Sakkinen
2016-03-23 21:58           ` [PATCH] tpm: drop int_queue from tpm_vendor_specific Christophe Ricard
     [not found]             ` <56F31170.4020702-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-03-24 13:25               ` Jarkko Sakkinen
2016-03-29 16:20   ` [PATCH 0/3] Few st33zp24 fixes Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458719734-13752-3-git-send-email-christophe-h.ricard@st.com \
    --to=christophe.ricard-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org \
    --cc=benoit.houyere-qxv4g6HH51o@public.gmane.org \
    --cc=christophe-h.ricard-qxv4g6HH51o@public.gmane.org \
    --cc=jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=jean-luc.blanc-qxv4g6HH51o@public.gmane.org \
    --cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.