All of lore.kernel.org
 help / color / mirror / Atom feed
From: marcin.krzeminski@nokia.com
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, crosthwaitepeter@gmail.com,
	clg@fr.ibm.com, pawel.lenkow@itlen.com,
	rfsw-patches@mlist.nsn-inter.net
Subject: [Qemu-devel] [PATCH v6 07/11] block: m25p80: Dummy cycles for N25Q256/512
Date: Wed, 23 Mar 2016 08:56:25 +0100	[thread overview]
Message-ID: <1458719789-29868-8-git-send-email-marcin.krzeminski@nokia.com> (raw)
In-Reply-To: <1458719789-29868-1-git-send-email-marcin.krzeminski@nokia.com>

From: Marcin Krzeminski <marcin.krzeminski@nokia.com>

Use the setting from the volatile cfg register to correctly
set the number of dummy cycles.

Signed-off-by: Marcin Krzeminski <marcin.krzeminski@nokia.com>
Reviewed-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
---
 hw/block/m25p80.c | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
index 3394f22..04e8730 100644
--- a/hw/block/m25p80.c
+++ b/hw/block/m25p80.c
@@ -583,7 +583,11 @@ static void decode_new_cmd(Flash *s, uint32_t value)
     case FAST_READ:
     case DOR:
     case QOR:
-        s->needed_bytes = get_addr_length(s) + 1;
+        s->needed_bytes = get_addr_length(s);
+        if (((s->pi->jedec >> 16) & 0xFF) == JEDEC_NUMONYX) {
+            /* Dummy cycles modeled with bytes writes instead of bits */
+            s->needed_bytes += extract32(s->volatile_cfg, 4, 4);
+        }
         s->pos = 0;
         s->len = 0;
         s->state = STATE_COLLECTING_DATA;
@@ -596,7 +600,9 @@ static void decode_new_cmd(Flash *s, uint32_t value)
             s->needed_bytes = 4;
             break;
         default:
-            s->needed_bytes = get_addr_length(s) + 2;
+            s->needed_bytes = get_addr_length(s);
+            /* Dummy cycles modeled with bytes writes instead of bits */
+            s->needed_bytes += extract32(s->volatile_cfg, 4, 4);
         }
         s->pos = 0;
         s->len = 0;
@@ -610,7 +616,9 @@ static void decode_new_cmd(Flash *s, uint32_t value)
             s->needed_bytes = 6;
             break;
         default:
-            s->needed_bytes = get_addr_length(s) + 4;
+            s->needed_bytes = get_addr_length(s);
+            /* Dummy cycles modeled with bytes writes instead of bits */
+            s->needed_bytes += extract32(s->volatile_cfg, 4, 4);
         }
         s->pos = 0;
         s->len = 0;
-- 
2.5.0

  parent reply	other threads:[~2016-03-23  7:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-23  7:56 [Qemu-devel] [PATCH v6 00/11] Support for N25Q256/512 and AT25128/256 marcin.krzeminski
2016-03-23  7:56 ` [Qemu-devel] [PATCH v6 01/11] block: m25p80: Removed unused variable marcin.krzeminski
2016-03-23  7:56 ` [Qemu-devel] [PATCH v6 02/11] block: m25p80: RESET_ENABLE and RESET_MEMORY commands marcin.krzeminski
2016-03-23  7:56 ` [Qemu-devel] [PATCH v6 03/11] block: m25p80: Widen flags variable marcin.krzeminski
2016-03-23  7:56 ` [Qemu-devel] [PATCH v6 04/11] block: m25p80: Extend address mode marcin.krzeminski
2016-03-23  7:56 ` [Qemu-devel] [PATCH v6 05/11] block: m25p80: 4byte " marcin.krzeminski
2016-03-23  7:56 ` [Qemu-devel] [PATCH v6 06/11] block: m25p80: Add configuration registers marcin.krzeminski
2016-03-23  7:56 ` marcin.krzeminski [this message]
2016-03-23  7:56 ` [Qemu-devel] [PATCH v6 08/11] block: m25p80: Fast read and 4bytes commands marcin.krzeminski
2016-03-23  7:56 ` [Qemu-devel] [PATCH v6 09/11] block: m25p80: Implemented FSR register marcin.krzeminski
2016-03-23  7:56 ` [Qemu-devel] [PATCH v6 10/11] block: m25p80: n25q256a/n25q512a models marcin.krzeminski
2016-03-23  7:56 ` [Qemu-devel] [PATCH v6 11/11] block: m25p80: at25128a/at25256a models marcin.krzeminski
2016-03-24 16:29 ` [Qemu-devel] [PATCH v6 00/11] Support for N25Q256/512 and AT25128/256 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458719789-29868-8-git-send-email-marcin.krzeminski@nokia.com \
    --to=marcin.krzeminski@nokia.com \
    --cc=clg@fr.ibm.com \
    --cc=crosthwaitepeter@gmail.com \
    --cc=pawel.lenkow@itlen.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rfsw-patches@mlist.nsn-inter.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.