From: Eryu Guan <eguan@redhat.com>
To: fstests@vger.kernel.org
Cc: Eryu Guan <eguan@redhat.com>
Subject: [PATCH] generic/244: avoid creating too large random ID
Date: Tue, 29 Mar 2016 20:17:19 +0800 [thread overview]
Message-ID: <1459253839-17197-1-git-send-email-eguan@redhat.com> (raw)
ppc64 hosts are generating too large random IDs like 725294314141253632,
which causes all sorts of errors in test.
Fix it by using format "-t uI" for 'int' size and it works fine on all
platforms.
Signed-off-by: Eryu Guan <eguan@redhat.com>
---
TBH, I'm not quite clear why "-t uL" behaves differently on ppc64 (even ppc64le
works fine), and I didn't dig too deep into it. "-t uI" just works :)
tests/generic/244 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/generic/244 b/tests/generic/244
index eb5a5ab..0b50438 100755
--- a/tests/generic/244
+++ b/tests/generic/244
@@ -83,7 +83,7 @@ ITERATIONS=100
# A few extra on the off chance we get dups
for I in `seq 1 $(($ITERATIONS+10))`; do
- ID=`od -N 4 -t uL -An /dev/urandom | tr -d " "`
+ ID=`od -N 4 -t uI -An /dev/urandom | tr -d " "`
echo $ID >> $tmp.1
done
--
2.5.5
reply other threads:[~2016-03-29 12:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459253839-17197-1-git-send-email-eguan@redhat.com \
--to=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.