From: Eryu Guan <eguan@redhat.com> To: fstests@vger.kernel.org Cc: xfs@oss.sgi.com, darrick.wong@oracle.com, Eryu Guan <eguan@redhat.com> Subject: [PATCH v2] xfs/030: filter out repeated lines from .out files Date: Thu, 31 Mar 2016 14:11:22 +0800 [thread overview] Message-ID: <1459404682-12282-1-git-send-email-eguan@redhat.com> (raw) In-Reply-To: <1459331861-15025-1-git-send-email-eguan@redhat.com> Commit 31f48569c353 ("xfs/030: fix output on newer filesystems") added more lines to .out file to match the output from XFS with reflink support, but it broke test on older XFS. Dave explained the reason and pointed out the correct way to fix it, so I just quote Dave's mail here: "The problem here is that reflink triggers a change in the initial population of the AGFL - from 4 blocks to 6 blocks, and so repair warns 6 times instead of 4. After filtering, that gives 6 indentical output lines instead of 4. Doing something as simple as collapsing repeated identical lines (e.g filtering through uniq) will work for all filesystem formats and any future changes that modify the initial AGFL population." Suggested-by: Dave Chinner <dchinner@redhat.com> Signed-off-by: Eryu Guan <eguan@redhat.com> --- tests/xfs/030 | 2 +- tests/xfs/030.out.irix | 3 --- tests/xfs/030.out.linux | 5 ----- 3 files changed, 1 insertion(+), 9 deletions(-) diff --git a/tests/xfs/030 b/tests/xfs/030 index 33c906c..5c99d9e 100755 --- a/tests/xfs/030 +++ b/tests/xfs/030 @@ -55,7 +55,7 @@ _check_ag() for structure in 'sb 0' 'agf 0' 'agi 0' 'agfl 0' do echo "Corrupting $structure - setting bits to $1" - _check_repair $1 "$structure" | + _check_repair $1 "$structure" | uniq | sed -e '/^error following ag 0 unlinked list$/d' \ -e '/^bad agbno AGBNO for finobt/d' \ -e '/^bad agbno AGBNO for rmapbt/d' \ diff --git a/tests/xfs/030.out.irix b/tests/xfs/030.out.irix index 6378c73..56adfd0 100644 --- a/tests/xfs/030.out.irix +++ b/tests/xfs/030.out.irix @@ -263,9 +263,6 @@ Phase 1 - find and verify superblock... Phase 2 - zero log... - scan filesystem freespace and inode maps... bad agbno AGBNO in agfl, agno 0 -bad agbno AGBNO in agfl, agno 0 -bad agbno AGBNO in agfl, agno 0 -bad agbno AGBNO in agfl, agno 0 - found root inode chunk Phase 3 - for each AG... - scan and clear agi unlinked lists... diff --git a/tests/xfs/030.out.linux b/tests/xfs/030.out.linux index 14b9b35..722cabf 100644 --- a/tests/xfs/030.out.linux +++ b/tests/xfs/030.out.linux @@ -228,11 +228,6 @@ Phase 2 - using <TYPEOF> log - zero log... - scan filesystem freespace and inode maps... bad agbno AGBNO in agfl, agno 0 -bad agbno AGBNO in agfl, agno 0 -bad agbno AGBNO in agfl, agno 0 -bad agbno AGBNO in agfl, agno 0 -bad agbno AGBNO in agfl, agno 0 -bad agbno AGBNO in agfl, agno 0 - found root inode chunk Phase 3 - for each AG... - scan and clear agi unlinked lists... -- 2.5.5
WARNING: multiple messages have this Message-ID (diff)
From: Eryu Guan <eguan@redhat.com> To: fstests@vger.kernel.org Cc: darrick.wong@oracle.com, Eryu Guan <eguan@redhat.com>, xfs@oss.sgi.com Subject: [PATCH v2] xfs/030: filter out repeated lines from .out files Date: Thu, 31 Mar 2016 14:11:22 +0800 [thread overview] Message-ID: <1459404682-12282-1-git-send-email-eguan@redhat.com> (raw) In-Reply-To: <1459331861-15025-1-git-send-email-eguan@redhat.com> Commit 31f48569c353 ("xfs/030: fix output on newer filesystems") added more lines to .out file to match the output from XFS with reflink support, but it broke test on older XFS. Dave explained the reason and pointed out the correct way to fix it, so I just quote Dave's mail here: "The problem here is that reflink triggers a change in the initial population of the AGFL - from 4 blocks to 6 blocks, and so repair warns 6 times instead of 4. After filtering, that gives 6 indentical output lines instead of 4. Doing something as simple as collapsing repeated identical lines (e.g filtering through uniq) will work for all filesystem formats and any future changes that modify the initial AGFL population." Suggested-by: Dave Chinner <dchinner@redhat.com> Signed-off-by: Eryu Guan <eguan@redhat.com> --- tests/xfs/030 | 2 +- tests/xfs/030.out.irix | 3 --- tests/xfs/030.out.linux | 5 ----- 3 files changed, 1 insertion(+), 9 deletions(-) diff --git a/tests/xfs/030 b/tests/xfs/030 index 33c906c..5c99d9e 100755 --- a/tests/xfs/030 +++ b/tests/xfs/030 @@ -55,7 +55,7 @@ _check_ag() for structure in 'sb 0' 'agf 0' 'agi 0' 'agfl 0' do echo "Corrupting $structure - setting bits to $1" - _check_repair $1 "$structure" | + _check_repair $1 "$structure" | uniq | sed -e '/^error following ag 0 unlinked list$/d' \ -e '/^bad agbno AGBNO for finobt/d' \ -e '/^bad agbno AGBNO for rmapbt/d' \ diff --git a/tests/xfs/030.out.irix b/tests/xfs/030.out.irix index 6378c73..56adfd0 100644 --- a/tests/xfs/030.out.irix +++ b/tests/xfs/030.out.irix @@ -263,9 +263,6 @@ Phase 1 - find and verify superblock... Phase 2 - zero log... - scan filesystem freespace and inode maps... bad agbno AGBNO in agfl, agno 0 -bad agbno AGBNO in agfl, agno 0 -bad agbno AGBNO in agfl, agno 0 -bad agbno AGBNO in agfl, agno 0 - found root inode chunk Phase 3 - for each AG... - scan and clear agi unlinked lists... diff --git a/tests/xfs/030.out.linux b/tests/xfs/030.out.linux index 14b9b35..722cabf 100644 --- a/tests/xfs/030.out.linux +++ b/tests/xfs/030.out.linux @@ -228,11 +228,6 @@ Phase 2 - using <TYPEOF> log - zero log... - scan filesystem freespace and inode maps... bad agbno AGBNO in agfl, agno 0 -bad agbno AGBNO in agfl, agno 0 -bad agbno AGBNO in agfl, agno 0 -bad agbno AGBNO in agfl, agno 0 -bad agbno AGBNO in agfl, agno 0 -bad agbno AGBNO in agfl, agno 0 - found root inode chunk Phase 3 - for each AG... - scan and clear agi unlinked lists... -- 2.5.5 _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-03-31 6:11 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-03-30 9:57 [PATCH] xfs/030: link .out file according to reflink support status Eryu Guan 2016-03-30 9:57 ` Eryu Guan 2016-03-30 17:24 ` Darrick J. Wong 2016-03-30 17:24 ` Darrick J. Wong 2016-03-31 4:26 ` Dave Chinner 2016-03-31 4:26 ` Dave Chinner 2016-03-31 5:56 ` Eryu Guan 2016-03-31 5:56 ` Eryu Guan 2016-03-31 6:11 ` Eryu Guan [this message] 2016-03-31 6:11 ` [PATCH v2] xfs/030: filter out repeated lines from .out files Eryu Guan 2016-03-31 7:05 ` Christoph Hellwig 2016-03-31 7:05 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1459404682-12282-1-git-send-email-eguan@redhat.com \ --to=eguan@redhat.com \ --cc=darrick.wong@oracle.com \ --cc=fstests@vger.kernel.org \ --cc=xfs@oss.sgi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.