From: Aniroop Mathur <a.mathur@samsung.com>
To: dmitry.torokhov@gmail.com
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
aniroop.mathur@gmail.com, Aniroop Mathur <a.mathur@samsung.com>
Subject: [PATCH] Input: Do not add SYN_REPORT in between a single packet data
Date: Mon, 4 Apr 2016 22:59:14 +0530 [thread overview]
Message-ID: <1459790954-7428-1-git-send-email-a.mathur@samsung.com> (raw)
In-Reply-To: <CADYu309K20ki1oMMTGmGQ+CmftCELoSFZfv704YZ_hzmzQG1kQ@mail.gmail.com>
As mentioned in documentation, SYN_REPORT should be used to separate two packets
and should not be inserted in between a single packet as otherwise with multiple
SYN_REPORT in a single packet, input reader would not be able to know when the
packet ended really.
Documentation snippet:
* SYN_REPORT:
- Used to synchronize and separate events into packets of input data changes
occurring at the same moment in time. For example, motion of a mouse may set
the REL_X and REL_Y values for one motion, then emit a SYN_REPORT. The next
motion will emit more REL_X and REL_Y values and send another SYN_REPORT.
Signed-off-by: Aniroop Mathur <a.mathur@samsung.com>
---
drivers/input/input.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/input/input.c b/drivers/input/input.c
index 8806059..799941c 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
@@ -401,12 +401,11 @@ static void input_handle_event(struct input_dev *dev,
if (dev->num_vals >= 2)
input_pass_values(dev, dev->vals, dev->num_vals);
dev->num_vals = 0;
- } else if (dev->num_vals >= dev->max_vals - 2) {
- dev->vals[dev->num_vals++] = input_value_sync;
- input_pass_values(dev, dev->vals, dev->num_vals);
+ } else if (dev->num_vals == dev->max_vals) {
+ input_pass_values(dev, dev->vals, dev->num_vals - 1);
dev->num_vals = 0;
+ dev->vals[dev->num_vals++] = dev->vals[dev->max_vals - 1];
}
-
}
/**
--
2.6.2
next prev parent reply other threads:[~2016-04-04 17:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 17:44 [PATCH] Input: Do not add SYN_REPORT in between a single packet data Aniroop Mathur
2016-03-09 18:53 ` Aniroop Mathur
2016-03-09 19:07 ` Dmitry Torokhov
2016-03-10 13:45 ` Henrik Rydberg
2016-03-10 18:56 ` Aniroop Mathur
2016-03-16 18:24 ` Aniroop Mathur
2016-03-23 19:35 ` Aniroop Mathur
2016-03-30 17:16 ` Aniroop Mathur
2016-04-01 21:51 ` Dmitry Torokhov
2016-04-02 17:01 ` Aniroop Mathur
2016-04-04 17:29 ` Aniroop Mathur [this message]
2016-04-06 14:56 ` Aniroop Mathur
2016-04-06 17:38 ` Dmitry Torokhov
2016-04-06 19:09 ` Aniroop Mathur
2016-04-06 19:51 ` Henrik Rydberg
2016-04-06 20:43 ` Aniroop Mathur
2016-04-27 14:59 ` Aniroop Mathur
2016-05-04 15:42 Aniroop Mathur
2016-05-11 14:10 ` Aniroop Mathur
[not found] ` <CADYu308HQxPfq-C3ccS_n-=DO0xFdK9vr5XmyAx3kWeryKFfyA@mail.gmail.com>
[not found] ` <20160512223159.GA12463@dtor-ws>
[not found] ` <CADYu3093GqD6vNSq083uP85HmphKGxJ6wmrNN6AhoEnjZVPqqA@mail.gmail.com>
2016-06-02 20:22 ` Aniroop Mathur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459790954-7428-1-git-send-email-a.mathur@samsung.com \
--to=a.mathur@samsung.com \
--cc=aniroop.mathur@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.