All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org
Cc: boris.ostrovsky@oracle.com, david.vrabel@citrix.com,
	mingo@redhat.com, peterz@infradead.org,
	Douglas_Warzecha@dell.com, pali.rohar@gmail.com,
	jdelvare@suse.com, linux@roeck-us.net, tglx@linutronix.de,
	hpa@zytor.com, jeremy@goop.org, chrisw@sous-sol.org,
	akataria@vmware.com, rusty@rustcorp.com.au,
	virtualization@lists.linux-foundation.org, x86@kernel.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v5 3/6] smp: add function to execute a function synchronously on a cpu
Date: Wed,  6 Apr 2016 16:17:43 +0200	[thread overview]
Message-ID: <1459952266-3687-4-git-send-email-jgross@suse.com> (raw)
In-Reply-To: <1459952266-3687-1-git-send-email-jgross@suse.com>

On some hardware models (e.g. Dell Studio 1555 laptop) some hardware
related functions (e.g. SMIs) are to be executed on physical cpu 0
only. Instead of open coding such a functionality multiple times in
the kernel add a service function for this purpose. This will enable
the possibility to take special measures in virtualized environments
like Xen, too.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V5: rename and reshuffle parameters of smp_call_on_cpu() as requested by
    Peter Zijlstra
    test target cpu to be online as requested by Peter Zijlstra

V4: change return value in case of illegal cpu as requested by Peter Zijlstra
    make pinning of vcpu an option as suggested by Peter Zijlstra

V2: instead of manipulating the allowed set of cpus use cpu specific
    workqueue as requested by Peter Zijlstra
---
 include/linux/smp.h |  3 +++
 kernel/smp.c        | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++
 kernel/up.c         | 17 +++++++++++++++++
 3 files changed, 70 insertions(+)

diff --git a/include/linux/smp.h b/include/linux/smp.h
index c441407..4f1c475 100644
--- a/include/linux/smp.h
+++ b/include/linux/smp.h
@@ -196,4 +196,7 @@ extern void arch_enable_nonboot_cpus_end(void);
 
 void smp_setup_processor_id(void);
 
+int smp_call_on_cpu(unsigned int cpu, int (*func)(void *), void *par,
+		    bool phys);
+
 #endif /* __LINUX_SMP_H */
diff --git a/kernel/smp.c b/kernel/smp.c
index 9388064..f671948 100644
--- a/kernel/smp.c
+++ b/kernel/smp.c
@@ -740,3 +740,53 @@ void wake_up_all_idle_cpus(void)
 	preempt_enable();
 }
 EXPORT_SYMBOL_GPL(wake_up_all_idle_cpus);
+
+/**
+ * smp_call_on_cpu - Call a function on a specific cpu
+ *
+ * Used to call a function on a specific cpu and wait for it to return.
+ * Optionally make sure the call is done on a specified physical cpu via vcpu
+ * pinning in order to support virtualized environments.
+ */
+struct smp_call_on_cpu_struct {
+	struct work_struct	work;
+	struct completion	done;
+	int			(*func)(void *);
+	void			*data;
+	int			ret;
+	int			cpu;
+};
+
+static void smp_call_on_cpu_callback(struct work_struct *work)
+{
+	struct smp_call_on_cpu_struct *sscs;
+
+	sscs = container_of(work, struct smp_call_on_cpu_struct, work);
+	if (sscs->cpu >= 0)
+		hypervisor_pin_vcpu(sscs->cpu);
+	sscs->ret = sscs->func(sscs->data);
+	if (sscs->cpu >= 0)
+		hypervisor_pin_vcpu(-1);
+
+	complete(&sscs->done);
+}
+
+int smp_call_on_cpu(unsigned int cpu, int (*func)(void *), void *par, bool phys)
+{
+	struct smp_call_on_cpu_struct sscs = {
+		.work = __WORK_INITIALIZER(sscs.work, smp_call_on_cpu_callback),
+		.done = COMPLETION_INITIALIZER_ONSTACK(sscs.done),
+		.func = func,
+		.data = par,
+		.cpu  = phys ? cpu : -1,
+	};
+
+	if (cpu >= nr_cpu_ids || !cpu_online(cpu))
+		return -ENXIO;
+
+	queue_work_on(cpu, system_wq, &sscs.work);
+	wait_for_completion(&sscs.done);
+
+	return sscs.ret;
+}
+EXPORT_SYMBOL_GPL(smp_call_on_cpu);
diff --git a/kernel/up.c b/kernel/up.c
index 3ccee2b..ee81ac9 100644
--- a/kernel/up.c
+++ b/kernel/up.c
@@ -83,3 +83,20 @@ void on_each_cpu_cond(bool (*cond_func)(int cpu, void *info),
 	preempt_enable();
 }
 EXPORT_SYMBOL(on_each_cpu_cond);
+
+int smp_call_on_cpu(unsigned int cpu, int (*func)(void *), void *par, bool phys)
+{
+	int ret;
+
+	if (cpu != 0)
+		return -ENXIO;
+
+	if (phys)
+		hypervisor_pin_vcpu(0);
+	ret = func(par);
+	if (phys)
+		hypervisor_pin_vcpu(-1);
+
+	return ret;
+}
+EXPORT_SYMBOL_GPL(smp_call_on_cpu);
-- 
2.6.6

  parent reply	other threads:[~2016-04-06 14:17 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-06 14:17 [PATCH v5 0/6] Support calling functions on dedicated physical cpu Juergen Gross
2016-04-06 14:17 ` [PATCH v5 1/6] xen: sync xen header Juergen Gross
2016-04-06 14:17 ` Juergen Gross
2016-04-06 14:17   ` Juergen Gross
2016-04-06 14:17 ` [PATCH v5 2/6] virt, sched: add generic vcpu pinning support Juergen Gross
2016-04-06 14:17   ` Juergen Gross
2016-06-15 11:18   ` Juergen Gross
2016-06-15 11:18   ` Juergen Gross
2016-06-15 11:18   ` Juergen Gross
2016-04-06 14:17 ` Juergen Gross
2016-04-06 14:17 ` [PATCH v5 3/6] smp: add function to execute a function synchronously on a cpu Juergen Gross
2016-04-06 14:17 ` Juergen Gross [this message]
2016-04-06 18:04   ` Peter Zijlstra
2016-04-06 18:04   ` Peter Zijlstra
2016-04-06 18:04     ` Peter Zijlstra
2016-04-06 14:17 ` Juergen Gross
2016-04-06 14:17 ` [PATCH v5 4/6] xen: add xen_pin_vcpu() to support calling functions on a dedicated pcpu Juergen Gross
2016-04-06 14:17 ` Juergen Gross
2016-04-06 14:17 ` Juergen Gross
2016-04-06 14:17 ` [PATCH v5 5/6] dcdbas: make use of smp_call_on_cpu() Juergen Gross
2016-04-06 14:17 ` Juergen Gross
2016-04-06 14:17   ` Juergen Gross
2016-06-15 11:19   ` Juergen Gross
2016-06-15 11:19   ` Juergen Gross
2016-06-15 11:19   ` Juergen Gross
2016-04-06 14:17 ` [PATCH v5 6/6] hwmon: use smp_call_on_cpu() for dell-smm i8k Juergen Gross
2016-04-06 14:17 ` Juergen Gross
2016-04-06 14:17   ` Juergen Gross
2016-06-13 19:05   ` Pali Rohár
2016-06-13 19:05   ` Pali Rohár
2016-06-13 19:05     ` Pali Rohár
2016-04-13  8:49 ` [PATCH v5 0/6] Support calling functions on dedicated physical cpu Juergen Gross
2016-04-13  8:49   ` Juergen Gross
2016-05-17 11:21   ` Juergen Gross
2016-05-17 11:21   ` Juergen Gross
2016-05-17 11:21   ` Juergen Gross
2016-04-13  8:49 ` Juergen Gross
2016-06-20  8:40 ` Juergen Gross
2016-06-20  8:40   ` Juergen Gross
2016-06-20  8:40 ` Juergen Gross
2016-06-27 10:34 ` Juergen Gross
2016-06-27 10:34 ` Juergen Gross
2016-06-27 10:34   ` Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459952266-3687-4-git-send-email-jgross@suse.com \
    --to=jgross@suse.com \
    --cc=Douglas_Warzecha@dell.com \
    --cc=akataria@vmware.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=chrisw@sous-sol.org \
    --cc=david.vrabel@citrix.com \
    --cc=hpa@zytor.com \
    --cc=jdelvare@suse.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mingo@redhat.com \
    --cc=pali.rohar@gmail.com \
    --cc=peterz@infradead.org \
    --cc=rusty@rustcorp.com.au \
    --cc=tglx@linutronix.de \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.