From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, jsnow@redhat.com,
Anthony PERARD <anthony.perard@citrix.com>
Subject: [Qemu-devel] [PULL 1/4] xen: Fix IDE unplug
Date: Tue, 12 Apr 2016 19:36:11 -0400 [thread overview]
Message-ID: <1460504174-6905-2-git-send-email-jsnow@redhat.com> (raw)
In-Reply-To: <1460504174-6905-1-git-send-email-jsnow@redhat.com>
From: Anthony PERARD <anthony.perard@citrix.com>
After commit e5e7855 (blockdev: Separate BB name management), starting a
guest with PVHVM support result in this assert:
qemu-system-i386: block/block-backend.c:173: blk_delete: Assertion `!blk->name' failed.
A backtrace show that a caller is pci_piix3_xen_ide_unplug().
This patch fix it.
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Message-id: 1460382666-29885-1-git-send-email-anthony.perard@citrix.com
Signed-off-by: John Snow <jsnow@redhat.com>
---
hw/ide/piix.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ide/piix.c b/hw/ide/piix.c
index 0a4cbcb..6d76ce9 100644
--- a/hw/ide/piix.c
+++ b/hw/ide/piix.c
@@ -189,6 +189,7 @@ int pci_piix3_xen_ide_unplug(DeviceState *dev)
idedev = pci_ide->bus[di->bus].slave;
}
idedev->conf.blk = NULL;
+ monitor_remove_blk(blk);
blk_unref(blk);
}
}
--
2.4.11
next prev parent reply other threads:[~2016-04-12 23:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 23:36 [Qemu-devel] [PULL 0/4] Ide patches John Snow
2016-04-12 23:36 ` John Snow [this message]
2016-04-12 23:36 ` [Qemu-devel] [PULL 2/4] ide: don't lose pending dma state John Snow
2016-04-12 23:36 ` [Qemu-devel] [PULL 3/4] ide: restart atapi dma by re-evaluating command packet John Snow
2016-04-12 23:36 ` [Qemu-devel] [PULL 4/4] ide: really restart pending and in-flight atapi dma John Snow
2016-04-13 17:48 ` [Qemu-devel] [PULL 0/4] Ide patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460504174-6905-2-git-send-email-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.