All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@poochiereds.net>
To: trond.myklebust@primarydata.com
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 4/8] sunrpc: add a get_rpccred_rcu inline
Date: Thu, 14 Apr 2016 08:37:01 -0400	[thread overview]
Message-ID: <1460637425-1580-5-git-send-email-jeff.layton@primarydata.com> (raw)
In-Reply-To: <1460637425-1580-1-git-send-email-jeff.layton@primarydata.com>

Sometimes we might have a RCU managed credential pointer and don't want
to use locking to handle it. Add a function that will take a reference
to the cred iff the refcount is not already zero. Callers can dereference
the pointer under the rcu_read_lock and use that function to take a
reference only if the cred is not on its way to destruction.

Signed-off-by: Jeff Layton <jeff.layton@primarydata.com>
---
 include/linux/sunrpc/auth.h | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/include/linux/sunrpc/auth.h b/include/linux/sunrpc/auth.h
index 16bd8f8fef8c..6f36b2bf3e05 100644
--- a/include/linux/sunrpc/auth.h
+++ b/include/linux/sunrpc/auth.h
@@ -206,5 +206,23 @@ struct rpc_cred *	get_rpccred(struct rpc_cred *cred)
 	return cred;
 }
 
+/**
+ * get_rpccred_rcu - get a reference to a cred using rcu-protected pointer
+ * @cred: cred of which to take a reference
+ *
+ * In some cases, we may have a pointer to a credential to which we
+ * want to take a reference, but don't already have one. Because these
+ * objects are freed using RCU, we can access the cr_count while its
+ * on its way to destruction and only take a reference if it's not already
+ * zero.
+ */
+static inline struct rpc_cred *
+get_rpccred_rcu(struct rpc_cred *cred)
+{
+	if (atomic_inc_not_zero(&cred->cr_count))
+		return cred;
+	return NULL;
+}
+
 #endif /* __KERNEL__ */
 #endif /* _LINUX_SUNRPC_AUTH_H */
-- 
2.5.5


  parent reply	other threads:[~2016-04-14 12:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-14 12:36 [PATCH 0/8] nfs/sunrpc: fix flexfiles credential handling Jeff Layton
2016-04-14 12:36 ` [PATCH 1/8] sunrpc: allow generic_match to handle creds with NULL group_info ptr Jeff Layton
2016-04-14 12:36 ` [PATCH 2/8] sunrpc: plumb gfp_t parm into crcreate operation Jeff Layton
2016-04-14 12:37 ` [PATCH 3/8] sunrpc: add rpc_lookup_generic_cred Jeff Layton
2016-04-14 12:37 ` Jeff Layton [this message]
2016-04-14 12:37 ` [PATCH 5/8] nfs: don't call nfs4_ff_layout_prepare_ds from ff_layout_get_ds_cred Jeff Layton
2016-04-14 12:37 ` [PATCH 6/8] nfs: have ff_layout_get_ds_cred take a reference to the cred Jeff Layton
2016-04-14 14:29   ` Jeff Layton
2016-04-14 12:37 ` [PATCH 7/8] nfs: get a reference to the credential in ff_layout_alloc_lseg Jeff Layton
2016-04-14 12:37 ` [PATCH 8/8] nfs: have flexfiles mirror keep creds for both ro and rw layouts Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1460637425-1580-5-git-send-email-jeff.layton@primarydata.com \
    --to=jlayton@poochiereds.net \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.