All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: fstests@vger.kernel.org
Cc: Jan Kara <jack@suse.cz>
Subject: [PATCH 3/5] generic/344: Test races between mmap and normal write for prefaulted ranges
Date: Mon, 18 Apr 2016 21:32:33 +0200	[thread overview]
Message-ID: <1461007955-7921-4-git-send-email-jack@suse.cz> (raw)
In-Reply-To: <1461007955-7921-1-git-send-email-jack@suse.cz>

Add test which spawns two threads both writing one file via mmap which
has been previously prefaulted by reading. Do the same test when one
thread accesses the file via mmap and the other one via normal write.
This is mainly interesting to uncover races in DAX fault handling and
between DAX fault handling and write path.

Signed-off-by: Jan Kara <jack@suse.cz>
---
 src/holetest.c        | 19 ++++++++++++--
 tests/generic/344     | 60 ++++++++++++++++++++++++++++++++++++++++++
 tests/generic/344.out | 73 +++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/generic/group   |  1 +
 4 files changed, 151 insertions(+), 2 deletions(-)
 create mode 100644 tests/generic/344
 create mode 100644 tests/generic/344.out

diff --git a/src/holetest.c b/src/holetest.c
index 6f23110b3769..252fe734523e 100644
--- a/src/holetest.c
+++ b/src/holetest.c
@@ -67,6 +67,7 @@
 long page_size;
 long page_offs[THREADS];
 int use_wr[THREADS];
+int prefault = 0;
 
 void *pt_page_marker(void *args)
 {
@@ -122,6 +123,16 @@ int test_this(int fd, loff_t sz)
 		exit(20);
 	}
 
+	if (prefault) {
+		for (i = 0; i < npages; i++) {
+			if (vastart[i * page_size] != 0) {
+				fprintf(stderr, "Prefaulting found non-zero "
+					"value in page %d: %d\n", i,
+					vastart[i * page_size]);
+			}
+		}
+	}
+
 	/* prepare the thread args */
 	for (i = 0; i < THREADS; i++) {
 		targs[i][0] = (void *)(long)fd;
@@ -185,7 +196,7 @@ int main(int argc, char **argv)
 	for (i = 1; i < THREADS; i++)
 		page_offs[i] = page_offs[i-1] + step;
 
-	while ((opt = getopt(argc, argv, "fw")) > 0) {
+	while ((opt = getopt(argc, argv, "fwr")) > 0) {
 		switch (opt) {
 		case 'f':
 			/* ignore errors */
@@ -195,6 +206,10 @@ int main(int argc, char **argv)
 			/* use writes instead of mmap for one thread */
 			use_wr[0] = 1;
 			break;
+		case 'r':
+			/* prefault mmapped area by reading it */
+			prefault = 1;
+			break;
 		default:
 			fprintf(stderr, "ERROR: Unknown option character.\n");
 			exit(1);
@@ -202,7 +217,7 @@ int main(int argc, char **argv)
 	}
 
 	if (optind != argc - 2) {
-		fprintf(stderr, "ERROR: usage: holetest [-fw] "
+		fprintf(stderr, "ERROR: usage: holetest [-fwr] "
 			"FILENAME FILESIZEinMB\n");
 		exit(1);
 	}
diff --git a/tests/generic/344 b/tests/generic/344
new file mode 100644
index 000000000000..1c10a955c8e6
--- /dev/null
+++ b/tests/generic/344
@@ -0,0 +1,60 @@
+#! /bin/bash
+# FSQA Test No. 344
+#
+# Test races between mmap from racing threads when pages are prefaulted,
+# Test races between mmap and buffered writes when pages are prefaulted.
+#
+#-----------------------------------------------------------------------
+#
+# Copyright (C) 2016 SUSE Linux Products GmbH. All Rights Reserved.
+# Author: Jan Kara <jack@suse.cz>
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#-----------------------------------------------------------------------
+#
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+tmp=/tmp/$$
+status=1	# failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+	cd /
+	rm -f $tmp.*
+}
+
+# get standard environment and checks
+. ./common/rc
+
+# real QA test starts here
+_supported_fs generic
+_supported_os Linux
+_require_scratch
+_require_test_program "holetest"
+
+rm -f $seqres.full
+
+_scratch_mkfs >>$seqres.full 2>&1
+_scratch_mount
+
+src/holetest -f -r $SCRATCH_MNT/testfile 16
+src/holetest -f -r $SCRATCH_MNT/testfile 256
+src/holetest -f -r -w $SCRATCH_MNT/testfile 16
+src/holetest -f -r -w $SCRATCH_MNT/testfile 256
+
+status=0
+exit
diff --git a/tests/generic/344.out b/tests/generic/344.out
new file mode 100644
index 000000000000..3ae5e5b373d9
--- /dev/null
+++ b/tests/generic/344.out
@@ -0,0 +1,73 @@
+QA output created by 344
+
+INFO: zero-filled test...
+INFO: sz = 16777216
+INFO: thread 0 created
+INFO: thread 1 created
+INFO: 0 error(s) detected
+
+INFO: posix_fallocate test...
+INFO: sz = 16777216
+INFO: thread 0 created
+INFO: thread 1 created
+INFO: 0 error(s) detected
+
+INFO: ftruncate test...
+INFO: sz = 16777216
+INFO: thread 0 created
+INFO: thread 1 created
+INFO: 0 error(s) detected
+
+INFO: zero-filled test...
+INFO: sz = 268435456
+INFO: thread 0 created
+INFO: thread 1 created
+INFO: 0 error(s) detected
+
+INFO: posix_fallocate test...
+INFO: sz = 268435456
+INFO: thread 0 created
+INFO: thread 1 created
+INFO: 0 error(s) detected
+
+INFO: ftruncate test...
+INFO: sz = 268435456
+INFO: thread 0 created
+INFO: thread 1 created
+INFO: 0 error(s) detected
+
+INFO: zero-filled test...
+INFO: sz = 16777216
+INFO: thread 0 created
+INFO: thread 1 created
+INFO: 0 error(s) detected
+
+INFO: posix_fallocate test...
+INFO: sz = 16777216
+INFO: thread 0 created
+INFO: thread 1 created
+INFO: 0 error(s) detected
+
+INFO: ftruncate test...
+INFO: sz = 16777216
+INFO: thread 0 created
+INFO: thread 1 created
+INFO: 0 error(s) detected
+
+INFO: zero-filled test...
+INFO: sz = 268435456
+INFO: thread 0 created
+INFO: thread 1 created
+INFO: 0 error(s) detected
+
+INFO: posix_fallocate test...
+INFO: sz = 268435456
+INFO: thread 0 created
+INFO: thread 1 created
+INFO: 0 error(s) detected
+
+INFO: ftruncate test...
+INFO: sz = 268435456
+INFO: thread 0 created
+INFO: thread 1 created
+INFO: 0 error(s) detected
diff --git a/tests/generic/group b/tests/generic/group
index 05b0448d64f4..e58d36085585 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -346,3 +346,4 @@
 341 auto quick metadata
 342 auto quick metadata
 343 auto
+344 auto
-- 
2.6.6


  parent reply	other threads:[~2016-04-18 19:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-18 19:32 [PATCH 1/5] More page fault stress tests and generic/038 fix Jan Kara
2016-04-18 19:32 ` [PATCH 1/5] generic/340: Remove second fallocate test Jan Kara
2016-04-18 19:32 ` [PATCH 2/5] generic/343: Test races between mmap and normal writes Jan Kara
2016-04-27 15:04   ` Brian Foster
2016-04-27 16:16     ` Jan Kara
2016-04-27 16:19       ` Jan Kara
2016-04-18 19:32 ` Jan Kara [this message]
2016-04-18 19:32 ` [PATCH 4/5] generic/345: Test races between processes doing mmap writes Jan Kara
2016-04-18 19:32 ` [PATCH 5/5] generic/038: Avoid EBUSY errors on umount Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461007955-7921-4-git-send-email-jack@suse.cz \
    --to=jack@suse.cz \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.