From: Alexander Aring <aar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> To: linux-wpan-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org, jukka.rissanen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, hannes-tFNcAqjVMyqKXQKiL6tip0B+6BGkLq7r@public.gmane.org, stefan-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org, mcr-SWp7JaYWvAQV+D8aMU/kSg@public.gmane.org, werner-SEdMjqphH88wryQfseakQg@public.gmane.org, linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alexander Aring <aar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>, "David S . Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>, Alexey Kuznetsov <kuznet-v/Mj1YrvjDBInbfyfbPRSQ@public.gmane.org>, James Morris <jmorris-gx6/JNMH7DfYtjvyW6yDsg@public.gmane.org>, Hideaki YOSHIFUJI <yoshfuji-VfPWfsRibaP+Ru+s062T9g@public.gmane.org>, Patrick McHardy <kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org> Subject: [PATCHv2 bluetooth-next 05/10] ndisc: add addr_len parameter to ndisc_opt_addr_data Date: Wed, 20 Apr 2016 10:19:37 +0200 [thread overview] Message-ID: <1461140382-4784-6-git-send-email-aar@pengutronix.de> (raw) In-Reply-To: <1461140382-4784-1-git-send-email-aar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> This patch makes the address length as argument for the ndisc_opt_addr_data function. This is necessary to handle addresses which don't use dev->addr_len as address length. Cc: David S. Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> Cc: Alexey Kuznetsov <kuznet-v/Mj1YrvjDBInbfyfbPRSQ@public.gmane.org> Cc: James Morris <jmorris-gx6/JNMH7DfYtjvyW6yDsg@public.gmane.org> Cc: Hideaki YOSHIFUJI <yoshfuji-VfPWfsRibaP+Ru+s062T9g@public.gmane.org> Cc: Patrick McHardy <kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org> Signed-off-by: Alexander Aring <aar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> --- include/net/ndisc.h | 5 +++-- net/ipv6/ndisc.c | 11 +++++++---- net/ipv6/route.c | 2 +- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/include/net/ndisc.h b/include/net/ndisc.h index ef43e88..aac868e 100644 --- a/include/net/ndisc.h +++ b/include/net/ndisc.h @@ -134,12 +134,13 @@ static inline int ndisc_opt_addr_space(struct net_device *dev, } static inline u8 *ndisc_opt_addr_data(struct nd_opt_hdr *p, - struct net_device *dev) + struct net_device *dev, + unsigned char addr_len) { u8 *lladdr = (u8 *)(p + 1); int lladdrlen = p->nd_opt_len << 3; int prepad = ndisc_addr_option_pad(dev->type); - if (lladdrlen != ndisc_opt_addr_space(dev, dev->addr_len)) + if (lladdrlen != ndisc_opt_addr_space(dev, addr_len)) return NULL; return lladdr + prepad; } diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c index 69e20e3..4e91d5e 100644 --- a/net/ipv6/ndisc.c +++ b/net/ipv6/ndisc.c @@ -744,7 +744,8 @@ static void ndisc_recv_ns(struct sk_buff *skb) } if (ndopts.nd_opts_src_lladdr) { - lladdr = ndisc_opt_addr_data(ndopts.nd_opts_src_lladdr, dev); + lladdr = ndisc_opt_addr_data(ndopts.nd_opts_src_lladdr, dev, + dev->addr_len); if (!lladdr) { ND_PRINTK(2, warn, "NS: invalid link-layer address length\n"); @@ -916,7 +917,8 @@ static void ndisc_recv_na(struct sk_buff *skb) return; } if (ndopts.nd_opts_tgt_lladdr) { - lladdr = ndisc_opt_addr_data(ndopts.nd_opts_tgt_lladdr, dev); + lladdr = ndisc_opt_addr_data(ndopts.nd_opts_tgt_lladdr, dev, + dev->addr_len); if (!lladdr) { ND_PRINTK(2, warn, "NA: invalid link-layer address length\n"); @@ -1024,7 +1026,7 @@ static void ndisc_recv_rs(struct sk_buff *skb) if (ndopts.nd_opts_src_lladdr) { lladdr = ndisc_opt_addr_data(ndopts.nd_opts_src_lladdr, - skb->dev); + skb->dev, skb->dev->addr_len); if (!lladdr) goto out; } @@ -1322,7 +1324,8 @@ skip_linkparms: u8 *lladdr = NULL; if (ndopts.nd_opts_src_lladdr) { lladdr = ndisc_opt_addr_data(ndopts.nd_opts_src_lladdr, - skb->dev); + skb->dev, + skb->dev->addr_len); if (!lladdr) { ND_PRINTK(2, warn, "RA: invalid link-layer address length\n"); diff --git a/net/ipv6/route.c b/net/ipv6/route.c index ed44663..cc180b3 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -2157,7 +2157,7 @@ static void rt6_do_redirect(struct dst_entry *dst, struct sock *sk, struct sk_bu lladdr = NULL; if (ndopts.nd_opts_tgt_lladdr) { lladdr = ndisc_opt_addr_data(ndopts.nd_opts_tgt_lladdr, - skb->dev); + skb->dev, skb->dev->addr_len); if (!lladdr) { net_dbg_ratelimited("rt6_redirect: invalid link-layer address length\n"); return; -- 2.8.0
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Aring <aar@pengutronix.de> To: linux-wpan@vger.kernel.org Cc: kernel@pengutronix.de, marcel@holtmann.org, jukka.rissanen@linux.intel.com, hannes@stressinduktion.org, stefan@osg.samsung.com, mcr@sandelman.ca, werner@almesberger.net, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, Alexander Aring <aar@pengutronix.de>, "David S . Miller" <davem@davemloft.net>, Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>, James Morris <jmorris@namei.org>, Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>, Patrick McHardy <kaber@trash.net> Subject: [PATCHv2 bluetooth-next 05/10] ndisc: add addr_len parameter to ndisc_opt_addr_data Date: Wed, 20 Apr 2016 10:19:37 +0200 [thread overview] Message-ID: <1461140382-4784-6-git-send-email-aar@pengutronix.de> (raw) In-Reply-To: <1461140382-4784-1-git-send-email-aar@pengutronix.de> This patch makes the address length as argument for the ndisc_opt_addr_data function. This is necessary to handle addresses which don't use dev->addr_len as address length. Cc: David S. Miller <davem@davemloft.net> Cc: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru> Cc: James Morris <jmorris@namei.org> Cc: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org> Cc: Patrick McHardy <kaber@trash.net> Signed-off-by: Alexander Aring <aar@pengutronix.de> --- include/net/ndisc.h | 5 +++-- net/ipv6/ndisc.c | 11 +++++++---- net/ipv6/route.c | 2 +- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/include/net/ndisc.h b/include/net/ndisc.h index ef43e88..aac868e 100644 --- a/include/net/ndisc.h +++ b/include/net/ndisc.h @@ -134,12 +134,13 @@ static inline int ndisc_opt_addr_space(struct net_device *dev, } static inline u8 *ndisc_opt_addr_data(struct nd_opt_hdr *p, - struct net_device *dev) + struct net_device *dev, + unsigned char addr_len) { u8 *lladdr = (u8 *)(p + 1); int lladdrlen = p->nd_opt_len << 3; int prepad = ndisc_addr_option_pad(dev->type); - if (lladdrlen != ndisc_opt_addr_space(dev, dev->addr_len)) + if (lladdrlen != ndisc_opt_addr_space(dev, addr_len)) return NULL; return lladdr + prepad; } diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c index 69e20e3..4e91d5e 100644 --- a/net/ipv6/ndisc.c +++ b/net/ipv6/ndisc.c @@ -744,7 +744,8 @@ static void ndisc_recv_ns(struct sk_buff *skb) } if (ndopts.nd_opts_src_lladdr) { - lladdr = ndisc_opt_addr_data(ndopts.nd_opts_src_lladdr, dev); + lladdr = ndisc_opt_addr_data(ndopts.nd_opts_src_lladdr, dev, + dev->addr_len); if (!lladdr) { ND_PRINTK(2, warn, "NS: invalid link-layer address length\n"); @@ -916,7 +917,8 @@ static void ndisc_recv_na(struct sk_buff *skb) return; } if (ndopts.nd_opts_tgt_lladdr) { - lladdr = ndisc_opt_addr_data(ndopts.nd_opts_tgt_lladdr, dev); + lladdr = ndisc_opt_addr_data(ndopts.nd_opts_tgt_lladdr, dev, + dev->addr_len); if (!lladdr) { ND_PRINTK(2, warn, "NA: invalid link-layer address length\n"); @@ -1024,7 +1026,7 @@ static void ndisc_recv_rs(struct sk_buff *skb) if (ndopts.nd_opts_src_lladdr) { lladdr = ndisc_opt_addr_data(ndopts.nd_opts_src_lladdr, - skb->dev); + skb->dev, skb->dev->addr_len); if (!lladdr) goto out; } @@ -1322,7 +1324,8 @@ skip_linkparms: u8 *lladdr = NULL; if (ndopts.nd_opts_src_lladdr) { lladdr = ndisc_opt_addr_data(ndopts.nd_opts_src_lladdr, - skb->dev); + skb->dev, + skb->dev->addr_len); if (!lladdr) { ND_PRINTK(2, warn, "RA: invalid link-layer address length\n"); diff --git a/net/ipv6/route.c b/net/ipv6/route.c index ed44663..cc180b3 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -2157,7 +2157,7 @@ static void rt6_do_redirect(struct dst_entry *dst, struct sock *sk, struct sk_bu lladdr = NULL; if (ndopts.nd_opts_tgt_lladdr) { lladdr = ndisc_opt_addr_data(ndopts.nd_opts_tgt_lladdr, - skb->dev); + skb->dev, skb->dev->addr_len); if (!lladdr) { net_dbg_ratelimited("rt6_redirect: invalid link-layer address length\n"); return; -- 2.8.0
next prev parent reply other threads:[~2016-04-20 8:19 UTC|newest] Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-20 8:19 [PATCHv2 bluetooth-next 00/10] 6lowpan: introduce basic 6lowpan-nd Alexander Aring 2016-04-20 8:19 ` Alexander Aring [not found] ` <1461140382-4784-1-git-send-email-aar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2016-04-20 8:19 ` [PATCHv2 bluetooth-next 01/10] 6lowpan: add private neighbour data Alexander Aring 2016-04-20 8:19 ` Alexander Aring 2016-05-02 18:59 ` Hannes Frederic Sowa 2016-05-04 10:43 ` Alexander Aring 2016-05-03 18:16 ` Stefan Schmidt 2016-04-20 8:19 ` [PATCHv2 bluetooth-next 02/10] 6lowpan: add 802.15.4 short addr slaac Alexander Aring 2016-04-20 8:19 ` Alexander Aring 2016-05-02 19:06 ` Hannes Frederic Sowa [not found] ` <1461140382-4784-3-git-send-email-aar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2016-05-03 18:16 ` Stefan Schmidt 2016-05-03 18:16 ` Stefan Schmidt 2016-05-06 9:26 ` Alexander Aring 2016-04-20 8:19 ` [PATCHv2 bluetooth-next 03/10] 6lowpan: remove ipv6 module request Alexander Aring 2016-04-20 8:19 ` Alexander Aring 2016-05-02 19:06 ` Hannes Frederic Sowa 2016-05-03 18:16 ` Stefan Schmidt 2016-04-20 8:19 ` [PATCHv2 bluetooth-next 04/10] ndisc: add addr_len parameter to ndisc_opt_addr_space Alexander Aring 2016-04-20 8:19 ` Alexander Aring 2016-05-02 19:37 ` Hannes Frederic Sowa 2016-05-04 12:30 ` Alexander Aring [not found] ` <800c5c08-c2c8-3b44-d457-cdcf6374f280-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2016-05-06 22:23 ` Hannes Frederic Sowa 2016-05-06 22:23 ` Hannes Frederic Sowa 2016-05-08 10:39 ` Alexander Aring 2016-05-18 21:39 ` Michael Richardson 2016-05-18 21:39 ` Michael Richardson 2016-05-03 18:17 ` Stefan Schmidt 2016-04-20 8:19 ` Alexander Aring [this message] 2016-04-20 8:19 ` [PATCHv2 bluetooth-next 05/10] ndisc: add addr_len parameter to ndisc_opt_addr_data Alexander Aring 2016-05-03 18:17 ` Stefan Schmidt 2016-04-20 8:19 ` [PATCHv2 bluetooth-next 07/10] ipv6: introduce neighbour discovery ops Alexander Aring 2016-04-20 8:19 ` Alexander Aring 2016-05-02 19:36 ` Hannes Frederic Sowa [not found] ` <fbd4c25c-2673-2848-c636-a5d21a6890d7-tFNcAqjVMyqKXQKiL6tip0B+6BGkLq7r@public.gmane.org> 2016-05-03 18:17 ` Stefan Schmidt 2016-05-03 18:17 ` Stefan Schmidt [not found] ` <5728EB3F.2060808-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> 2016-05-06 9:36 ` Alexander Aring 2016-05-06 9:36 ` Alexander Aring [not found] ` <1461140382-4784-8-git-send-email-aar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2016-05-04 12:23 ` Stefan Schmidt 2016-05-04 12:23 ` Stefan Schmidt [not found] ` <5729E9AB.5000301-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> 2016-05-06 9:47 ` Alexander Aring 2016-05-06 9:47 ` Alexander Aring 2016-05-06 10:19 ` Alexander Aring 2016-04-20 8:19 ` [PATCHv2 bluetooth-next 09/10] 6lowpan: introduce 6lowpan-nd Alexander Aring 2016-04-20 8:19 ` Alexander Aring [not found] ` <1461140382-4784-10-git-send-email-aar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2016-05-04 12:23 ` Stefan Schmidt 2016-05-04 12:23 ` Stefan Schmidt 2016-05-02 17:25 ` [PATCHv2 bluetooth-next 00/10] 6lowpan: introduce basic 6lowpan-nd Marcel Holtmann 2016-05-02 17:25 ` Marcel Holtmann [not found] ` <D212A5BF-A414-403B-A409-1F8C2D279883-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org> 2016-05-02 19:52 ` Hannes Frederic Sowa 2016-05-02 19:52 ` Hannes Frederic Sowa [not found] ` <870fdf5f-82ed-b621-a8d5-625bf9d81d0d-tFNcAqjVMyqKXQKiL6tip0B+6BGkLq7r@public.gmane.org> 2016-05-02 23:17 ` Marcel Holtmann 2016-05-02 23:17 ` Marcel Holtmann [not found] ` <58926844-0338-4D63-A5B6-DB0EBE903A0E-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org> 2016-05-03 20:07 ` David Miller 2016-05-03 20:07 ` David Miller 2016-05-13 2:59 ` YOSHIFUJI Hideaki 2016-05-13 2:59 ` YOSHIFUJI Hideaki [not found] ` <57354315.2050509-GmhWrQMWH5w7YuNMryXyOw@public.gmane.org> 2016-05-13 12:33 ` Alexander Aring 2016-05-13 12:33 ` Alexander Aring 2016-04-20 8:19 ` [PATCHv2 bluetooth-next 06/10] ndisc: add addr_len parameter to ndisc_fill_addr_option Alexander Aring 2016-05-03 18:17 ` Stefan Schmidt 2016-04-20 8:19 ` [PATCHv2 bluetooth-next 08/10] ipv6: export ndisc functions Alexander Aring 2016-05-02 19:39 ` Hannes Frederic Sowa 2016-05-08 10:46 ` Alexander Aring [not found] ` <1461140382-4784-9-git-send-email-aar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2016-05-04 12:23 ` Stefan Schmidt 2016-05-04 12:23 ` Stefan Schmidt 2016-04-20 8:19 ` [PATCHv2 bluetooth-next 10/10] 6lowpan: add support for 802.15.4 short addr handling Alexander Aring [not found] ` <1461140382-4784-11-git-send-email-aar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2016-05-04 12:23 ` Stefan Schmidt 2016-05-04 12:23 ` Stefan Schmidt 2016-04-28 11:36 ` [PATCHv2 bluetooth-next 00/10] 6lowpan: introduce basic 6lowpan-nd Alexander Aring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1461140382-4784-6-git-send-email-aar@pengutronix.de \ --to=aar-bicnvbalz9megne8c9+irq@public.gmane.org \ --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \ --cc=hannes-tFNcAqjVMyqKXQKiL6tip0B+6BGkLq7r@public.gmane.org \ --cc=jmorris-gx6/JNMH7DfYtjvyW6yDsg@public.gmane.org \ --cc=jukka.rissanen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \ --cc=kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org \ --cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \ --cc=kuznet-v/Mj1YrvjDBInbfyfbPRSQ@public.gmane.org \ --cc=linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-wpan-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org \ --cc=mcr-SWp7JaYWvAQV+D8aMU/kSg@public.gmane.org \ --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=stefan-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org \ --cc=werner-SEdMjqphH88wryQfseakQg@public.gmane.org \ --cc=yoshfuji-VfPWfsRibaP+Ru+s062T9g@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.