All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Subject: [PATCH v4 08/25] drm/i915: L3 cache remapping is part of context switching
Date: Tue, 26 Apr 2016 07:54:15 +0100	[thread overview]
Message-ID: <1461653672-17335-9-git-send-email-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <1461653672-17335-1-git-send-email-chris@chris-wilson.co.uk>

Move the i915_gem_l3_remap function such that it next to the context
switching, which is where we perform the L3 remap.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 drivers/gpu/drm/i915/i915_gem.c         | 31 -------------------------------
 drivers/gpu/drm/i915/i915_gem_context.c | 31 +++++++++++++++++++++++++++++++
 2 files changed, 31 insertions(+), 31 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index f9ef11273698..f07cf81ef16b 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -4730,37 +4730,6 @@ err:
 	return ret;
 }
 
-int i915_gem_l3_remap(struct drm_i915_gem_request *req, int slice)
-{
-	struct intel_engine_cs *engine = req->engine;
-	struct drm_device *dev = engine->dev;
-	struct drm_i915_private *dev_priv = dev->dev_private;
-	u32 *remap_info = dev_priv->l3_parity.remap_info[slice];
-	int i, ret;
-
-	if (!HAS_L3_DPF(dev) || !remap_info)
-		return 0;
-
-	ret = intel_ring_begin(req, GEN7_L3LOG_SIZE / 4 * 3);
-	if (ret)
-		return ret;
-
-	/*
-	 * Note: We do not worry about the concurrent register cacheline hang
-	 * here because no other code should access these registers other than
-	 * at initialization time.
-	 */
-	for (i = 0; i < GEN7_L3LOG_SIZE / 4; i++) {
-		intel_ring_emit(engine, MI_LOAD_REGISTER_IMM(1));
-		intel_ring_emit_reg(engine, GEN7_L3LOG(slice, i));
-		intel_ring_emit(engine, remap_info[i]);
-	}
-
-	intel_ring_advance(engine);
-
-	return ret;
-}
-
 void i915_gem_init_swizzling(struct drm_device *dev)
 {
 	struct drm_i915_private *dev_priv = dev->dev_private;
diff --git a/drivers/gpu/drm/i915/i915_gem_context.c b/drivers/gpu/drm/i915/i915_gem_context.c
index 05752a2f1810..a429b4dcb4de 100644
--- a/drivers/gpu/drm/i915/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/i915_gem_context.c
@@ -601,6 +601,37 @@ mi_set_context(struct drm_i915_gem_request *req, u32 hw_flags)
 	return ret;
 }
 
+int i915_gem_l3_remap(struct drm_i915_gem_request *req, int slice)
+{
+	struct intel_engine_cs *engine = req->engine;
+	struct drm_device *dev = engine->dev;
+	struct drm_i915_private *dev_priv = dev->dev_private;
+	u32 *remap_info = dev_priv->l3_parity.remap_info[slice];
+	int i, ret;
+
+	if (!HAS_L3_DPF(dev) || !remap_info)
+		return 0;
+
+	ret = intel_ring_begin(req, GEN7_L3LOG_SIZE / 4 * 3);
+	if (ret)
+		return ret;
+
+	/*
+	 * Note: We do not worry about the concurrent register cacheline hang
+	 * here because no other code should access these registers other than
+	 * at initialization time.
+	 */
+	for (i = 0; i < GEN7_L3LOG_SIZE / 4; i++) {
+		intel_ring_emit(engine, MI_LOAD_REGISTER_IMM(1));
+		intel_ring_emit_reg(engine, GEN7_L3LOG(slice, i));
+		intel_ring_emit(engine, remap_info[i]);
+	}
+
+	intel_ring_advance(engine);
+
+	return ret;
+}
+
 static inline bool skip_rcs_switch(struct intel_engine_cs *engine,
 				   struct intel_context *to)
 {
-- 
2.8.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2016-04-26  6:56 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-26  6:54 No premature unpinning Chris Wilson
2016-04-26  6:54 ` [PATCH v4 01/25] drm/i915/fbdev: Call intel_unpin_fb_obj() on release Chris Wilson
2016-04-27 12:20   ` Tvrtko Ursulin
2016-04-27 12:32     ` Chris Wilson
2016-04-26  6:54 ` [PATCH v4 02/25] drm/i915/overlay: Replace i915_gem_obj_ggtt_offset() with the known flip_addr Chris Wilson
2016-04-26  6:54 ` [PATCH v4 03/25] io-mapping: Specify mapping size for io_mapping_map_wc() Chris Wilson
2016-04-26  6:54   ` Chris Wilson
2016-04-26  6:54   ` Chris Wilson
2016-04-26  6:54 ` [PATCH v4 04/25] drm/i915: Introduce i915_vm_to_ggtt() Chris Wilson
2016-04-26  6:54 ` [PATCH v4 05/25] drm/i915: Move ioremap_wc tracking onto VMA Chris Wilson
2016-04-26  6:54 ` [PATCH v4 06/25] drm/i915: Use i915_vma_pin_iomap on the ringbuffer object Chris Wilson
2016-04-26  6:54 ` [PATCH v4 07/25] drm/i915: Mark the current context as lost on suspend Chris Wilson
2016-04-26  6:54 ` Chris Wilson [this message]
2016-04-26  6:54 ` [PATCH v4 09/25] drm/i915: Consolidate L3 remapping LRI Chris Wilson
2016-04-26  6:54 ` [PATCH v4 10/25] drm/i915: Remove early l3-remap Chris Wilson
2016-04-26  6:54 ` [PATCH v4 11/25] drm/i915: Rearrange switch_context to load the aliasing ppgtt on first use Chris Wilson
2016-04-26  6:54 ` [PATCH v4 12/25] drm/i915: Unify intel_ring_begin() Chris Wilson
2016-04-26  6:54 ` [PATCH v4 13/25] drm/i915: Remove the identical implementations of request space reservation Chris Wilson
2016-04-26  6:54 ` [PATCH v4 14/25] drm/i915: Manually unwind after a failed request allocation Chris Wilson
2016-04-26  6:54 ` [PATCH v4 15/25] drm/i915: Preallocate enough space for the average request Chris Wilson
2016-04-26  6:54 ` [PATCH v4 16/25] drm/i915: Assign every HW context a unique ID Chris Wilson
2016-04-26  6:54 ` [PATCH v4 17/25] drm/i915: Replace the pinned context address with its " Chris Wilson
2016-04-26  6:54 ` [PATCH v4 18/25] drm/i915: Refactor execlists default context pinning Chris Wilson
2016-04-26  6:54 ` [PATCH v4 19/25] drm/i915: Move context initialisation to first-use Chris Wilson
2016-04-26  6:54 ` [PATCH v4 20/25] drm/i915: Move the magical deferred context allocation into the request Chris Wilson
2016-04-26  6:54 ` [PATCH v4 21/25] drm/i915: Move releasing of the GEM request from free to retire/cancel Chris Wilson
2016-04-26  6:54 ` [PATCH v4 22/25] drm/i915: Track the previous pinned context inside the request Chris Wilson
2016-04-26  6:54 ` [PATCH v4 23/25] drm/i915: Store LRC hardware id in " Chris Wilson
2016-04-26  6:54 ` [PATCH v4 24/25] drm/i915: Stop tracking execlists retired requests Chris Wilson
2016-04-26  6:54 ` [PATCH v4 25/25] drm/i915: Unify GPU resets upon shutdown Chris Wilson
2016-04-26  7:27 ` ✗ Fi.CI.BAT: failure for series starting with [v4,01/25] drm/i915/fbdev: Call intel_unpin_fb_obj() on release Patchwork
2016-04-26  8:25   ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461653672-17335-9-git-send-email-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=mika.kuoppala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.