All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Noralf Trønnes" <noralf@tronnes.org>
To: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Cc: daniel@ffwll.ch, laurent.pinchart@ideasonboard.com,
	tomi.valkeinen@ti.com, linux-kernel@vger.kernel.org,
	"Noralf Trønnes" <noralf@tronnes.org>
Subject: [PATCH v3 1/7] drm/udl: Change drm_fb_helper_sys_*() calls to sys_*()
Date: Wed, 27 Apr 2016 20:16:30 +0200	[thread overview]
Message-ID: <1461780996-8612-2-git-send-email-noralf@tronnes.org> (raw)
In-Reply-To: <1461780996-8612-1-git-send-email-noralf@tronnes.org>

Now that drm_fb_helper gets deferred io support, the
drm_fb_helper_sys_{fillrect,copyarea,imageblit} functions will schedule
a worker that will call the (struct drm_framebuffer *)->funcs->dirty()
function. This will break this driver so use the
sys_{fillrect,copyarea,imageblit} functions directly.

Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/udl/udl_fb.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/udl/udl_fb.c b/drivers/gpu/drm/udl/udl_fb.c
index fd1eb9d..a52de2f 100644
--- a/drivers/gpu/drm/udl/udl_fb.c
+++ b/drivers/gpu/drm/udl/udl_fb.c
@@ -287,7 +287,7 @@ static void udl_fb_fillrect(struct fb_info *info, const struct fb_fillrect *rect
 {
 	struct udl_fbdev *ufbdev = info->par;
 
-	drm_fb_helper_sys_fillrect(info, rect);
+	sys_fillrect(info, rect);
 
 	udl_handle_damage(&ufbdev->ufb, rect->dx, rect->dy, rect->width,
 			  rect->height);
@@ -297,7 +297,7 @@ static void udl_fb_copyarea(struct fb_info *info, const struct fb_copyarea *regi
 {
 	struct udl_fbdev *ufbdev = info->par;
 
-	drm_fb_helper_sys_copyarea(info, region);
+	sys_copyarea(info, region);
 
 	udl_handle_damage(&ufbdev->ufb, region->dx, region->dy, region->width,
 			  region->height);
@@ -307,7 +307,7 @@ static void udl_fb_imageblit(struct fb_info *info, const struct fb_image *image)
 {
 	struct udl_fbdev *ufbdev = info->par;
 
-	drm_fb_helper_sys_imageblit(info, image);
+	sys_imageblit(info, image);
 
 	udl_handle_damage(&ufbdev->ufb, image->dx, image->dy, image->width,
 			  image->height);
-- 
2.2.2

WARNING: multiple messages have this Message-ID (diff)
From: "Noralf Trønnes" <noralf@tronnes.org>
To: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Cc: tomi.valkeinen@ti.com, laurent.pinchart@ideasonboard.com,
	linux-kernel@vger.kernel.org
Subject: [PATCH v3 1/7] drm/udl: Change drm_fb_helper_sys_*() calls to sys_*()
Date: Wed, 27 Apr 2016 18:16:30 +0000	[thread overview]
Message-ID: <1461780996-8612-2-git-send-email-noralf@tronnes.org> (raw)
In-Reply-To: <1461780996-8612-1-git-send-email-noralf@tronnes.org>

Now that drm_fb_helper gets deferred io support, the
drm_fb_helper_sys_{fillrect,copyarea,imageblit} functions will schedule
a worker that will call the (struct drm_framebuffer *)->funcs->dirty()
function. This will break this driver so use the
sys_{fillrect,copyarea,imageblit} functions directly.

Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/udl/udl_fb.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/udl/udl_fb.c b/drivers/gpu/drm/udl/udl_fb.c
index fd1eb9d..a52de2f 100644
--- a/drivers/gpu/drm/udl/udl_fb.c
+++ b/drivers/gpu/drm/udl/udl_fb.c
@@ -287,7 +287,7 @@ static void udl_fb_fillrect(struct fb_info *info, const struct fb_fillrect *rect
 {
 	struct udl_fbdev *ufbdev = info->par;
 
-	drm_fb_helper_sys_fillrect(info, rect);
+	sys_fillrect(info, rect);
 
 	udl_handle_damage(&ufbdev->ufb, rect->dx, rect->dy, rect->width,
 			  rect->height);
@@ -297,7 +297,7 @@ static void udl_fb_copyarea(struct fb_info *info, const struct fb_copyarea *regi
 {
 	struct udl_fbdev *ufbdev = info->par;
 
-	drm_fb_helper_sys_copyarea(info, region);
+	sys_copyarea(info, region);
 
 	udl_handle_damage(&ufbdev->ufb, region->dx, region->dy, region->width,
 			  region->height);
@@ -307,7 +307,7 @@ static void udl_fb_imageblit(struct fb_info *info, const struct fb_image *image)
 {
 	struct udl_fbdev *ufbdev = info->par;
 
-	drm_fb_helper_sys_imageblit(info, image);
+	sys_imageblit(info, image);
 
 	udl_handle_damage(&ufbdev->ufb, image->dx, image->dy, image->width,
 			  image->height);
-- 
2.2.2


WARNING: multiple messages have this Message-ID (diff)
From: "Noralf Trønnes" <noralf@tronnes.org>
To: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Cc: tomi.valkeinen@ti.com, laurent.pinchart@ideasonboard.com,
	linux-kernel@vger.kernel.org
Subject: [PATCH v3 1/7] drm/udl: Change drm_fb_helper_sys_*() calls to sys_*()
Date: Wed, 27 Apr 2016 20:16:30 +0200	[thread overview]
Message-ID: <1461780996-8612-2-git-send-email-noralf@tronnes.org> (raw)
In-Reply-To: <1461780996-8612-1-git-send-email-noralf@tronnes.org>

Now that drm_fb_helper gets deferred io support, the
drm_fb_helper_sys_{fillrect,copyarea,imageblit} functions will schedule
a worker that will call the (struct drm_framebuffer *)->funcs->dirty()
function. This will break this driver so use the
sys_{fillrect,copyarea,imageblit} functions directly.

Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/udl/udl_fb.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/udl/udl_fb.c b/drivers/gpu/drm/udl/udl_fb.c
index fd1eb9d..a52de2f 100644
--- a/drivers/gpu/drm/udl/udl_fb.c
+++ b/drivers/gpu/drm/udl/udl_fb.c
@@ -287,7 +287,7 @@ static void udl_fb_fillrect(struct fb_info *info, const struct fb_fillrect *rect
 {
 	struct udl_fbdev *ufbdev = info->par;
 
-	drm_fb_helper_sys_fillrect(info, rect);
+	sys_fillrect(info, rect);
 
 	udl_handle_damage(&ufbdev->ufb, rect->dx, rect->dy, rect->width,
 			  rect->height);
@@ -297,7 +297,7 @@ static void udl_fb_copyarea(struct fb_info *info, const struct fb_copyarea *regi
 {
 	struct udl_fbdev *ufbdev = info->par;
 
-	drm_fb_helper_sys_copyarea(info, region);
+	sys_copyarea(info, region);
 
 	udl_handle_damage(&ufbdev->ufb, region->dx, region->dy, region->width,
 			  region->height);
@@ -307,7 +307,7 @@ static void udl_fb_imageblit(struct fb_info *info, const struct fb_image *image)
 {
 	struct udl_fbdev *ufbdev = info->par;
 
-	drm_fb_helper_sys_imageblit(info, image);
+	sys_imageblit(info, image);
 
 	udl_handle_damage(&ufbdev->ufb, image->dx, image->dy, image->width,
 			  image->height);
-- 
2.2.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-04-27 18:17 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-27 18:16 [PATCH v3 0/7] drm: Add fbdev deferred io support to helpers Noralf Trønnes
2016-04-27 18:16 ` Noralf Trønnes
2016-04-27 18:16 ` Noralf Trønnes
2016-04-27 18:16 ` Noralf Trønnes [this message]
2016-04-27 18:16   ` [PATCH v3 1/7] drm/udl: Change drm_fb_helper_sys_*() calls to sys_*() Noralf Trønnes
2016-04-27 18:16   ` Noralf Trønnes
2016-04-27 18:16 ` [PATCH v3 2/7] drm/qxl: " Noralf Trønnes
2016-04-27 18:16   ` Noralf Trønnes
2016-04-27 18:16   ` Noralf Trønnes
2016-04-27 18:16 ` [PATCH v3 3/7] drm/fb-helper: Add fb_deferred_io support Noralf Trønnes
2016-04-27 18:16   ` Noralf Trønnes
2016-04-27 18:16   ` Noralf Trønnes
2016-04-27 19:20   ` Daniel Vetter
2016-04-27 19:20     ` Daniel Vetter
2016-04-27 19:20     ` Daniel Vetter
2016-04-27 19:24     ` Noralf Trønnes
2016-04-27 19:24       ` Noralf Trønnes
2016-04-28  7:17       ` Daniel Vetter
2016-04-28  7:17         ` Daniel Vetter
2016-04-28  7:17         ` Daniel Vetter
2016-04-27 18:16 ` [PATCH v3 4/7] fbdev: fb_defio: Export fb_deferred_io_mmap Noralf Trønnes
2016-04-27 18:16   ` Noralf Trønnes
2016-04-27 18:16   ` Noralf Trønnes
2016-04-27 18:16 ` [PATCH v3 5/7] drm/fb-cma-helper: Add fb_deferred_io support Noralf Trønnes
2016-04-27 18:16   ` Noralf Trønnes
2016-04-27 18:16   ` Noralf Trønnes
2016-04-27 18:16 ` [PATCH v3 6/7] drm/qxl: Use drm_fb_helper deferred_io support Noralf Trønnes
2016-04-27 18:16   ` Noralf Trønnes
2016-04-27 18:16   ` Noralf Trønnes
2016-04-27 19:22   ` Daniel Vetter
2016-04-27 19:22     ` Daniel Vetter
2016-04-27 19:22     ` Daniel Vetter
2016-04-27 18:16 ` [PATCH v3 7/7] drm/udl: " Noralf Trønnes
2016-04-27 18:16   ` Noralf Trønnes
2016-04-27 18:16   ` Noralf Trønnes
2016-04-27 19:24 ` [PATCH v3 0/7] drm: Add fbdev deferred io support to helpers Daniel Vetter
2016-04-27 19:24   ` Daniel Vetter
2016-04-27 19:24   ` Daniel Vetter
2016-04-27 19:49   ` Noralf Trønnes
2016-04-27 19:49     ` Noralf Trønnes
2016-04-27 19:49     ` Noralf Trønnes
2016-04-28  7:20     ` Daniel Vetter
2016-04-28  7:20       ` Daniel Vetter
2016-04-28  7:20       ` Daniel Vetter
2016-04-29  8:02 ` Gerd Hoffmann
2016-04-29  8:02   ` Gerd Hoffmann
2016-04-29  8:02   ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461780996-8612-2-git-send-email-noralf@tronnes.org \
    --to=noralf@tronnes.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.