All of lore.kernel.org
 help / color / mirror / Atom feed
From: Goldwyn Rodrigues <rgoldwyn@suse.de>
To: linux-fsdevel@vger.kernel.org
Cc: Goldwyn Rodrigues <rgoldwyn@suse.com>
Subject: [PoC 3/7] Create sysfs files under sb
Date: Thu, 28 Apr 2016 21:01:18 -0500	[thread overview]
Message-ID: <1461895282-4941-4-git-send-email-rgoldwyn@suse.de> (raw)
In-Reply-To: <1461895282-4941-1-git-send-email-rgoldwyn@suse.de>

From: Goldwyn Rodrigues <rgoldwyn@suse.com>

This would create sysfs entries under /sys/fs/<fstype>/<s_id>.
fill_super() must initialize attrs. This may not be the best
way to do it. Suggestions?

Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
---
 fs/super.c         | 8 ++++----
 include/linux/fs.h | 1 +
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/fs/super.c b/fs/super.c
index 5f5e25d..f6cef10 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -179,12 +179,12 @@ static const struct sysfs_ops sb_sysfs_ops = {
 
 static int register_kobj(struct super_block *sb)
 {
-	struct kobj_type *ktype;
-       	ktype = kzalloc(sizeof(struct kobj_type), GFP_USER);
-	if (IS_ERR(ktype))
-		return PTR_ERR(ktype);
+	struct kobj_type *ktype = kzalloc(sizeof(struct kobj_type), GFP_USER);
+	if (!ktype)
+		return -ENOMEM;
 	ktype->sysfs_ops = &sb_sysfs_ops;
 	ktype->release = release_super;
+	ktype->default_attrs = sb->s_attr;
 	sb->s_kobj.kset = sb->s_type->kset;
 	return kobject_init_and_add(&sb->s_kobj, ktype, NULL,
 			"%s", sb->s_id);
diff --git a/include/linux/fs.h b/include/linux/fs.h
index e6b9d89..59b84a8 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -1441,6 +1441,7 @@ struct super_block {
 	spinlock_t		s_inode_list_lock ____cacheline_aligned_in_smp;
 	struct list_head	s_inodes;	/* all inodes */
 	struct kobject		s_kobj;
+	struct attribute	**s_attr;
 };
 
 extern struct timespec current_fs_time(struct super_block *sb);
-- 
2.6.6


  parent reply	other threads:[~2016-04-29  2:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-29  2:01 [PoC 0/7] Kobjectify filesystem Goldwyn Rodrigues
2016-04-29  2:01 ` [PoC 1/7] Add kset to file_system_type Goldwyn Rodrigues
2016-04-29  2:01 ` [PoC 2/7] Add kobject to super_block Goldwyn Rodrigues
2016-04-29  2:26   ` Al Viro
2016-04-29 19:09     ` Goldwyn Rodrigues
2016-04-29  2:01 ` Goldwyn Rodrigues [this message]
2016-04-29  2:01 ` [PoC 4/7] Report file system events Goldwyn Rodrigues
2016-04-29  2:01 ` [PoC 5/7] ocfs2: Use the sb's kset Goldwyn Rodrigues
2016-04-29  2:01 ` [PoC 6/7] ocfs2: create filecheck files Goldwyn Rodrigues
2016-04-29  2:01 ` [PoC 7/7] ocfs2: report inode errors to userspace Goldwyn Rodrigues
2016-04-29 17:32 ` [PoC 0/7] Kobjectify filesystem Viacheslav Dubeyko
2016-04-29 18:28   ` Goldwyn Rodrigues
2016-04-29 20:16     ` Viacheslav Dubeyko
2016-04-29 22:09       ` Goldwyn Rodrigues
2016-04-29 22:31     ` Al Viro
2016-04-29 22:45       ` Goldwyn Rodrigues
2016-05-04 22:20       ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461895282-4941-4-git-send-email-rgoldwyn@suse.de \
    --to=rgoldwyn@suse.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=rgoldwyn@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.