All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Crispin <john@phrozen.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: nbd@nbd.name, netdev@vger.kernel.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	John Crispin <john@phrozen.org>
Subject: [PATCH 07/12] net-next: mediatek: disable all interrupts during probe
Date: Thu,  5 May 2016 11:26:20 +0200	[thread overview]
Message-ID: <1462440385-51939-8-git-send-email-john@phrozen.org> (raw)
In-Reply-To: <1462440385-51939-1-git-send-email-john@phrozen.org>

The current code only disables those IRQs that we will later use. To
ensure that we have a predefined state, we really want to disable all IRQs.
Change the code to disable all IRQs to achieve this.

Signed-off-by: John Crispin <john@phrozen.org>
---
 drivers/net/ethernet/mediatek/mtk_eth_soc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index 60095be..08f3df4 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -1391,7 +1391,7 @@ static int __init mtk_hw_init(struct mtk_eth *eth)
 
 	/* disable delay and normal interrupt */
 	mtk_w32(eth, 0, MTK_QDMA_DELAY_INT);
-	mtk_irq_disable(eth, MTK_TX_DONE_INT | MTK_RX_DONE_INT);
+	mtk_irq_disable(eth, ~0);
 	mtk_w32(eth, RST_GL_PSE, MTK_RST_GL);
 	mtk_w32(eth, 0, MTK_RST_GL);
 
-- 
1.7.10.4

WARNING: multiple messages have this Message-ID (diff)
From: John Crispin <john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>
To: "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	John Crispin <john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	nbd-Vt+b4OUoWG0@public.gmane.org
Subject: [PATCH 07/12] net-next: mediatek: disable all interrupts during probe
Date: Thu,  5 May 2016 11:26:20 +0200	[thread overview]
Message-ID: <1462440385-51939-8-git-send-email-john@phrozen.org> (raw)
In-Reply-To: <1462440385-51939-1-git-send-email-john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>

The current code only disables those IRQs that we will later use. To
ensure that we have a predefined state, we really want to disable all IRQs.
Change the code to disable all IRQs to achieve this.

Signed-off-by: John Crispin <john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>
---
 drivers/net/ethernet/mediatek/mtk_eth_soc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index 60095be..08f3df4 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -1391,7 +1391,7 @@ static int __init mtk_hw_init(struct mtk_eth *eth)
 
 	/* disable delay and normal interrupt */
 	mtk_w32(eth, 0, MTK_QDMA_DELAY_INT);
-	mtk_irq_disable(eth, MTK_TX_DONE_INT | MTK_RX_DONE_INT);
+	mtk_irq_disable(eth, ~0);
 	mtk_w32(eth, RST_GL_PSE, MTK_RST_GL);
 	mtk_w32(eth, 0, MTK_RST_GL);
 
-- 
1.7.10.4

  parent reply	other threads:[~2016-05-05  9:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-05  9:26 [PATCH 00/12] net-next: mediatek: bug fixes and tx stall fixes John Crispin
2016-05-05  9:26 ` [PATCH 01/12] net-next: mediatek: fix DQL support John Crispin
2016-05-05  9:26 ` [PATCH 02/12] net-next: mediatek: add missing return code check John Crispin
2016-05-05  9:26   ` John Crispin
2016-05-05  9:26 ` [PATCH 03/12] net-next: mediatek: fix missing free of scratch memory John Crispin
2016-05-05  9:26   ` John Crispin
2016-05-05  9:26 ` [PATCH 04/12] net-next: mediatek: invalid buffer lookup in mtk_tx_map() John Crispin
2016-05-05  9:26   ` John Crispin
2016-05-05  9:26 ` [PATCH 05/12] net-next: mediatek: dropped rx packets are not being counted properly John Crispin
2016-05-05  9:26   ` John Crispin
2016-05-05  9:26 ` [PATCH 06/12] net-next: mediatek: add next data pointer coherency protection John Crispin
2016-05-05  9:26   ` John Crispin
2016-05-05  9:26 ` John Crispin [this message]
2016-05-05  9:26   ` [PATCH 07/12] net-next: mediatek: disable all interrupts during probe John Crispin
2016-05-05  9:26 ` [PATCH 08/12] net-next: mediatek: fix threshold value John Crispin
2016-05-05  9:26   ` John Crispin
2016-05-05  9:26 ` [PATCH 09/12] net-next: mediatek: increase watchdog_timeo John Crispin
2016-05-05  9:26 ` [PATCH 10/12] net-next: mediatek: fix off by one in the TX ring allocation John Crispin
2016-05-05  9:26 ` [PATCH 11/12] net-next: mediatek: only wake the queue if it is stopped John Crispin
2016-05-05  9:26 ` [PATCH 12/12] net-next: mediatek: remove superfluous queue wake up call John Crispin
2016-05-05 12:25 ` [PATCH 00/12] net-next: mediatek: bug fixes and tx stall fixes Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1462440385-51939-8-git-send-email-john@phrozen.org \
    --to=john@phrozen.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=nbd@nbd.name \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.