All of lore.kernel.org
 help / color / mirror / Atom feed
From: Toshi Kani <toshi.kani@hpe.com>
To: dan.j.williams@intel.com, jack@suse.cz, david@fromorbit.com,
	viro@zeniv.linux.org.uk
Cc: hch@infradead.org, tytso@mit.edu, linux-nvdimm@lists.01.org,
	linux-kernel@vger.kernel.org, micah.parrish@hpe.com,
	axboe@fb.com, adilger.kernel@dilger.ca,
	linux-fsdevel@vger.kernel.org
Subject: [PATCH v3 5/5] xfs: Add alignment check for DAX mount
Date: Thu,  5 May 2016 18:29:56 -0600	[thread overview]
Message-ID: <1462494596-20938-6-git-send-email-toshi.kani@hpe.com> (raw)
In-Reply-To: <1462494596-20938-1-git-send-email-toshi.kani@hpe.com>

When a partition is not aligned by 4KB, mount -o dax succeeds,
but any read/write access to the filesystem fails, except for
metadata update.

Call bdev_supports_dax() to perform proper precondition checks
which includes this partition alignment check.

Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
Cc: Dave Chinner <david@fromorbit.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Boaz Harrosh <boaz@plexistor.com>
---
 fs/xfs/xfs_super.c |   12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 187e14b..cc177da 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -1558,14 +1558,12 @@ xfs_fs_fill_super(
 
 	if (mp->m_flags & XFS_MOUNT_DAX) {
 		xfs_warn(mp,
-	"DAX enabled. Warning: EXPERIMENTAL, use at your own risk");
-		if (sb->s_blocksize != PAGE_SIZE) {
-			xfs_alert(mp,
-		"Filesystem block size invalid for DAX Turning DAX off.");
-			mp->m_flags &= ~XFS_MOUNT_DAX;
-		} else if (!sb->s_bdev->bd_disk->fops->direct_access) {
+		"DAX enabled. Warning: EXPERIMENTAL, use at your own risk");
+
+		error = bdev_supports_dax(sb, sb->s_blocksize);
+		if (error) {
 			xfs_alert(mp,
-		"Block device does not support DAX Turning DAX off.");
+			"DAX unsupported by block device. Turning off DAX.");
 			mp->m_flags &= ~XFS_MOUNT_DAX;
 		}
 	}
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Toshi Kani <toshi.kani@hpe.com>
To: dan.j.williams@intel.com, jack@suse.cz, david@fromorbit.com,
	viro@zeniv.linux.org.uk
Cc: axboe@fb.com, hch@infradead.org, boaz@plexistor.com,
	tytso@mit.edu, adilger.kernel@dilger.ca,
	ross.zwisler@linux.intel.com, toshi.kani@hpe.com,
	micah.parrish@hpe.com, linux-nvdimm@ml01.01.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 5/5] xfs: Add alignment check for DAX mount
Date: Thu,  5 May 2016 18:29:56 -0600	[thread overview]
Message-ID: <1462494596-20938-6-git-send-email-toshi.kani@hpe.com> (raw)
In-Reply-To: <1462494596-20938-1-git-send-email-toshi.kani@hpe.com>

When a partition is not aligned by 4KB, mount -o dax succeeds,
but any read/write access to the filesystem fails, except for
metadata update.

Call bdev_supports_dax() to perform proper precondition checks
which includes this partition alignment check.

Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
Cc: Dave Chinner <david@fromorbit.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Boaz Harrosh <boaz@plexistor.com>
---
 fs/xfs/xfs_super.c |   12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 187e14b..cc177da 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -1558,14 +1558,12 @@ xfs_fs_fill_super(
 
 	if (mp->m_flags & XFS_MOUNT_DAX) {
 		xfs_warn(mp,
-	"DAX enabled. Warning: EXPERIMENTAL, use at your own risk");
-		if (sb->s_blocksize != PAGE_SIZE) {
-			xfs_alert(mp,
-		"Filesystem block size invalid for DAX Turning DAX off.");
-			mp->m_flags &= ~XFS_MOUNT_DAX;
-		} else if (!sb->s_bdev->bd_disk->fops->direct_access) {
+		"DAX enabled. Warning: EXPERIMENTAL, use at your own risk");
+
+		error = bdev_supports_dax(sb, sb->s_blocksize);
+		if (error) {
 			xfs_alert(mp,
-		"Block device does not support DAX Turning DAX off.");
+			"DAX unsupported by block device. Turning off DAX.");
 			mp->m_flags &= ~XFS_MOUNT_DAX;
 		}
 	}

WARNING: multiple messages have this Message-ID (diff)
From: Toshi Kani <toshi.kani@hpe.com>
To: dan.j.williams@intel.com, jack@suse.cz, david@fromorbit.com,
	viro@zeniv.linux.org.uk
Cc: axboe@fb.com, hch@infradead.org, boaz@plexistor.com,
	tytso@mit.edu, adilger.kernel@dilger.ca,
	ross.zwisler@linux.intel.com, toshi.kani@hpe.com,
	micah.parrish@hpe.com, linux-nvdimm@lists.01.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 5/5] xfs: Add alignment check for DAX mount
Date: Thu,  5 May 2016 18:29:56 -0600	[thread overview]
Message-ID: <1462494596-20938-6-git-send-email-toshi.kani@hpe.com> (raw)
In-Reply-To: <1462494596-20938-1-git-send-email-toshi.kani@hpe.com>

When a partition is not aligned by 4KB, mount -o dax succeeds,
but any read/write access to the filesystem fails, except for
metadata update.

Call bdev_supports_dax() to perform proper precondition checks
which includes this partition alignment check.

Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
Cc: Dave Chinner <david@fromorbit.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Boaz Harrosh <boaz@plexistor.com>
---
 fs/xfs/xfs_super.c |   12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 187e14b..cc177da 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -1558,14 +1558,12 @@ xfs_fs_fill_super(
 
 	if (mp->m_flags & XFS_MOUNT_DAX) {
 		xfs_warn(mp,
-	"DAX enabled. Warning: EXPERIMENTAL, use at your own risk");
-		if (sb->s_blocksize != PAGE_SIZE) {
-			xfs_alert(mp,
-		"Filesystem block size invalid for DAX Turning DAX off.");
-			mp->m_flags &= ~XFS_MOUNT_DAX;
-		} else if (!sb->s_bdev->bd_disk->fops->direct_access) {
+		"DAX enabled. Warning: EXPERIMENTAL, use at your own risk");
+
+		error = bdev_supports_dax(sb, sb->s_blocksize);
+		if (error) {
 			xfs_alert(mp,
-		"Block device does not support DAX Turning DAX off.");
+			"DAX unsupported by block device. Turning off DAX.");
 			mp->m_flags &= ~XFS_MOUNT_DAX;
 		}
 	}

  parent reply	other threads:[~2016-05-06  0:39 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-06  0:29 [PATCH v3 0/5] Add alignment check for DAX mount Toshi Kani
2016-05-06  0:29 ` Toshi Kani
2016-05-06  0:29 ` Toshi Kani
2016-05-06  0:29 ` [PATCH v3 1/5] block: Add vfs_msg() interface Toshi Kani
2016-05-06  0:29   ` Toshi Kani
2016-05-06  0:29   ` Toshi Kani
2016-05-08  8:56   ` Christoph Hellwig
2016-05-06  0:29 ` [PATCH v3 2/5] block: Add bdev_supports_dax() for dax mount checks Toshi Kani
2016-05-06  0:29   ` Toshi Kani
2016-05-06  0:29   ` Toshi Kani
2016-05-08  8:57   ` Christoph Hellwig
2016-05-08 19:14   ` Dan Williams
2016-05-08 19:14     ` Dan Williams
2016-05-08 19:14     ` Dan Williams
2016-05-09 18:12     ` Toshi Kani
2016-05-09 18:12       ` Toshi Kani
2016-05-09 18:12       ` Toshi Kani
2016-05-09 18:23       ` Dan Williams
2016-05-09 18:23         ` Dan Williams
2016-05-09 18:23         ` Dan Williams
2016-05-09 21:19         ` Dave Chinner
2016-05-09 21:19           ` Dave Chinner
2016-05-09 21:19           ` Dave Chinner
2016-05-09 22:34           ` Toshi Kani
2016-05-09 22:34             ` Toshi Kani
2016-05-09 22:34             ` Toshi Kani
2016-05-09 22:50             ` Toshi Kani
2016-05-09 22:50               ` Toshi Kani
2016-05-09 22:50               ` Toshi Kani
2016-05-06  0:29 ` [PATCH v3 3/5] ext4: Add alignment check for DAX mount Toshi Kani
2016-05-06  0:29   ` Toshi Kani
2016-05-06  0:29   ` Toshi Kani
2016-05-09  8:15   ` Jan Kara
2016-05-09  8:15     ` Jan Kara
2016-05-09  8:15     ` Jan Kara
2016-05-06  0:29 ` [PATCH v3 4/5] ext2: " Toshi Kani
2016-05-06  0:29   ` Toshi Kani
2016-05-06  0:29   ` Toshi Kani
2016-05-08  8:59   ` Christoph Hellwig
2016-05-09  8:23     ` Jan Kara
2016-05-09  8:31   ` Jan Kara
2016-05-09  8:31     ` Jan Kara
2016-05-09  8:31     ` Jan Kara
2016-05-06  0:29 ` Toshi Kani [this message]
2016-05-06  0:29   ` [PATCH v3 5/5] xfs: " Toshi Kani
2016-05-06  0:29   ` Toshi Kani
2016-05-08  8:58   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1462494596-20938-6-git-send-email-toshi.kani@hpe.com \
    --to=toshi.kani@hpe.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=axboe@fb.com \
    --cc=dan.j.williams@intel.com \
    --cc=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=micah.parrish@hpe.com \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.