All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Crispin <john@phrozen.org>
To: davem@davemloft.net
Cc: nbd@nbd.name, netdev@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	John Crispin <john@phrozen.org>
Subject: [PATCH V2 09/22] net-next: mediatek: dropped rx packets are not being counted properly
Date: Mon,  9 May 2016 12:04:01 +0200	[thread overview]
Message-ID: <1462788254-40572-10-git-send-email-john@phrozen.org> (raw)
In-Reply-To: <1462788254-40572-1-git-send-email-john@phrozen.org>

There are 2 places inside mtk_poll_rx where rx_dropped is not being
incremented properly. Fix this by adding the missing code to increment
the counter.

Signed-off-by: John Crispin <john@phrozen.org>
---
 drivers/net/ethernet/mediatek/mtk_eth_soc.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index e61e73b..75488d1 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -828,6 +828,7 @@ static int mtk_poll_rx(struct napi_struct *napi, int budget,
 					  DMA_FROM_DEVICE);
 		if (unlikely(dma_mapping_error(&netdev->dev, dma_addr))) {
 			skb_free_frag(new_data);
+			netdev->stats.rx_dropped++;
 			goto release_desc;
 		}
 
@@ -835,6 +836,7 @@ static int mtk_poll_rx(struct napi_struct *napi, int budget,
 		skb = build_skb(data, ring->frag_size);
 		if (unlikely(!skb)) {
 			put_page(virt_to_head_page(new_data));
+			netdev->stats.rx_dropped++;
 			goto release_desc;
 		}
 		skb_reserve(skb, NET_SKB_PAD + NET_IP_ALIGN);
-- 
1.7.10.4

  parent reply	other threads:[~2016-05-09 10:04 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-09 10:03 [PATCH V2 00/22] net-next: mediatek: various fixes and IRQ grouping John Crispin
2016-05-09 10:03 ` [PATCH V2 01/22] net-next: mediatek: use mdiobus_free() in favour of kfree() John Crispin
2016-05-09 12:07   ` Andrew Lunn
2016-05-09 10:03 ` [PATCH V2 02/22] net-next: mediatek: fix gigabit and flow control advertisement John Crispin
2016-05-09 10:03 ` [PATCH V2 03/22] net-next: mediatek: add fixed-phy support John Crispin
2016-05-09 10:03 ` [PATCH V2 04/22] net-next: mediatek: properly handle RGMII modes John Crispin
2016-05-09 12:09   ` Andrew Lunn
2016-05-09 10:03 ` [PATCH V2 05/22] net-next: mediatek: fix DQL support John Crispin
2016-05-09 10:03 ` [PATCH V2 06/22] net-next: mediatek: add missing return code check John Crispin
2016-05-09 10:03 ` [PATCH V2 07/22] net-next: mediatek: fix missing free of scratch memory John Crispin
2016-05-09 10:04 ` [PATCH V2 08/22] net-next: mediatek: invalid buffer lookup in mtk_tx_map() John Crispin
2016-05-09 10:04 ` John Crispin [this message]
2016-05-09 10:04 ` [PATCH V2 10/22] net-next: mediatek: add next data pointer coherency protection John Crispin
2016-05-09 10:04 ` [PATCH V2 11/22] net-next: mediatek: disable all interrupts during probe John Crispin
2016-05-09 10:04 ` [PATCH V2 13/22] net-next: mediatek: increase watchdog_timeo John Crispin
2016-05-09 10:04 ` [PATCH V2 15/22] net-next: mediatek: only wake the queue if it is stopped John Crispin
2016-05-09 10:04 ` [PATCH V2 17/22] net-next: mediatek: remove superfluous register reads John Crispin
     [not found] ` <1462788254-40572-1-git-send-email-john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>
2016-05-09 10:04   ` [PATCH V2 12/22] net-next: mediatek: fix threshold value John Crispin
2016-05-09 10:04   ` [PATCH V2 14/22] net-next: mediatek: fix off by one in the TX ring allocation John Crispin
2016-05-09 10:04   ` [PATCH V2 16/22] net-next: mediatek: remove superfluous queue wake up call John Crispin
2016-05-09 10:04   ` [PATCH V2 18/22] net-next: mediatek: don't use intermediate variables to store IRQ masks John Crispin
2016-05-09 10:04   ` [PATCH V2 20/22] net-next: mediatek: add support for IRQ grouping John Crispin
2016-05-09 10:04 ` [PATCH V2 19/22] net-next: mediatek: add IRQ locking John Crispin
2016-05-09 10:04 ` [PATCH V2 21/22] net-next: mediatek: change my email address John Crispin
2016-05-09 10:04 ` [PATCH V2 22/22] MAINTAINERS: " John Crispin
2016-05-09 16:02 ` [PATCH V2 00/22] net-next: mediatek: various fixes and IRQ grouping David Miller
2016-05-09 16:25   ` John Crispin
2016-05-09 16:28     ` David Miller
2016-05-09 16:34       ` John Crispin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1462788254-40572-10-git-send-email-john@phrozen.org \
    --to=john@phrozen.org \
    --cc=davem@davemloft.net \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=nbd@nbd.name \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.