All of lore.kernel.org
 help / color / mirror / Atom feed
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	alsa-devel@alsa-project.org
Cc: Mark Brown <broonie@kernel.org>, Heiko Stuebner <heiko@sntech.de>
Subject: [PATCH v2 2/5] ASoC: rockchip-max98090: Fix the Headset Mic route.
Date: Mon,  9 May 2016 12:46:32 +0200	[thread overview]
Message-ID: <1462790795-25345-3-git-send-email-enric.balletbo@collabora.com> (raw)
In-Reply-To: <1462790795-25345-1-git-send-email-enric.balletbo@collabora.com>

The path Headset Mic --> MICBIAS is wrong because connects a non-supply
widget as a source with a supply widget as a sink. It's the other way
around:

  MICBIAS (source) --> Headset Mic (sink).

This patch also shut up the following error message:

 rockchip-snd-max98090 sound: Connecting non-supply widget to supply widget is not supported (Headset Mic -> MICBIAS)
 rockchip-snd-max98090 sound: ASoC: no dapm match for Headset Mic --> (null) --> MICBIAS
 rockchip-snd-max98090 sound: ASoC: Failed to add route Headset Mic -> direct -> MICBIAS

Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
Changes since v1:
 - Improve log message.

 sound/soc/rockchip/rockchip_max98090.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/rockchip/rockchip_max98090.c b/sound/soc/rockchip/rockchip_max98090.c
index abb64a5..3da7891 100644
--- a/sound/soc/rockchip/rockchip_max98090.c
+++ b/sound/soc/rockchip/rockchip_max98090.c
@@ -53,7 +53,7 @@ static const struct snd_soc_dapm_widget rk_dapm_widgets[] = {
 static const struct snd_soc_dapm_route rk_audio_map[] = {
 	{"IN34", NULL, "Headset Mic"},
 	{"IN34", NULL, "MICBIAS"},
-	{"MICBIAS", NULL, "Headset Mic"},
+	{"Headset Mic", NULL, "MICBIAS"},
 	{"DMICL", NULL, "Int Mic"},
 	{"Headphone", NULL, "HPL"},
 	{"Headphone", NULL, "HPR"},
-- 
2.1.0

  parent reply	other threads:[~2016-05-09 10:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-09 10:46 [PATCH v2 0/5] ASoC: rockchip: Fix audio on Veyron Enric Balletbo i Serra
2016-05-09 10:46 ` Enric Balletbo i Serra
2016-05-09 10:46 ` [PATCH v2 1/5] ASoC: rockchip-max98090: Fix NULL pointer dereference while accessing to jack Enric Balletbo i Serra
2016-05-09 10:46 ` Enric Balletbo i Serra [this message]
2016-05-09 10:46 ` [PATCH v2 3/5] ASoC: rockchip-max98090: Fix jack detection and event reporting Enric Balletbo i Serra
2016-05-10 18:49   ` Applied "ASoC: rockchip-max98090: Fix jack detection and event reporting." to the asoc tree Mark Brown
2016-05-10 18:49     ` Mark Brown
2016-05-10 18:49     ` Mark Brown
2016-05-09 10:46 ` [PATCH v2 4/5] ARM: dts: rockchip: Add shared file for audio related nodes for veyron boards Enric Balletbo i Serra
2016-05-15 22:06   ` Heiko Stuebner
2016-05-15 22:06     ` Heiko Stuebner
2016-05-17  8:14     ` [alsa-devel] " Enric Balletbo Serra
2016-05-17  8:14       ` Enric Balletbo Serra
2016-05-17  9:36       ` [alsa-devel] " Heiko Stuebner
2016-05-17  9:36         ` Heiko Stuebner
2016-05-17 13:30         ` [alsa-devel] " Heiko Stuebner
2016-05-17 13:30           ` Heiko Stuebner
2016-05-09 10:46 ` [PATCH v2 5/5] ARM: dts: rockchip: veyron: Add analog audio codecs Enric Balletbo i Serra
2016-05-15 22:06   ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1462790795-25345-3-git-send-email-enric.balletbo@collabora.com \
    --to=enric.balletbo@collabora.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=heiko@sntech.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.