All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bandan Das <bsd@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, aik@ozlabs.ru
Subject: [Qemu-devel] [PATCH 3/4] nmi: add errp function parameter to inject_nmi()
Date: Thu, 19 May 2016 18:15:15 -0400	[thread overview]
Message-ID: <1463696116-31631-4-git-send-email-bsd@redhat.com> (raw)
In-Reply-To: <1463696116-31631-1-git-send-email-bsd@redhat.com>

If caller has errp, set it appropriately in case of
an error and pass it along.

Signed-off-by: Bandan Das <bsd@redhat.com>
---
 hw/core/nmi.c          | 4 ++--
 hw/watchdog/watchdog.c | 2 +-
 include/hw/nmi.h       | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/core/nmi.c b/hw/core/nmi.c
index cc47025..40324a9 100644
--- a/hw/core/nmi.c
+++ b/hw/core/nmi.c
@@ -73,9 +73,9 @@ void nmi_monitor_handle(int cpu_index, Error **errp)
     }
 }
 
-void inject_nmi(void)
+void inject_nmi(Error **errp)
 {
-    nmi_monitor_handle(0, NULL);
+    nmi_monitor_handle(0, errp);
 }
 
 static const TypeInfo nmi_info = {
diff --git a/hw/watchdog/watchdog.c b/hw/watchdog/watchdog.c
index bbf3646..c3f2c87 100644
--- a/hw/watchdog/watchdog.c
+++ b/hw/watchdog/watchdog.c
@@ -143,7 +143,7 @@ void watchdog_perform_action(void)
     case WDT_NMI:
         qapi_event_send_watchdog(WATCHDOG_EXPIRATION_ACTION_INJECT_NMI,
                                  &error_abort);
-        inject_nmi();
+        inject_nmi(NULL);
         break;
     }
 }
diff --git a/include/hw/nmi.h b/include/hw/nmi.h
index f4cec62..63794d9 100644
--- a/include/hw/nmi.h
+++ b/include/hw/nmi.h
@@ -45,6 +45,6 @@ typedef struct NMIClass {
 } NMIClass;
 
 void nmi_monitor_handle(int cpu_index, Error **errp);
-void inject_nmi(void);
+void inject_nmi(Error **errp);
 
 #endif /* NMI_H */
-- 
2.5.5

  parent reply	other threads:[~2016-05-19 22:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-19 22:15 [Qemu-devel] [PATCH 0/4] Minor nmi cleanups Bandan Das
2016-05-19 22:15 ` [Qemu-devel] [PATCH 1/4] target-i386: add a generic x86 nmi handler Bandan Das
2016-05-19 22:15 ` [Qemu-devel] [PATCH 2/4] nmi: remove x86 specific nmi handling Bandan Das
2016-05-19 22:15 ` Bandan Das [this message]
2016-05-19 22:15 ` [Qemu-devel] [PATCH 4/4] cpus: call the core nmi injection function Bandan Das
2016-05-20  7:50   ` Paolo Bonzini
2016-05-20 16:29     ` Bandan Das
2016-05-20  7:50   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1463696116-31631-4-git-send-email-bsd@redhat.com \
    --to=bsd@redhat.com \
    --cc=aik@ozlabs.ru \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.