All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: "David Airlie" <airlied@linux.ie>,
	"Jean-Christophe Plagniol-Villard" <plagnioj@jcrosoft.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
	dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Russell King - ARM Linux" <linux@armlinux.org.uk>,
	"Sascha Hauer" <kernel@pengutronix.de>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "Lothar Waßmann" <LW@KARO-electronics.de>
Subject: [PATCH 3/3] drm/imx: remove dead code
Date: Fri, 20 May 2016 15:34:54 +0200	[thread overview]
Message-ID: <1463751294-24769-4-git-send-email-LW@KARO-electronics.de> (raw)
In-Reply-To: <1463751294-24769-1-git-send-email-LW@KARO-electronics.de>

The 'mode_valid' flag is never set in this driver. Remove it and the
code that depends on it.

Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
---
 drivers/gpu/drm/imx/parallel-display.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/drivers/gpu/drm/imx/parallel-display.c b/drivers/gpu/drm/imx/parallel-display.c
index 440f34d..e37d0e6 100644
--- a/drivers/gpu/drm/imx/parallel-display.c
+++ b/drivers/gpu/drm/imx/parallel-display.c
@@ -39,7 +39,6 @@ struct imx_parallel_display {
 	int edid_len;
 	u32 bus_format;
 	u32 bus_flags;
-	int mode_valid;
 	struct drm_display_mode mode;
 	struct drm_panel *panel;
 };
@@ -74,17 +73,6 @@ static int imx_pd_connector_get_modes(struct drm_connector *connector)
 		num_modes = drm_add_edid_modes(connector, imxpd->edid);
 	}
 
-	if (imxpd->mode_valid) {
-		struct drm_display_mode *mode = drm_mode_create(connector->dev);
-
-		if (!mode)
-			return -EINVAL;
-		drm_mode_copy(mode, &imxpd->mode);
-		mode->type |= DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,
-		drm_mode_probed_add(connector, mode);
-		num_modes++;
-	}
-
 	if (np) {
 		struct drm_display_mode *mode = drm_mode_create(connector->dev);
 		struct videomode vm;
-- 
2.1.4

WARNING: multiple messages have this Message-ID (diff)
From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: "David Airlie" <airlied@linux.ie>,
	"Jean-Christophe Plagniol-Villard" <plagnioj@jcrosoft.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
	dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Russell King - ARM Linux" <linux@armlinux.org.uk>,
	"Sascha Hauer" <kernel@pengutronix.de>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "Lothar Waßmann" <LW@KARO-electronics.de>
Subject: [PATCH 3/3] drm/imx: remove dead code
Date: Fri, 20 May 2016 13:34:54 +0000	[thread overview]
Message-ID: <1463751294-24769-4-git-send-email-LW@KARO-electronics.de> (raw)
In-Reply-To: <1463751294-24769-1-git-send-email-LW@KARO-electronics.de>

The 'mode_valid' flag is never set in this driver. Remove it and the
code that depends on it.

Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
---
 drivers/gpu/drm/imx/parallel-display.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/drivers/gpu/drm/imx/parallel-display.c b/drivers/gpu/drm/imx/parallel-display.c
index 440f34d..e37d0e6 100644
--- a/drivers/gpu/drm/imx/parallel-display.c
+++ b/drivers/gpu/drm/imx/parallel-display.c
@@ -39,7 +39,6 @@ struct imx_parallel_display {
 	int edid_len;
 	u32 bus_format;
 	u32 bus_flags;
-	int mode_valid;
 	struct drm_display_mode mode;
 	struct drm_panel *panel;
 };
@@ -74,17 +73,6 @@ static int imx_pd_connector_get_modes(struct drm_connector *connector)
 		num_modes = drm_add_edid_modes(connector, imxpd->edid);
 	}
 
-	if (imxpd->mode_valid) {
-		struct drm_display_mode *mode = drm_mode_create(connector->dev);
-
-		if (!mode)
-			return -EINVAL;
-		drm_mode_copy(mode, &imxpd->mode);
-		mode->type |= DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,
-		drm_mode_probed_add(connector, mode);
-		num_modes++;
-	}
-
 	if (np) {
 		struct drm_display_mode *mode = drm_mode_create(connector->dev);
 		struct videomode vm;
-- 
2.1.4


WARNING: multiple messages have this Message-ID (diff)
From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: "David Airlie" <airlied@linux.ie>,
	"Jean-Christophe Plagniol-Villard" <plagnioj@jcrosoft.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
	dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Russell King - ARM Linux" <linux@armlinux.org.uk>,
	"Sascha Hauer" <kernel@pengutronix.de>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "Lothar Waßmann" <LW@KARO-electronics.de>
Subject: [PATCH 3/3] drm/imx: remove dead code
Date: Fri, 20 May 2016 15:34:54 +0200	[thread overview]
Message-ID: <1463751294-24769-4-git-send-email-LW@KARO-electronics.de> (raw)
In-Reply-To: <1463751294-24769-1-git-send-email-LW@KARO-electronics.de>

The 'mode_valid' flag is never set in this driver. Remove it and the
code that depends on it.

Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
---
 drivers/gpu/drm/imx/parallel-display.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/drivers/gpu/drm/imx/parallel-display.c b/drivers/gpu/drm/imx/parallel-display.c
index 440f34d..e37d0e6 100644
--- a/drivers/gpu/drm/imx/parallel-display.c
+++ b/drivers/gpu/drm/imx/parallel-display.c
@@ -39,7 +39,6 @@ struct imx_parallel_display {
 	int edid_len;
 	u32 bus_format;
 	u32 bus_flags;
-	int mode_valid;
 	struct drm_display_mode mode;
 	struct drm_panel *panel;
 };
@@ -74,17 +73,6 @@ static int imx_pd_connector_get_modes(struct drm_connector *connector)
 		num_modes = drm_add_edid_modes(connector, imxpd->edid);
 	}
 
-	if (imxpd->mode_valid) {
-		struct drm_display_mode *mode = drm_mode_create(connector->dev);
-
-		if (!mode)
-			return -EINVAL;
-		drm_mode_copy(mode, &imxpd->mode);
-		mode->type |= DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,
-		drm_mode_probed_add(connector, mode);
-		num_modes++;
-	}
-
 	if (np) {
 		struct drm_display_mode *mode = drm_mode_create(connector->dev);
 		struct videomode vm;
-- 
2.1.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2016-05-20 13:53 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-20 13:34 [PATCH 0/3] drm/imx: convey the pixelclk-active and de-active flags to the ipu-di driver Lothar Waßmann
2016-05-20 13:34 ` Lothar Waßmann
2016-05-20 13:34 ` Lothar Waßmann
2016-05-20 13:34 ` [PATCH 1/3] drm/imx: imx-ldb: honor 'native-mode' property when selecting video mode from DT Lothar Waßmann
2016-05-20 13:34   ` Lothar Waßmann
2016-05-20 13:34   ` Lothar Waßmann
2016-05-20 13:34 ` [PATCH 2/3] drm/imx: convey the pixelclk-active and de-active flags from DT to the ipu-di driver Lothar Waßmann
2016-05-20 13:34   ` Lothar Waßmann
2016-05-20 13:34   ` Lothar Waßmann
2016-05-20 14:31   ` Philipp Zabel
2016-05-20 14:31     ` Philipp Zabel
2016-05-20 14:31     ` Philipp Zabel
2016-05-20 13:34 ` Lothar Waßmann [this message]
2016-05-20 13:34   ` [PATCH 3/3] drm/imx: remove dead code Lothar Waßmann
2016-05-20 13:34   ` Lothar Waßmann
2016-05-24  6:31 ` [PATCHv2 0/3] drm/imx: convey the pixelclk-active and de-active flags from DT to the ipu-di driver Lothar Waßmann
2016-05-24  6:31   ` [PATCHv2 1/3] drm/imx: imx-ldb: honor 'native-mode' property when selecting video mode from DT Lothar Waßmann
2016-05-24  6:31   ` [PATCHv2 2/3] drm/imx: convey the pixelclk-active and de-active flags from DT to the ipu-di driver Lothar Waßmann
2016-05-24 14:16     ` Philipp Zabel
2016-05-24 14:16       ` Philipp Zabel
2016-05-25  6:11       ` Lothar Waßmann
2016-05-25 10:26         ` Philipp Zabel
2016-05-25 10:26           ` Philipp Zabel
2016-05-24  6:31   ` [PATCHv2 3/3] drm/imx: remove dead code Lothar Waßmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1463751294-24769-4-git-send-email-LW@KARO-electronics.de \
    --to=lw@karo-electronics.de \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=p.zabel@pengutronix.de \
    --cc=plagnioj@jcrosoft.com \
    --cc=tomi.valkeinen@ti.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.