All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Andreas Färber" <afaerber@suse.de>,
	qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>
Subject: [Qemu-devel] [PULL 04/15] osdep: Move default qemu_hw_version() value to a macro
Date: Mon, 23 May 2016 16:24:16 -0300	[thread overview]
Message-ID: <1464031467-20736-5-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1464031467-20736-1-git-send-email-ehabkost@redhat.com>

The macro will be used by code that will stop calling
qemu_hw_version() at runtime and just need a constant value.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 include/qemu/osdep.h | 9 +++++++++
 util/osdep.c         | 9 +--------
 2 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
index 994bfa0..6937694 100644
--- a/include/qemu/osdep.h
+++ b/include/qemu/osdep.h
@@ -327,6 +327,15 @@ static inline void qemu_timersub(const struct timeval *val1,
 
 void qemu_set_cloexec(int fd);
 
+/* Starting on QEMU 2.5, qemu_hw_version() returns "2.5+" by default
+ * instead of QEMU_VERSION, so setting hw_version on MachineClass
+ * is no longer mandatory.
+ *
+ * Do NOT change this string, or it will break compatibility on all
+ * machine classes that don't set hw_version.
+ */
+#define QEMU_HW_VERSION "2.5+"
+
 /* QEMU "hardware version" setting. Used to replace code that exposed
  * QEMU_VERSION to guests in the past and need to keep compatibility.
  * Do not use qemu_hw_version() in new code.
diff --git a/util/osdep.c b/util/osdep.c
index d56d071..9a7a439 100644
--- a/util/osdep.c
+++ b/util/osdep.c
@@ -44,14 +44,7 @@ extern int madvise(caddr_t, size_t, int);
 
 static bool fips_enabled = false;
 
-/* Starting on QEMU 2.5, qemu_hw_version() returns "2.5+" by default
- * instead of QEMU_VERSION, so setting hw_version on MachineClass
- * is no longer mandatory.
- *
- * Do NOT change this string, or it will break compatibility on all
- * machine classes that don't set hw_version.
- */
-static const char *hw_version = "2.5+";
+static const char *hw_version = QEMU_HW_VERSION;
 
 int socket_set_cork(int fd, int v)
 {
-- 
2.5.5

  parent reply	other threads:[~2016-05-23 19:25 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-23 19:24 [Qemu-devel] [PULL 00/15] X86 queue, 2016-05-23 Eduardo Habkost
2016-05-23 19:24 ` [Qemu-devel] [PULL 01/15] target-i386: Define structs for layout of xsave area Eduardo Habkost
2016-05-23 19:24 ` [Qemu-devel] [PULL 02/15] target-i386: Use xsave structs for ext_save_area Eduardo Habkost
2016-05-23 19:24 ` [Qemu-devel] [PULL 03/15] target-i386: kvm: Use X86XSaveArea struct for xsave save/load Eduardo Habkost
2016-05-23 19:24 ` Eduardo Habkost [this message]
2016-05-23 19:24 ` [Qemu-devel] [PULL 05/15] pc: Set CPU model-id on compat_props for pc <= 2.4 Eduardo Habkost
2016-05-23 19:24 ` [Qemu-devel] [PULL 06/15] target-i386: Set constant model_id for qemu63/qemu32/athlon Eduardo Habkost
2016-05-23 20:49   ` Andreas Färber
2016-05-23 22:49     ` Eduardo Habkost
2016-05-23 19:24 ` [Qemu-devel] [PULL 07/15] cpu: Eliminate cpudef_init(), cpudef_setup() Eduardo Habkost
2016-05-23 19:24 ` [Qemu-devel] [PULL 08/15] target-i386: Move TCG initialization check to tcg_x86_init() Eduardo Habkost
2016-05-23 19:24 ` [Qemu-devel] [PULL 09/15] target-i386: Move TCG initialization to realize time Eduardo Habkost
2016-05-23 19:24 ` [Qemu-devel] [PULL 10/15] target-i386: Call cpu_exec_init() on realize Eduardo Habkost
2016-05-23 19:24 ` [Qemu-devel] [PULL 11/15] target-i386: kvm: Allocate kvm_msrs struct once per VCPU Eduardo Habkost
2016-05-23 19:24 ` [Qemu-devel] [PULL 12/15] target-i386: kvm: Increase MSR_BUF_SIZE Eduardo Habkost
2016-05-23 19:24 ` [Qemu-devel] [PULL 13/15] target-i386: kvm: Simplify MSR array construction Eduardo Habkost
2016-05-23 19:24 ` [Qemu-devel] [PULL 14/15] target-i386: kvm: Simplify MSR setting functions Eduardo Habkost
2016-05-23 19:24 ` [Qemu-devel] [PULL 15/15] target-i386: kvm: Eliminate kvm_msr_entry_set() Eduardo Habkost
2016-05-23 22:50 ` [Qemu-devel] [PULL 00/15] X86 queue, 2016-05-23 Eduardo Habkost
2016-05-24 13:10   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464031467-20736-5-git-send-email-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=afaerber@suse.de \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.