All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Subject: [PATCH 6/6] drm/i915: Only switch to default context when evicting from GGTT
Date: Wed, 25 May 2016 12:48:53 +0100	[thread overview]
Message-ID: <1464176933-31067-7-git-send-email-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <1464176933-31067-1-git-send-email-chris@chris-wilson.co.uk>

The contexts only pin space within the global GTT. Therefore forcing the
switch to the perma-pinned kernel context only has an effect when trying
to evict from and find room within the global GTT. We can then restrict
the switch to only when operating on the default context. This is mostly
a no-op as full-ppgtt only exists with execlists at present which skips
the context switch anyway.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/i915_gem_evict.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_gem_evict.c b/drivers/gpu/drm/i915/i915_gem_evict.c
index 5741b58d186c..3c1280ec7ff6 100644
--- a/drivers/gpu/drm/i915/i915_gem_evict.c
+++ b/drivers/gpu/drm/i915/i915_gem_evict.c
@@ -183,9 +183,11 @@ none:
 	if (pass++ == 0) {
 		struct drm_i915_private *dev_priv = to_i915(dev);
 
-		ret = switch_to_pinned_context(dev_priv);
-		if (ret)
-			return ret;
+		if (i915_is_ggtt(vm)) {
+			ret = switch_to_pinned_context(dev_priv);
+			if (ret)
+				return ret;
+		}
 
 		ret = i915_gem_wait_for_idle(dev_priv);
 		if (ret)
@@ -300,9 +302,11 @@ int i915_gem_evict_vm(struct i915_address_space *vm, bool do_idle)
 	if (do_idle) {
 		struct drm_i915_private *dev_priv = to_i915(vm->dev);
 
-		ret = switch_to_pinned_context(dev_priv);
-		if (ret)
-			return ret;
+		if (i915_is_ggtt(vm)) {
+			ret = switch_to_pinned_context(dev_priv);
+			if (ret)
+				return ret;
+		}
 
 		ret = i915_gem_wait_for_idle(dev_priv);
 		if (ret)
-- 
2.8.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2016-05-25 11:49 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-25 11:48 Bug 95634, avoid fresh work on shutdown Chris Wilson
2016-05-25 11:48 ` [PATCH 1/6] drm/i915: Skip idling an idle engine Chris Wilson
2016-05-25 11:48 ` [PATCH 2/6] drm/i915: Treat kernel context as initialised Chris Wilson
2016-05-25 12:38   ` Joonas Lahtinen
2016-05-25 12:58     ` Chris Wilson
2016-05-25 12:42   ` Chris Wilson
2016-05-25 14:16   ` Mika Kuoppala
2016-05-25 14:38     ` Chris Wilson
2016-05-25 14:58     ` [PATCH] drm/i915: Defer enabling rc6 til after we submit the first batch/context Chris Wilson
2016-05-25 15:33       ` Chris Wilson
2016-05-25 17:07       ` Chris Wilson
2016-05-25 11:48 ` [PATCH 3/6] drm/i915: Mark all default contexts as uninitialised after context loss Chris Wilson
2016-05-25 12:43   ` Joonas Lahtinen
2016-05-25 11:48 ` [PATCH 4/6] drm/i915: No need to wait for idle on L3 remap Chris Wilson
2016-05-25 14:27   ` Mika Kuoppala
2016-05-25 11:48 ` [PATCH 5/6] drm/i915: Split idling from forcing context switch Chris Wilson
2016-05-25 12:57   ` Joonas Lahtinen
2016-05-25 13:12     ` Chris Wilson
2016-05-25 11:48 ` Chris Wilson [this message]
2016-05-25 12:09 ` ✗ Ro.CI.BAT: failure for series starting with [1/6] drm/i915: Skip idling an idle engine Patchwork
2016-05-25 14:04 ` [PATCH v2 1/6] " Chris Wilson
2016-05-25 14:04   ` [PATCH v2 2/6] drm/i915: Move legacy kernel context pinning to intel_ringbuffer.c Chris Wilson
2016-05-26 10:22     ` Joonas Lahtinen
2016-05-26 10:29       ` Chris Wilson
2016-05-26 11:18       ` [PATCH] " Chris Wilson
2016-05-26 11:30         ` Joonas Lahtinen
2016-05-26 12:52         ` Mika Kuoppala
2016-05-25 14:04   ` [PATCH v2 3/6] drm/i915: Treat kernel context as initialised Chris Wilson
2016-05-25 14:04   ` [PATCH v2 4/6] drm/i915: Mark all default contexts as uninitialised after context loss Chris Wilson
2016-05-25 14:04   ` [PATCH v2 5/6] drm/i915: No need to wait for idle on L3 remap Chris Wilson
2016-05-25 14:04   ` [PATCH v2 6/6] drm/i915: Split idling from forcing context switch Chris Wilson
2016-05-25 14:59 ` ✗ Ro.CI.BAT: failure for series starting with [1/6] drm/i915: Skip idling an idle engine (rev6) Patchwork
2016-05-25 15:00 ` ✗ Ro.CI.BAT: failure for series starting with [1/6] drm/i915: Skip idling an idle engine (rev7) Patchwork
2016-05-26  5:00 ` ✗ Ro.CI.BAT: failure for series starting with [1/6] drm/i915: Skip idling an idle engine (rev8) Patchwork
2016-05-26 11:20 ` ✗ Ro.CI.BAT: failure for series starting with [1/6] drm/i915: Skip idling an idle engine (rev9) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464176933-31067-7-git-send-email-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=mika.kuoppala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.